Go to file
scroggo@google.com 7d8013f306 Changes to SkTDStackNester.
SkTDStackNester is a class used by PdfViewer to assist in saving
and restoring the PDF state. Clean up and test this class.

Add some documentation.

Add FIXME's where I have questions to resolve.

Fix a bug where fNestingLevel was not initialized.

Remove a commented out line of code copied over from
SkTDStack.

Rename SkTDStackNester::nests() to nestingLevel() and make it const.

Remove unnecessary predeclaration and friend declaration.

Remove index() (both const and non-const versions). They were
unused, return something that may not be expected (index from
the top, rather than from the bottom), and don't work to get any
elements in earlier Recs once the first one is full.

Report a warning if the nesting level goes above the maximum level,
or if we attempt to bring it below zero.

Prevent fNestingLevel from dropping below zero.

Add kUnusedObject_SkPdfIssue, and use it where appropriate.

Depends on https://codereview.chromium.org/64093009/

R=mtklein@google.com

Review URL: https://codereview.chromium.org/68843006

git-svn-id: http://skia.googlecode.com/svn/trunk@12328 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 21:40:57 +00:00
animations first cut at a checkbox 2009-10-21 19:41:10 +00:00
bench Reverting r12315 (More Windows 64b compilation warning fixes) due to compilation failures 2013-11-20 15:56:14 +00:00
debugger move SkImage::ColorType into SkColorType 2013-11-01 13:46:54 +00:00
dm Fix a warning building DM using ninja on Mac. 2013-11-20 16:44:59 +00:00
expectations Update expectations for Ubuntu x32 bot. 2013-11-20 17:08:13 +00:00
experimental Changes to SkTDStackNester. 2013-11-20 21:40:57 +00:00
forth Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
gm Remove unnamed namespace usage from 'gm'. 2013-11-20 21:32:10 +00:00
gyp Changes to SkTDStackNester. 2013-11-20 21:40:57 +00:00
include Reverting r12315 (More Windows 64b compilation warning fixes) due to compilation failures 2013-11-20 15:56:14 +00:00
platform_tools Add extra warnings to match what Android uses. 2013-11-20 15:13:49 +00:00
resources Bench baseline for mostly 0 image. 2013-09-25 21:42:12 +00:00
samplecode Guard against most unintentionally ephemeral SkAutoFoo instantiations. 2013-11-18 16:03:59 +00:00
src Fix SkMatrix44::invert(...) for identity matrices and a NULL parameter 2013-11-20 21:32:27 +00:00
tests Changes to SkTDStackNester. 2013-11-20 21:40:57 +00:00
third_party Hook in rough distance field support for fonts 2013-11-11 20:54:09 +00:00
tools rebaseline_server: clean up thread locks 2013-11-20 19:58:06 +00:00
trybots_to_run/chrome Deleting the hardcoded list of compile bots in trybots_to_run. 2013-04-09 11:59:42 +00:00
.gitignore leading slash confuses non-git tools that read .gitignore, like ag 2013-07-30 17:23:01 +00:00
codereview.settings Removing blank lines from codereview.settings. 2013-02-26 16:01:21 +00:00
DEPS Roll gyp from r1684 to r1765. 2013-10-21 18:49:43 +00:00
Doxyfile Pointing to http://skia-autogen.googlecode.com/svn/docs/html/index.html in Doxyfile 2012-07-03 11:35:07 +00:00
gyp_skia Fix ninja build on Android 2013-10-01 15:31:54 +00:00
LICENSE Manually update copyright notices in files that defied the automated process 2011-07-28 14:24:55 +00:00
make.bat Make make.bat and gyp_skia work with VS 2012. 2013-05-07 19:31:20 +00:00
make.py Use SKIA_OUT variable in make.py 2013-07-23 15:45:50 +00:00
Makefile pathops work in progress 2013-11-01 17:36:03 +00:00
Makefile.old Replace GR_*_BUILD by their SK_BUILD_FOR_* equivalents. 2013-09-25 20:57:51 +00:00
OWNERS add root files from chrome 2013-08-13 19:11:15 +00:00
PRESUBMIT.py If any change is made to the public API then make sure there is an LGTM from an owner. 2013-08-12 14:51:20 +00:00
README whitespace commit to trigger buildbot 2011-07-15 14:11:58 +00:00
README.chromium add root files from chrome 2013-08-13 19:11:15 +00:00
skia.gyp gyp: generate "everything" and "most" targets instead of "all" 2012-10-25 16:32:07 +00:00
whitespace.txt Whitespace change to test CQ. 2013-11-17 16:19:11 +00:00

Skia is a complete 2D graphic library for drawing Text, Geometries, and Images.

See full details, and build instructions, at http://code.google.com/p/skia/wiki/DocRoot