68d6ff9222
SkTypes.h was found exporting <stddef.h> and <stdint.h>.
Thus if a Skia file includes SkTypes.h, it did not need
to include either of those files to use things like
size_t or uint8_t respectively. [1]
This also resulted in strange IWYU warnings like:
warning: size_t is defined in "include/core/SkTypes.h", which isn't directly #included.
Thus, this CL removes those additional exports, and as a result,
adds many more includes of <cstddef> and <cstdint>.
The second change this CL is to not use the default IWYU
mappings which are hard-coded into IWYU [2]. These defaults
are valid, but make suggestions for the C version of
headers and not the C++ ones (i.e. <stddef.h> over <cstddef>).
To make these recommendations align better with our preferred
style (the C++ ones), we use IWYU with --no_default_mappings
and then have to expand our existing mappings to better deal
with how IWYU would resolve some of these headers.
[1] https://codereview.chromium.org/1207893002/#msg49
[2]
|
||
|---|---|---|
| .. | ||
| linux_trampolines | ||
| mac_trampolines | ||
| BUILD.bazel | ||
| download_linux_amd64_toolchain.bzl | ||
| download_mac_toolchain.bzl | ||
| download_toolchains.bzl | ||
| linux_amd64_toolchain_config.bzl | ||
| mac_toolchain_config.bzl | ||
| utils.bzl | ||