8318cc9928
Previously, our ID canonicalization was simply "lower ID numbers before higher ID numbers" and was done separately at every opcode by taking the min and max of (x.id, y.id). Now, this logic is factored out into a helper function `canonicalizeIdOrder` and has two rules: - Immediate values go last; that is, "x + 1" instead of "1 + x". - If both/neither are immediate, lower IDs before higher IDs (as before) This change lets us remove a lot of simplification logic. We no longer need to check for both `x + 0` and `0 + x` when removing no-op arithmetic; now we can be certain that the immediate will always come last, so just checking for `x + 0` is sufficient. Change-Id: I66cc5c23bba414041c0bc556521d3db57fac504d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/524222 Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> |
||
|---|---|---|
| .. | ||
| blend | ||
| errors | ||
| folding | ||
| glsl | ||
| inliner | ||
| intrinsics | ||
| metal | ||
| runtime | ||
| runtime_errors | ||
| shared | ||
| spirv | ||
| workarounds | ||
| README.txt | ||
This directory contains skslc-compiled output from matching source files in the /resources/sksl/ directory.