50ea3c06b8
This enables four different options in the compiler, described below. I also added enough masks to satisfy RTCc when running all GMs in both 8888 and gl configs. --- /RTCc - Detects when a value is assigned to a smaller data type and results in data loss. This happens even when casting. Masking is required to suppress this. /RTCs - Various stack-related checks, including uninitialized data (by initializing locals to a non-zero value), array bounds checking, and stack pointer corruption that can occur with a calling convention mismatch. /RTCu - Reports when a variable is used without having been initialized. Mostly redundant with compile-time checks. /guard:cf - This is more of a security option, that computes all possible targets for indirect calls at compile time, and verifies that those are the only targets reached at compile time. Also generates similar logic around switch statements that turn into jump tables. Bug: skia: Change-Id: I7b527af8fd67dec0b6556f38bcd0efc3fd505856 Reviewed-on: https://skia-review.googlesource.com/c/188625 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
295 lines
8.7 KiB
C++
295 lines
8.7 KiB
C++
/*
|
|
* Copyright 2014 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "SkMatrix.h"
|
|
#include "SkRandom.h"
|
|
#include "SkString.h"
|
|
#include "Test.h"
|
|
|
|
#include "GrTRecorder.h"
|
|
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
|
|
static int activeRecorderItems = 0;
|
|
|
|
class IntWrapper {
|
|
public:
|
|
IntWrapper() {}
|
|
IntWrapper(int value) : fValue(value) {}
|
|
operator int() { return fValue; }
|
|
private:
|
|
int fValue;
|
|
};
|
|
|
|
static void test_empty_back_and_pop(skiatest::Reporter* reporter) {
|
|
SkRandom rand;
|
|
for (int data = 0; data < 2; ++data) {
|
|
// Do this with different starting sizes to have different alignment between blocks and pops.
|
|
// pops. We want to test poping the first guy off, guys in the middle of the block, and the
|
|
// first guy on a non-head block.
|
|
for (int j = 0; j < 8; ++j) {
|
|
GrTRecorder<IntWrapper, int> recorder(j);
|
|
|
|
REPORTER_ASSERT(reporter, recorder.empty());
|
|
|
|
for (int i = 0; i < 100; ++i) {
|
|
if (data) {
|
|
REPORTER_ASSERT(reporter, i == *GrNEW_APPEND_TO_RECORDER(recorder,
|
|
IntWrapper, (i)));
|
|
} else {
|
|
REPORTER_ASSERT(reporter, i ==
|
|
*GrNEW_APPEND_WITH_DATA_TO_RECORDER(recorder,
|
|
IntWrapper, (i),
|
|
rand.nextULessThan(10)));
|
|
}
|
|
REPORTER_ASSERT(reporter, !recorder.empty());
|
|
REPORTER_ASSERT(reporter, i == recorder.back());
|
|
if (0 == (i % 7)) {
|
|
recorder.pop_back();
|
|
if (i > 0) {
|
|
REPORTER_ASSERT(reporter, !recorder.empty());
|
|
REPORTER_ASSERT(reporter, i-1 == recorder.back());
|
|
}
|
|
}
|
|
}
|
|
|
|
REPORTER_ASSERT(reporter, !recorder.empty());
|
|
recorder.reset();
|
|
REPORTER_ASSERT(reporter, recorder.empty());
|
|
}
|
|
}
|
|
}
|
|
|
|
struct ExtraData {
|
|
typedef GrTRecorder<ExtraData, int> Recorder;
|
|
|
|
ExtraData(int i) : fData(i) {
|
|
int* extraData = this->extraData();
|
|
for (int j = 0; j < i; j++) {
|
|
extraData[j] = i;
|
|
}
|
|
++activeRecorderItems;
|
|
}
|
|
~ExtraData() {
|
|
--activeRecorderItems;
|
|
}
|
|
int* extraData() {
|
|
return reinterpret_cast<int*>(Recorder::GetDataForItem(this));
|
|
}
|
|
int fData;
|
|
};
|
|
|
|
static void test_extra_data(skiatest::Reporter* reporter) {
|
|
ExtraData::Recorder recorder(0);
|
|
for (int i = 0; i < 100; ++i) {
|
|
GrNEW_APPEND_WITH_DATA_TO_RECORDER(recorder, ExtraData, (i), i * sizeof(int));
|
|
}
|
|
REPORTER_ASSERT(reporter, 100 == activeRecorderItems);
|
|
|
|
ExtraData::Recorder::Iter iter(recorder);
|
|
for (int i = 0; i < 100; ++i) {
|
|
REPORTER_ASSERT(reporter, iter.next());
|
|
REPORTER_ASSERT(reporter, i == iter->fData);
|
|
for (int j = 0; j < i; j++) {
|
|
REPORTER_ASSERT(reporter, i == iter->extraData()[j]);
|
|
}
|
|
}
|
|
REPORTER_ASSERT(reporter, !iter.next());
|
|
|
|
ExtraData::Recorder::ReverseIter reverseIter(recorder);
|
|
for (int i = 99; i >= 0; --i) {
|
|
REPORTER_ASSERT(reporter, i == reverseIter->fData);
|
|
for (int j = 0; j < i; j++) {
|
|
REPORTER_ASSERT(reporter, i == reverseIter->extraData()[j]);
|
|
}
|
|
REPORTER_ASSERT(reporter, reverseIter.previous() == !!i);
|
|
}
|
|
|
|
recorder.reset();
|
|
REPORTER_ASSERT(reporter, 0 == activeRecorderItems);
|
|
}
|
|
|
|
enum ClassType {
|
|
kBase_ClassType,
|
|
kSubclass_ClassType,
|
|
kSubSubclass_ClassType,
|
|
kSubclassExtraData_ClassType,
|
|
kSubclassEmpty_ClassType,
|
|
|
|
kNumClassTypes
|
|
};
|
|
|
|
class Base {
|
|
public:
|
|
typedef GrTRecorder<Base, void*> Recorder;
|
|
|
|
Base() {
|
|
fMatrix.reset();
|
|
++activeRecorderItems;
|
|
}
|
|
|
|
virtual ~Base() { --activeRecorderItems; }
|
|
|
|
virtual ClassType getType() { return kBase_ClassType; }
|
|
|
|
virtual void validate(skiatest::Reporter* reporter) const {
|
|
REPORTER_ASSERT(reporter, fMatrix.isIdentity());
|
|
}
|
|
|
|
private:
|
|
SkMatrix fMatrix;
|
|
};
|
|
|
|
class Subclass : public Base {
|
|
public:
|
|
Subclass() : fString("Lorem ipsum dolor sit amet") {}
|
|
|
|
virtual ClassType getType() { return kSubclass_ClassType; }
|
|
|
|
virtual void validate(skiatest::Reporter* reporter) const {
|
|
Base::validate(reporter);
|
|
REPORTER_ASSERT(reporter, !strcmp("Lorem ipsum dolor sit amet", fString.c_str()));
|
|
}
|
|
|
|
private:
|
|
SkString fString;
|
|
};
|
|
|
|
class SubSubclass : public Subclass {
|
|
public:
|
|
SubSubclass() : fInt(1234), fFloat(1.234f) {}
|
|
|
|
virtual ClassType getType() { return kSubSubclass_ClassType; }
|
|
|
|
virtual void validate(skiatest::Reporter* reporter) const {
|
|
Subclass::validate(reporter);
|
|
REPORTER_ASSERT(reporter, 1234 == fInt);
|
|
REPORTER_ASSERT(reporter, 1.234f == fFloat);
|
|
}
|
|
|
|
private:
|
|
int fInt;
|
|
float fFloat;
|
|
};
|
|
|
|
class SubclassExtraData : public Base {
|
|
public:
|
|
SubclassExtraData(int length) : fLength(length) {
|
|
int* data = reinterpret_cast<int*>(Recorder::GetDataForItem(this));
|
|
for (int i = 0; i < fLength; ++i) {
|
|
data[i] = ValueAt(i);
|
|
}
|
|
}
|
|
|
|
virtual ClassType getType() { return kSubclassExtraData_ClassType; }
|
|
|
|
virtual void validate(skiatest::Reporter* reporter) const {
|
|
Base::validate(reporter);
|
|
const int* data = reinterpret_cast<const int*>(Recorder::GetDataForItem(this));
|
|
for (int i = 0; i < fLength; ++i) {
|
|
REPORTER_ASSERT(reporter, ValueAt(i) == data[i]);
|
|
}
|
|
}
|
|
|
|
private:
|
|
static int ValueAt(uint64_t i) {
|
|
return static_cast<int>((123456789 + 987654321 * i) & 0xFFFFFFFF);
|
|
}
|
|
int fLength;
|
|
};
|
|
|
|
class SubclassEmpty : public Base {
|
|
public:
|
|
virtual ClassType getType() { return kSubclassEmpty_ClassType; }
|
|
};
|
|
|
|
class Order {
|
|
public:
|
|
Order() { this->reset(); }
|
|
void reset() { fCurrent = 0; }
|
|
ClassType next() {
|
|
fCurrent = 1664525 * fCurrent + 1013904223;
|
|
return static_cast<ClassType>(fCurrent % kNumClassTypes);
|
|
}
|
|
private:
|
|
uint32_t fCurrent;
|
|
};
|
|
static void test_subclasses_iters(skiatest::Reporter*, Order&, Base::Recorder::Iter&,
|
|
Base::Recorder::ReverseIter&, int = 0);
|
|
static void test_subclasses(skiatest::Reporter* reporter) {
|
|
Base::Recorder recorder(1024);
|
|
|
|
Order order;
|
|
for (int i = 0; i < 1000; i++) {
|
|
switch (order.next()) {
|
|
case kBase_ClassType:
|
|
GrNEW_APPEND_TO_RECORDER(recorder, Base, ());
|
|
break;
|
|
|
|
case kSubclass_ClassType:
|
|
GrNEW_APPEND_TO_RECORDER(recorder, Subclass, ());
|
|
break;
|
|
|
|
case kSubSubclass_ClassType:
|
|
GrNEW_APPEND_TO_RECORDER(recorder, SubSubclass, ());
|
|
break;
|
|
|
|
case kSubclassExtraData_ClassType:
|
|
GrNEW_APPEND_WITH_DATA_TO_RECORDER(recorder, SubclassExtraData, (i), sizeof(int) * i);
|
|
break;
|
|
|
|
case kSubclassEmpty_ClassType:
|
|
GrNEW_APPEND_TO_RECORDER(recorder, SubclassEmpty, ());
|
|
break;
|
|
|
|
default:
|
|
ERRORF(reporter, "Invalid class type");
|
|
break;
|
|
}
|
|
}
|
|
REPORTER_ASSERT(reporter, 1000 == activeRecorderItems);
|
|
|
|
order.reset();
|
|
Base::Recorder::Iter iter(recorder);
|
|
Base::Recorder::ReverseIter reverseIter(recorder);
|
|
|
|
test_subclasses_iters(reporter, order, iter, reverseIter);
|
|
|
|
REPORTER_ASSERT(reporter, !iter.next());
|
|
|
|
// Don't reset the recorder. It should automatically destruct all its items.
|
|
}
|
|
static void test_subclasses_iters(skiatest::Reporter* reporter, Order& order,
|
|
Base::Recorder::Iter& iter,
|
|
Base::Recorder::ReverseIter& reverseIter, int i) {
|
|
if (i >= 1000) {
|
|
return;
|
|
}
|
|
|
|
ClassType classType = order.next();
|
|
|
|
REPORTER_ASSERT(reporter, iter.next());
|
|
REPORTER_ASSERT(reporter, classType == iter->getType());
|
|
iter->validate(reporter);
|
|
|
|
test_subclasses_iters(reporter, order, iter, reverseIter, i + 1);
|
|
|
|
REPORTER_ASSERT(reporter, classType == reverseIter->getType());
|
|
reverseIter->validate(reporter);
|
|
REPORTER_ASSERT(reporter, reverseIter.previous() == !!i);
|
|
}
|
|
|
|
DEF_GPUTEST(GrTRecorder, reporter, /* options */) {
|
|
test_empty_back_and_pop(reporter);
|
|
|
|
test_extra_data(reporter);
|
|
REPORTER_ASSERT(reporter, 0 == activeRecorderItems); // test_extra_data should call reset().
|
|
|
|
test_subclasses(reporter);
|
|
REPORTER_ASSERT(reporter, 0 == activeRecorderItems); // Ensure ~GrTRecorder invokes dtors.
|
|
}
|