dbfd7ab108
'static const' means, there must be at most one of these, and initialize it at compile time if possible or runtime if necessary. This leads to unexpected code execution, and TSAN* will complain about races on the guard variables. Generally 'constexpr' or 'const' are better choices. Neither can cause races: they're either intialized at compile time (constexpr) or intialized each time independently (const). This CL prefers constexpr where possible, and uses const where not. It even prefers constexpr over const where they don't make a difference... I want to have lots of examples of constexpr for people to see and mimic. The scoped-to-class static has nothing to do with any of this, and is not changed. * Not yet on the bots, which use an older TSAN. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300623005 Review-Url: https://codereview.chromium.org/2300623005
121 lines
4.0 KiB
C++
121 lines
4.0 KiB
C++
/*
|
|
* Copyright 2013 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "SkCanvas.h"
|
|
#include "SkColor.h"
|
|
#include "SkGradientShader.h"
|
|
#include "SkMatrix.h"
|
|
#include "SkPaint.h"
|
|
#include "SkPoint.h"
|
|
#include "SkRect.h"
|
|
#include "SkRefCnt.h"
|
|
#include "SkScalar.h"
|
|
#include "SkSize.h"
|
|
#include "SkString.h"
|
|
|
|
#include "gm.h"
|
|
|
|
constexpr SkColor gColors[] = {
|
|
SK_ColorRED, SK_ColorYELLOW
|
|
};
|
|
|
|
// These annoying defines are necessary, because the only other alternative
|
|
// is to use SkIntToScalar(...) everywhere.
|
|
constexpr SkScalar sZero = 0;
|
|
constexpr SkScalar sHalf = SK_ScalarHalf;
|
|
constexpr SkScalar sOne = SK_Scalar1;
|
|
|
|
// These arrays define the gradient stop points
|
|
// as x1, y1, x2, y2 per gradient to draw.
|
|
constexpr SkPoint linearPts[][2] = {
|
|
{{sZero, sZero}, {sOne, sZero}},
|
|
{{sZero, sZero}, {sZero, sOne}},
|
|
{{sOne, sZero}, {sZero, sZero}},
|
|
{{sZero, sOne}, {sZero, sZero}},
|
|
|
|
{{sZero, sZero}, {sOne, sOne}},
|
|
{{sOne, sOne}, {sZero, sZero}},
|
|
{{sOne, sZero}, {sZero, sOne}},
|
|
{{sZero, sOne}, {sOne, sZero}}
|
|
};
|
|
|
|
constexpr SkPoint radialPts[][2] = {
|
|
{{sZero, sHalf}, {sOne, sHalf}},
|
|
{{sHalf, sZero}, {sHalf, sOne}},
|
|
{{sOne, sHalf}, {sZero, sHalf}},
|
|
{{sHalf, sOne}, {sHalf, sZero}},
|
|
|
|
{{sZero, sZero}, {sOne, sOne}},
|
|
{{sOne, sOne}, {sZero, sZero}},
|
|
{{sOne, sZero}, {sZero, sOne}},
|
|
{{sZero, sOne}, {sOne, sZero}}
|
|
};
|
|
|
|
// These define the pixels allocated to each gradient image.
|
|
constexpr SkScalar TESTGRID_X = SkIntToScalar(200);
|
|
constexpr SkScalar TESTGRID_Y = SkIntToScalar(200);
|
|
|
|
constexpr int IMAGES_X = 4; // number of images per row
|
|
|
|
static sk_sp<SkShader> make_linear_gradient(const SkPoint pts[2], const SkMatrix& localMatrix) {
|
|
return SkGradientShader::MakeLinear(pts, gColors, nullptr, SK_ARRAY_COUNT(gColors),
|
|
SkShader::kClamp_TileMode, 0, &localMatrix);
|
|
}
|
|
|
|
static sk_sp<SkShader> make_radial_gradient(const SkPoint pts[2], const SkMatrix& localMatrix) {
|
|
SkPoint center;
|
|
center.set(SkScalarAve(pts[0].fX, pts[1].fX),
|
|
SkScalarAve(pts[0].fY, pts[1].fY));
|
|
float radius = (center - pts[0]).length();
|
|
return SkGradientShader::MakeRadial(center, radius, gColors, nullptr, SK_ARRAY_COUNT(gColors),
|
|
SkShader::kClamp_TileMode, 0, &localMatrix);
|
|
}
|
|
|
|
static void draw_gradients(SkCanvas* canvas,
|
|
sk_sp<SkShader> (*makeShader)(const SkPoint[2], const SkMatrix&),
|
|
const SkPoint ptsArray[][2], int numImages) {
|
|
// Use some nice prime numbers for the rectangle and matrix with
|
|
// different scaling along the x and y axes (which is the bug this
|
|
// test addresses, where incorrect order of operations mixed up the axes)
|
|
SkRect rectGrad = {
|
|
SkIntToScalar(43), SkIntToScalar(61),
|
|
SkIntToScalar(181), SkIntToScalar(167) };
|
|
SkMatrix shaderMat;
|
|
shaderMat.setScale(rectGrad.width(), rectGrad.height());
|
|
shaderMat.postTranslate(rectGrad.left(), rectGrad.top());
|
|
|
|
canvas->save();
|
|
for (int i = 0; i < numImages; i++) {
|
|
// Advance line downwards if necessary.
|
|
if (i % IMAGES_X == 0 && i != 0) {
|
|
canvas->restore();
|
|
canvas->translate(0, TESTGRID_Y);
|
|
canvas->save();
|
|
}
|
|
|
|
SkPaint paint;
|
|
paint.setShader(makeShader(*ptsArray, shaderMat));
|
|
canvas->drawRect(rectGrad, paint);
|
|
|
|
// Advance to next position.
|
|
canvas->translate(TESTGRID_X, 0);
|
|
ptsArray++;
|
|
}
|
|
canvas->restore();
|
|
}
|
|
|
|
DEF_SIMPLE_GM_BG(gradient_matrix, canvas, 800, 800,
|
|
sk_tool_utils::color_to_565(0xFFDDDDDD)) {
|
|
draw_gradients(canvas, &make_linear_gradient,
|
|
linearPts, SK_ARRAY_COUNT(linearPts));
|
|
|
|
canvas->translate(0, TESTGRID_Y);
|
|
|
|
draw_gradients(canvas, &make_radial_gradient,
|
|
radialPts, SK_ARRAY_COUNT(radialPts));
|
|
}
|