67c905ce6b
Inside SkOpEdgeBuilder::walk(), when current segment is cubic curve, its shape may be reduced, therefore, the curve points should be determined by the reduction result ‘split->fVerb’ instead of ‘verb’. Actually, inside this switch case, ‘verb’ is always ‘SkPath::kCubic_Verb’, which makes the ‘fCanAdd’ always true. The outcome of this bug makes the subsequent logic which depends on ‘fCanAdd’ (L301-332) incorrect, and in some cases, fails the whole boolean operation at L329. The Fiddle below demonstrates how this bug fails a union operation of two paths, by returning an empty path. https://fiddle.skia.org/c/e528567b62bc338cd99f4a89f0c5342e Screen shot of the fiddle: https://www.dropbox.com/s/4bnzlponq6gen27/pathOpsBug.png?dl=0 2nd Fiddle drawing the results (larger) https://fiddle.skia.org/c/1f2a513c2ee0395b9d05fb1eb987b01f Change-Id: If07f54cef1b9409f9b6db27d6294a3e3461b0181 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284426 Commit-Queue: Kevin Lubick <kjlubick@google.com> Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
68 lines
2.2 KiB
Plaintext
Executable File
68 lines
2.2 KiB
Plaintext
Executable File
# This is the official list of Skia authors for copyright purposes.
|
|
#
|
|
# Names should be added to this file with one of the following patterns:
|
|
#
|
|
# For individual contributors:
|
|
# Name <email address>
|
|
#
|
|
# For corporate contributors:
|
|
# Organization <fnmatch pattern>
|
|
# See examples below or python fnmatch module documentation for more information.
|
|
#
|
|
# Please keep the list sorted alphabetically.
|
|
|
|
Aaron O'Mullan <aaron.omullan@gmail.com>
|
|
ACCESS CO., LTD. <*@access-company.com>
|
|
Amazon, Inc <*@amazon.com>
|
|
Anthony Catel <paraboul@gmail.com>
|
|
ARM <*@arm.com>
|
|
Bharat Ahuja <ahujabharat93@gmail.com>
|
|
Dawson Coleman <dawsonmcoleman@gmail.com>
|
|
Deepak Mohan <hop2deep@gmail.com>
|
|
Ehsan Akhgari <ehsan.akhgari@gmail.com>
|
|
Facebook, Inc. <*fb.com>
|
|
George Wright <george@mozilla.com>
|
|
GiWan Go <gogil@stealien.com>
|
|
Google Inc. <*@google.com>
|
|
Herb Derby <herbderby@gmail.com>
|
|
Igalia <*@igalia.com>
|
|
Intel <*@intel.com>
|
|
Ion Rosca <rosca@adobe.com>
|
|
Jacek Caban <cjacek@gmail.com>
|
|
Jeff Muizelaar <jmuizelaar@mozilla.com>
|
|
Jongdeok Kim <jongdeok.kim@navercorp.com>
|
|
Lee Salzman <lsalzman@mozilla.com>
|
|
Marcin Kazmierczak <mar.kazmierczak@gmail.com>
|
|
Matthew Leibowitz <mattleibow@live.com>
|
|
Microsoft <*@microsoft.com>
|
|
MIPS <*@imgtec.com>
|
|
Ning Liu <ningliu@invisionapp.com>
|
|
Noah Lavine <noah.b.lavine@gmail.com>
|
|
NVIDIA <*@nvidia.com>
|
|
Opera Software ASA <*@opera.com>
|
|
Pavel Krajcevski <pavel@cs.unc.edu>
|
|
Petar Kirov <petar.p.kirov@gmail.com>
|
|
Raul Tambre <raul@tambre.ee>
|
|
Samsung <*@samsung.com>
|
|
Samsung Open Source Group <*@osg.samsung.com>
|
|
Sergey Melnikov <Melnikov.Sergey.V@gmail.com>
|
|
Shachar Langbeheim <nihohit@gmail.com>
|
|
Skia <*@skia.org>
|
|
Skia Buildbots <skia.buildbots@gmail.com>
|
|
Sony Mobile Communications Inc. <*@sonymobile.com>
|
|
Steve Singer <steve@ssinger.info>
|
|
Sylvestre Ledru <sylvestre.ledru@gmail.com>
|
|
The Chromium Authors <*@chromium.org>
|
|
Thiago Fransosi Farina <thiago.farina@gmail.com>
|
|
Jose Mayol <jei.mayol@gmail.com>
|
|
Linaro <*@linaro.org>
|
|
Christian Plesner Hansen <plesner@t.undra.org>
|
|
Marco Alesiani <marco.diiga@gmail.com>
|
|
Adobe Systems Incorporated <*@adobe.com>
|
|
Yandex LLC <*@yandex-team.ru>
|
|
Kaloyan Donev <kdonev@gmail.com>
|
|
Yong-Hwan Baek <meisterdevhwan@gmail.com>
|
|
Alexander Khovansky <alx.khovansky@gmail.com>
|
|
Zhuo Qingliang <zhuo.dev@gmail.com>
|
|
Mainframe North <*@mainframe.co.uk>
|