353e2c65c9
OpenGL docs specifically insist that the sequence (comma) operator should not be treated as a constant-expression so that attempts to declare multidimensional arrays with a comma will fail: http://screen/vJEpAe9yNmbzZTm (See "12.43 Sequence operator and constant expressions" in the OpenGL ES3 documentation or read skia:13311 for details.) In practice, we don't get much benefit from optimizing away unused comma-expressions; it improves some synthetic tests, but realistically this will not help Skia in any real-world scenario. The constant folder no longer attempts this optimization, and comma-expressions are now rejected in a constant-expression context. Change-Id: Ic5dea6ff90e36614b548c1ce89a444e81da944ae Bug: skia:13311 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539565 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: John Stiles <johnstiles@google.com> |
||
|---|---|---|
| .. | ||
| blend | ||
| errors | ||
| es2_conformance | ||
| folding | ||
| glsl | ||
| inliner | ||
| intrinsics | ||
| metal | ||
| runtime | ||
| runtime_errors | ||
| shared | ||
| spirv | ||
| workarounds | ||
| README.txt | ||
| update_fuzzer.py | ||
This directory contains source files for testing skslc compilation. The compiled output files are in the /tests/sksl/ directory.