ffc9dec755
We now have two functions `writeOpLoad` and `writeOpStore` which are in charge of writing SpvOpLoad and SpvOpStore instructions. `writeOpStore` also keeps track of pointer stores in a "store cache." Subsequent loads from that same pointer will be found in the cache and will return the value stored in that pointer instead. Such a cache definitely cannot work in the face of control flow, so we make the following concessions: - `pruneReachableOps` is now `pruneConditionalOps`. Any pointers that are altered inside a potentially-unreachable block are cleared from the cache entirely. - The entire store cache is cleared at all OpLabels within a loop. The cache also cannot work in the presence of swizzled stores, so we make another significant concession: - The entire store cache is cleared whenever we store into a non-memory pointer (e.g., assigning into a swizzled LValue, such as `foo.xz`). Despite these significant limitations, this manages to dramatically shrink many real-world examples. Change-Id: I0981a0cf7b45b064e153e9ada271494c8e00cad5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/530054 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
87 lines
3.0 KiB
JavaScript
87 lines
3.0 KiB
JavaScript
### Compilation failed:
|
|
|
|
error: SPIR-V validation error: Operand 3 of TypeImage requires one of these capabilities: Sampled1D Image1D
|
|
%11 = OpTypeImage %float 1D 0 0 0 1 Unknown
|
|
|
|
OpCapability Shader
|
|
%1 = OpExtInstImport "GLSL.std.450"
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint Fragment %main "main" %sk_FragColor %sk_Clockwise
|
|
OpExecutionMode %main OriginUpperLeft
|
|
OpName %sk_FragColor "sk_FragColor"
|
|
OpName %sk_Clockwise "sk_Clockwise"
|
|
OpName %one "one"
|
|
OpName %two "two"
|
|
OpName %main "main"
|
|
OpName %a "a"
|
|
OpName %b "b"
|
|
OpName %c "c"
|
|
OpName %d "d"
|
|
OpDecorate %sk_FragColor RelaxedPrecision
|
|
OpDecorate %sk_FragColor Location 0
|
|
OpDecorate %sk_FragColor Index 0
|
|
OpDecorate %sk_Clockwise BuiltIn FrontFacing
|
|
OpDecorate %one RelaxedPrecision
|
|
OpDecorate %one Binding 0
|
|
OpDecorate %one DescriptorSet 0
|
|
OpDecorate %two RelaxedPrecision
|
|
OpDecorate %two Binding 1
|
|
OpDecorate %two DescriptorSet 0
|
|
OpDecorate %24 RelaxedPrecision
|
|
OpDecorate %29 RelaxedPrecision
|
|
OpDecorate %34 RelaxedPrecision
|
|
OpDecorate %37 RelaxedPrecision
|
|
OpDecorate %44 RelaxedPrecision
|
|
%float = OpTypeFloat 32
|
|
%v4float = OpTypeVector %float 4
|
|
%_ptr_Output_v4float = OpTypePointer Output %v4float
|
|
%sk_FragColor = OpVariable %_ptr_Output_v4float Output
|
|
%bool = OpTypeBool
|
|
%_ptr_Input_bool = OpTypePointer Input %bool
|
|
%sk_Clockwise = OpVariable %_ptr_Input_bool Input
|
|
%11 = OpTypeImage %float 1D 0 0 0 1 Unknown
|
|
%12 = OpTypeSampledImage %11
|
|
%_ptr_UniformConstant_12 = OpTypePointer UniformConstant %12
|
|
%one = OpVariable %_ptr_UniformConstant_12 UniformConstant
|
|
%15 = OpTypeImage %float 2D 0 0 0 1 Unknown
|
|
%16 = OpTypeSampledImage %15
|
|
%_ptr_UniformConstant_16 = OpTypePointer UniformConstant %16
|
|
%two = OpVariable %_ptr_UniformConstant_16 UniformConstant
|
|
%void = OpTypeVoid
|
|
%19 = OpTypeFunction %void
|
|
%_ptr_Function_v4float = OpTypePointer Function %v4float
|
|
%float_0 = OpConstant %float 0
|
|
%float_n0_474999994 = OpConstant %float -0.474999994
|
|
%v2float = OpTypeVector %float 2
|
|
%31 = OpConstantComposite %v2float %float_0 %float_0
|
|
%v3float = OpTypeVector %float 3
|
|
%39 = OpConstantComposite %v3float %float_0 %float_0 %float_0
|
|
%main = OpFunction %void None %19
|
|
%20 = OpLabel
|
|
%a = OpVariable %_ptr_Function_v4float Function
|
|
%b = OpVariable %_ptr_Function_v4float Function
|
|
%c = OpVariable %_ptr_Function_v4float Function
|
|
%d = OpVariable %_ptr_Function_v4float Function
|
|
%24 = OpLoad %12 %one
|
|
%23 = OpImageSampleImplicitLod %v4float %24 %float_0 Bias %float_n0_474999994
|
|
OpStore %a %23
|
|
%29 = OpLoad %16 %two
|
|
%28 = OpImageSampleImplicitLod %v4float %29 %31 Bias %float_n0_474999994
|
|
OpStore %b %28
|
|
%34 = OpLoad %12 %one
|
|
%33 = OpImageSampleProjImplicitLod %v4float %34 %31 Bias %float_n0_474999994
|
|
OpStore %c %33
|
|
%37 = OpLoad %16 %two
|
|
%36 = OpImageSampleProjImplicitLod %v4float %37 %39 Bias %float_n0_474999994
|
|
OpStore %d %36
|
|
%40 = OpCompositeExtract %float %23 0
|
|
%41 = OpCompositeExtract %float %28 0
|
|
%42 = OpCompositeExtract %float %33 0
|
|
%43 = OpCompositeExtract %float %36 0
|
|
%44 = OpCompositeConstruct %v4float %40 %41 %42 %43
|
|
OpStore %sk_FragColor %44
|
|
OpReturn
|
|
OpFunctionEnd
|
|
|
|
1 error
|