Go to file
Yuqian Li 8eedbfc9ac Revert "Revert "Improve quad edges' smoothness in non-AA cases""
This reverts commit 1e74cad9b4.

Reason for revert: the guard flag has now been confirmed to be landed on chromium/src. We should now be able to pass the layout tests.

Original change's description:
> Revert "Improve quad edges' smoothness in non-AA cases"
> 
> This reverts commit d4ed326d6f.
> 
> Reason for revert: reverting temporarily to get us rolling into Chrome again.
> 
> Must be this CL right?
> https://storage.googleapis.com/chromium-layout-test-archives/linux_trusty_blink_rel/3364/layout-test-results/results.html
> 
> Original change's description:
> > Improve quad edges' smoothness in non-AA cases
> > 
> > Previously, non-AA quad edges only have an accuracy about 1/2 pixel
> > (while the AA quad edges have an accuracy about 1/8 pixel).  Now, we
> > increase non-AA quad edges' accuracy to 1/8 pixel as well.
> > 
> > The difference is very significant for rotating non-AA filled circles.
> > For example, run `./out/Debug/SampleApp --slide GM:fillcircle` with AA
> > turned off (by pressing b).
> > 
> > The benchmark added reveals that increasing quad accuracy from 1/2 to
> > 1/8 doesn't affect the performance significantly. The following is the
> > 1/2-accuracy performance versus 1/8-accuracy performance:
> > 
> > curr/maxrss     loops   min     median  mean    max     stddev  samples
> > config  bench
> > 7/17  MB        19      2.43µs  2.57µs  2.81µs  10.5µs  22%     16119
> > 8888    path_fill_big_nonaacircle
> > 7/17  MB        17      1.38µs  1.42µs  1.52µs  13µs    20%     21409
> > 8888    path_fill_small_nonaacircle
> > 
> > curr/maxrss     loops   min     median  mean    max     stddev  samples
> > config  bench
> > 7/17  MB        71      2.52µs  2.59µs  2.79µs  7.67µs  19%     7557
> > 8888    path_fill_big_nonaacircle
> > 7/17  MB        64      1.45µs  1.49µs  1.51µs  2.39µs  5%      12704
> > 8888    path_fill_small_nonaacircle
> > 
> > 
> > BUG=skia:
> > 
> > Change-Id: I3482098aeafcc6f2ec9aa3382977c0dc1b650964
> > Reviewed-on: https://skia-review.googlesource.com/6699
> > Reviewed-by: Mike Reed <reed@google.com>
> > Commit-Queue: Yuqian Li <liyuqian@google.com>
> > 
> 
> TBR=caryclark@google.com,liyuqian@google.com,reed@google.com,djsollen@google.com,bungeman@google.com,reviews@skia.org,fmalita@chromium.org
> BUG=skia:
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> 
> Change-Id: I5bc4596ab506f6f61ac2da91a07cf51d61114f31
> Reviewed-on: https://skia-review.googlesource.com/6829
> Commit-Queue: Mike Klein <mtklein@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
> 

TBR=djsollen@google.com,mtklein@google.com,bungeman@google.com,reviews@skia.org,caryclark@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com
BUG=skia:
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I0ec2ea8dc0c6ad0ebdcb48878fb301c32443a09e
Reviewed-on: https://skia-review.googlesource.com/6858
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
2017-01-11 13:56:05 +00:00
animations
bench Revert "Revert "Improve quad edges' smoothness in non-AA cases"" 2017-01-11 13:56:05 +00:00
bin tools and docs: clean up gyp-specific things 2016-12-09 21:15:27 +00:00
debugger Get Debugger app compiling again 2017-01-06 16:18:27 +00:00
dm Remove DMSrcSinkAndroid. 2017-01-05 15:20:21 +00:00
example bench, samples, etc: s/SkAutoTUnref/sk_sp/ 2016-11-07 15:17:32 +00:00
experimental Plumb dst color space in many places, rather than "mode" 2016-12-09 20:31:23 +00:00
fuzz Add in Path fuzzer 2017-01-06 19:58:27 +00:00
gm Respect SkColorSpace in SkPNGImageEncoder 2017-01-10 18:26:26 +00:00
gn move SkDraw.h to core 2017-01-11 04:22:52 +00:00
gyp Remove DMSrcSinkAndroid. 2017-01-05 15:20:21 +00:00
include move SkDraw.h to core 2017-01-11 04:22:52 +00:00
infra Roll recipe DEPS 2017-01-11 13:02:22 +00:00
platform_tools Add support for 64-bit devices when using gdb on Android 2017-01-06 19:57:05 +00:00
resources GIF: Better check for frame dependency 2017-01-03 19:07:41 +00:00
samplecode support external raster handles 2017-01-10 17:31:58 +00:00
site documentation: corrections to PDF docs 2017-01-09 21:03:29 +00:00
src Revert "Revert "Improve quad edges' smoothness in non-AA cases"" 2017-01-11 13:56:05 +00:00
tests SkSplicer: test and fix loop logic 2017-01-10 19:20:22 +00:00
third_party remove xbyak experiment 2017-01-10 16:25:10 +00:00
tools Add support for tagging GrUniqueKeys with a debug string 2017-01-06 17:54:03 +00:00
.clang-format Mark flatennable macros as block beginning/ending in .clang-format 2017-01-09 15:31:36 +00:00
.gitignore Remove skia.conf from .gitignore 2016-10-26 14:50:09 +00:00
.gn Basic standalone GN configs. 2016-07-21 12:25:45 -07:00
AUTHORS Fix typo in GrGLCaps 2016-11-18 23:20:51 +00:00
BUILD.gn disable splicer on MSAN bot 2017-01-10 19:38:21 +00:00
codereview.settings Make uploading to Gerrit the default for Skia 2016-11-09 19:07:56 +00:00
CONTRIBUTING
CQ_COMMITTERS Moved committer list to chrome-infra-auth and deleted it from the repo 2015-09-02 13:37:54 -07:00
DEPS remove xbyak experiment 2017-01-10 16:25:10 +00:00
Doxyfile Make the housekeeper upload doxygen to a newer bucket 2016-10-04 13:23:57 -07:00
gyp_skia Make Win runtime DLLs writeable before overwriting 2016-03-18 08:33:38 -07:00
gyp_skia.py
LICENSE BUG=skia:5602 2016-09-02 11:19:34 -07:00
OWNERS
PRESUBMIT.py Do not use post upload hooks for 'GOLD_TRYBOT_URL' 2016-11-23 18:34:23 +00:00
public.bzl Remove last of SK_SUPPORT_LEGACY_IMAGE_ENCODER_CLASS 2017-01-10 19:36:17 +00:00
README
README.chromium Update README.chromium. 2015-06-11 13:19:24 -07:00
skia.gyp
whitespace.txt Test CL 2016-12-22 01:51:30 +00:00

Skia is a complete 2D graphic library for drawing Text, Geometries, and Images.

See full details, and build instructions, at https://skia.org.