skia2/tests/Test.cpp
mtklein 91359bed48 Revert of Clean up Test's resourcePath code. (https://codereview.chromium.org/319473003/)
Reason for revert:
Some benchmarks are written in a way that makes this change unsafe (e.g. const char* resPath = GetResourcePath().c_str(); in SkipZeroesBench) and Valgrind and ASAN caught that.  We can try again after a more careful cleanup of GetResourcePath().

Original issue's description:
> Clean up resourcePath code.
>
> 1) Make the implementation of SetResourcePath/GetResourcePath of GM and SkBenchmark match with the one in Test.
> 2) Make gResourcePath a static pointer to const char and move it inside the classes.
>
> BUG=None
> TEST=make tests && out/Debug/tests
>      make gm && out/Debug/gm
>      make bench && out/Debug/bench
> R=mtklein@google.com
>
> Committed: https://skia.googlesource.com/skia/+/52e4f413ffe2d281f9e90ff2147db08083ffcba7

R=tfarina@chromium.org
TBR=tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/320733002
2014-06-08 07:02:47 -07:00

130 lines
3.2 KiB
C++

/*
* Copyright 2011 Google Inc.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
#include "Test.h"
#include "SkCommandLineFlags.h"
#include "SkError.h"
#include "SkString.h"
#include "SkTArray.h"
#include "SkTime.h"
#if SK_SUPPORT_GPU
#include "GrContext.h"
#include "gl/SkNativeGLContext.h"
#else
class GrContext;
#endif
DEFINE_string2(tmpDir, t, NULL, "tmp directory for tests to use.");
using namespace skiatest;
Reporter::Reporter() : fTestCount(0) {
}
void Reporter::startTest(Test* test) {
this->onStart(test);
}
void Reporter::reportFailed(const SkString& desc) {
this->onReportFailed(desc);
}
void Reporter::endTest(Test* test) {
this->onEnd(test);
}
///////////////////////////////////////////////////////////////////////////////
Test::Test() : fReporter(NULL), fPassed(true) {}
Test::~Test() {
SkSafeUnref(fReporter);
}
void Test::setReporter(Reporter* r) {
SkRefCnt_SafeAssign(fReporter, r);
}
const char* Test::getName() {
if (fName.size() == 0) {
this->onGetName(&fName);
}
return fName.c_str();
}
class LocalReporter : public Reporter {
public:
explicit LocalReporter(Reporter* reporterToMimic) : fReporter(reporterToMimic) {}
int numFailures() const { return fFailures.count(); }
const SkString& failure(int i) const { return fFailures[i]; }
protected:
virtual void onReportFailed(const SkString& desc) SK_OVERRIDE {
fFailures.push_back(desc);
}
// Proxy down to fReporter. We assume these calls are threadsafe.
virtual bool allowExtendedTest() const SK_OVERRIDE {
return fReporter->allowExtendedTest();
}
virtual bool allowThreaded() const SK_OVERRIDE {
return fReporter->allowThreaded();
}
virtual void bumpTestCount() SK_OVERRIDE {
fReporter->bumpTestCount();
}
virtual bool verbose() const SK_OVERRIDE {
return fReporter->verbose();
}
private:
Reporter* fReporter; // Unowned.
SkTArray<SkString> fFailures;
};
void Test::run() {
// Clear the Skia error callback before running any test, to ensure that tests
// don't have unintended side effects when running more than one.
SkSetErrorCallback( NULL, NULL );
// Tell (likely shared) fReporter that this test has started.
fReporter->startTest(this);
const SkMSec start = SkTime::GetMSecs();
// Run the test into a LocalReporter so we know if it's passed or failed without interference
// from other tests that might share fReporter.
LocalReporter local(fReporter);
this->onRun(&local);
fPassed = local.numFailures() == 0;
fElapsed = SkTime::GetMSecs() - start;
// Now tell fReporter about any failures and wrap up.
for (int i = 0; i < local.numFailures(); i++) {
fReporter->reportFailed(local.failure(i));
}
fReporter->endTest(this);
}
SkString Test::GetTmpDir() {
const char* tmpDir = FLAGS_tmpDir.isEmpty() ? NULL : FLAGS_tmpDir[0];
return SkString(tmpDir);
}
static const char* gResourcePath = NULL;
void Test::SetResourcePath(const char* resourcePath) { gResourcePath = resourcePath; }
SkString Test::GetResourcePath() {
return SkString(gResourcePath);
}