4065d45d2d
This is a reland of2f9a5ea639
Original change's description: > Reland "Have a GrBackendFormat be stored on gpu proxies." > > This reverts commit919c9e77c3
. > > Reason for revert: Flutter change has landed and fixed memory issue. > > Original change's description: > > Revert "Have a GrBackendFormat be stored on gpu proxies." > > > > This reverts commit51b1c12bbc
. > > > > Reason for revert: reverting till flutter gets to 1.1 to fix build issues. > > > > Original change's description: > > > Have a GrBackendFormat be stored on gpu proxies. > > > > > > Bug: skia: > > > Change-Id: Iaf1fb24ab29a61d44e5fa59a5e0867ed02dcda90 > > > Reviewed-on: https://skia-review.googlesource.com/c/168021 > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > > > TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com > > > > Change-Id: I574fdc084ef5994596c51fb0d60423b5dc01b885 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: chromium:903701 chromium:903756 > > Reviewed-on: https://skia-review.googlesource.com/c/169835 > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > Reviewed-by: Greg Daniel <egdaniel@google.com> > > TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com > > Change-Id: Ifd9b6b8e194af9fb9258fa626644e76e6ecf090d > Bug: chromium:903701 chromium:903756 > Reviewed-on: https://skia-review.googlesource.com/c/170104 > Commit-Queue: Greg Daniel <egdaniel@google.com> > Reviewed-by: Greg Daniel <egdaniel@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> Bug: chromium:903701 chromium:903756 Change-Id: Id1360067d8e928b0a4e1848dae8bc1e7f1994403 Reviewed-on: https://skia-review.googlesource.com/c/171660 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
142 lines
4.9 KiB
C++
142 lines
4.9 KiB
C++
/*
|
|
* Copyright 2017 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "SkTypes.h"
|
|
|
|
#include "GrClip.h"
|
|
#include "GrColor.h"
|
|
#include "GrContext.h"
|
|
#include "GrContextFactory.h"
|
|
#include "GrContextOptions.h"
|
|
#include "GrContextPriv.h"
|
|
#include "GrFragmentProcessor.h"
|
|
#include "GrPaint.h"
|
|
#include "GrRenderTargetContext.h"
|
|
#include "GrStyle.h"
|
|
#include "GrTypesPriv.h"
|
|
#include "SkBitmap.h"
|
|
#include "SkColor.h"
|
|
#include "SkColorSpace.h"
|
|
#include "SkImageInfo.h"
|
|
#include "SkMatrix.h"
|
|
#include "SkPath.h"
|
|
#include "SkRect.h"
|
|
#include "SkRefCnt.h"
|
|
#include "SkStrokeRec.h"
|
|
#include "Test.h"
|
|
#include "effects/GrConstColorProcessor.h"
|
|
|
|
#include <utility>
|
|
|
|
static void only_allow_default(GrContextOptions* options) {
|
|
options->fGpuPathRenderers = GpuPathRenderers::kNone;
|
|
}
|
|
|
|
static SkBitmap read_back(GrRenderTargetContext* rtc, int width, int height) {
|
|
|
|
SkImageInfo dstII = SkImageInfo::MakeN32Premul(width, height);
|
|
|
|
SkBitmap bm;
|
|
bm.allocPixels(dstII);
|
|
|
|
rtc->readPixels(dstII, bm.getAddr(0, 0), bm.rowBytes(), 0, 0, 0);
|
|
|
|
return bm;
|
|
}
|
|
|
|
static SkPath make_path(const SkRect& outer, int inset, SkPath::FillType fill) {
|
|
SkPath p;
|
|
|
|
p.addRect(outer, SkPath::kCW_Direction);
|
|
p.addRect(outer.makeInset(inset, inset), SkPath::kCCW_Direction);
|
|
p.setFillType(fill);
|
|
return p;
|
|
}
|
|
|
|
|
|
static const int kBigSize = 64; // This should be a power of 2
|
|
static const int kPad = 3;
|
|
|
|
// From crbug.com/769898:
|
|
// create an approx fit render target context that will have extra space (i.e., npot)
|
|
// draw an inverse wound concave path into it - forcing use of the stencil-using path renderer
|
|
// throw the RTC away so the backing GrSurface/GrStencilBuffer can be reused
|
|
// create a new render target context that will reuse the prior GrSurface
|
|
// draw a normally wound concave path that touches outside of the approx fit RTC's content rect
|
|
//
|
|
// When the bug manifests the GrDefaultPathRenderer/GrMSAAPathRenderer is/was leaving the stencil
|
|
// buffer outside of the first content rect in a bad state and the second draw would be incorrect.
|
|
|
|
static void run_test(GrContext* ctx, skiatest::Reporter* reporter) {
|
|
SkPath invPath = make_path(SkRect::MakeXYWH(0, 0, kBigSize, kBigSize),
|
|
kBigSize/2-1, SkPath::kInverseWinding_FillType);
|
|
SkPath path = make_path(SkRect::MakeXYWH(0, 0, kBigSize, kBigSize),
|
|
kPad, SkPath::kWinding_FillType);
|
|
|
|
GrStyle style(SkStrokeRec::kFill_InitStyle);
|
|
|
|
GrBackendFormat format =
|
|
ctx->contextPriv().caps()->getBackendFormatFromColorType(kRGBA_8888_SkColorType);
|
|
{
|
|
auto rtc = ctx->contextPriv().makeDeferredRenderTargetContext(
|
|
format,
|
|
SkBackingFit::kApprox,
|
|
kBigSize/2+1, kBigSize/2+1,
|
|
kRGBA_8888_GrPixelConfig, nullptr);
|
|
|
|
rtc->clear(nullptr, { 0, 0, 0, 1 }, GrRenderTargetContext::CanClearFullscreen::kYes);
|
|
|
|
GrPaint paint;
|
|
|
|
const SkPMColor4f color = { 1.0f, 0.0f, 0.0f, 1.0f };
|
|
auto fp = GrConstColorProcessor::Make(color, GrConstColorProcessor::InputMode::kIgnore);
|
|
paint.addColorFragmentProcessor(std::move(fp));
|
|
|
|
rtc->drawPath(GrNoClip(), std::move(paint), GrAA::kNo,
|
|
SkMatrix::I(), invPath, style);
|
|
|
|
rtc->prepareForExternalIO(0, nullptr);
|
|
}
|
|
|
|
{
|
|
auto rtc = ctx->contextPriv().makeDeferredRenderTargetContext(
|
|
format, SkBackingFit::kExact, kBigSize,
|
|
kBigSize, kRGBA_8888_GrPixelConfig,
|
|
nullptr);
|
|
|
|
rtc->clear(nullptr, { 0, 0, 0, 1 }, GrRenderTargetContext::CanClearFullscreen::kYes);
|
|
|
|
GrPaint paint;
|
|
|
|
const SkPMColor4f color = { 0.0f, 1.0f, 0.0f, 1.0f };
|
|
auto fp = GrConstColorProcessor::Make(color, GrConstColorProcessor::InputMode::kIgnore);
|
|
paint.addColorFragmentProcessor(std::move(fp));
|
|
|
|
rtc->drawPath(GrNoClip(), std::move(paint), GrAA::kNo,
|
|
SkMatrix::I(), path, style);
|
|
|
|
SkBitmap bm = read_back(rtc.get(), kBigSize, kBigSize);
|
|
|
|
bool correct = true;
|
|
for (int y = kBigSize/2+1; y < kBigSize-kPad-1 && correct; ++y) {
|
|
for (int x = kPad+1; x < kBigSize-kPad-1 && correct; ++x) {
|
|
correct = bm.getColor(x, y) == SK_ColorBLACK;
|
|
REPORTER_ASSERT(reporter, correct);
|
|
}
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
DEF_GPUTEST_FOR_CONTEXTS(GrDefaultPathRendererTest,
|
|
sk_gpu_test::GrContextFactory::IsRenderingContext,
|
|
reporter, ctxInfo, only_allow_default) {
|
|
GrContext* ctx = ctxInfo.grContext();
|
|
|
|
run_test(ctx, reporter);
|
|
}
|