973009b04b
When coercing a type, we would previously call checkValid() so we could detect function-references and type-references, so we could get a nicer error message. It turns out that we can just do the "is this a type-reference/ function-reference?" check directly inside coerce() and get the same improved error messages. Since we should be coercing all our values to the right type, and type/function-references aren't coercible to anything, this should catch them all. I don't expect any of these to survive all the way to the end of IR generation. (In case one of these types does slip through, I've left the error case in checkValid, but I've also put in an assertion. If the fuzzer can make that assertion fire, we are probably missing a call to coerce() somewhere.) This cleanup is meant to help migrate coerce() out of IRGenerator. Change-Id: I031809adf439b1766048768b782c57e7f2494006 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/371479 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> |
||
|---|---|---|
| .. | ||
| blend | ||
| errors | ||
| folding | ||
| fp | ||
| glsl | ||
| inliner | ||
| intrinsics | ||
| metal | ||
| runtime | ||
| runtime_errors | ||
| shared | ||
| spirv | ||
| workarounds | ||
| README.txt | ||
This directory contains skslc-compiled output from matching source files in the /resources/sksl/ directory.