9834696ed8
__mulodi4() is roughly, int64_t __mulodi4(int64_t a, int64_t b, int* overflow) { int64_t result = a*b; *overflow = did_overflow(result); return result; } It's used by Clang's __builtin_smulll_overflow(), which is basically the same except it swaps the positions of the return value and the out parameter. DNG SDK in turn uses __builtin_smulll_overflow(). When building ARMv7 binaries with Clang, __mulodi4() turns up as a missing symbol. That's because it's defined in a separate compiler-rt library. I have not been able to link that. Instead, I've provided our own trivial __builtin_smulll_overflow(). Before this patch both nanobench and DM failed dynamically linking __mulodi4(). After this patch nanobench runs for a while, eventually segfaulting. DM immediately segfaults. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2011073002 Review-Url: https://codereview.chromium.org/2011073002 |
||
---|---|---|
animations | ||
bench | ||
bin | ||
build_overrides | ||
cmake | ||
debugger | ||
dm | ||
example | ||
experimental | ||
fuzz | ||
gm | ||
gyp | ||
include | ||
infra | ||
platform_tools | ||
resources | ||
samplecode | ||
site | ||
src | ||
tests | ||
third_party | ||
tools | ||
.gitignore | ||
.gn | ||
AUTHORS | ||
BUILD.gn | ||
codereview.settings | ||
CONTRIBUTING | ||
CQ_COMMITTERS | ||
DEPS | ||
Doxyfile | ||
gn.py | ||
gyp_skia | ||
gyp_skia.py | ||
LICENSE | ||
make.bat | ||
make.py | ||
Makefile | ||
OWNERS | ||
PRESUBMIT.py | ||
public.bzl | ||
README | ||
README.chromium | ||
SK_IMAGE_VERSION | ||
skia.gyp | ||
SKP_VERSION | ||
whitespace.txt |
Skia is a complete 2D graphic library for drawing Text, Geometries, and Images. See full details, and build instructions, at https://skia.org.