AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
9ce80f71de
skia2/tests/BackendAllocationTest.cpp
Greg Daniel 00d6cf4368 Reland "Have GrVkRenderTarget only use GrVkAttachments and not derive from GrVkImage." 
This reverts commit 9ef3f2e3da.

Reason for revert: relanding with fix

Original change's description:
> Revert "Have GrVkRenderTarget only use GrVkAttachments and not derive from GrVkImage."
>
> This reverts commit 3dc6c190da.
>
> Reason for revert: hitting assert about RT having input attachment on mali bots
>
> Original change's description:
> > Have GrVkRenderTarget only use GrVkAttachments and not derive from GrVkImage.
> >
> > This change moves the color and resolve attachments used in a
> > GrVkRenderTarget to be a GrVkAttachment. These along with the msaa
> > attachment now mean that GrVkRenderTarget no longer needs to derive from
> > a GrVkImage.
> >
> > There are a couple ugly things in this CL since GrVkTexture still is a
> > GrVkImage since we can't share attachments between GrVkRT and GrVkTex.
> > But when that gets updated in the follow on CL things will look much nicer.
> >
> > Bug: skia:10727
> > Change-Id: I2f12674d7517c6d6dea389e2d1fb7296028bcc85
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/379576
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
>
> TBR=egdaniel@google.com,jvanverth@google.com,bsalomon@google.com
>
> Change-Id: Ic46f3947ed9f7b2ca26e8418d643e7f89b6108d2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:10727
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/380459
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

# Not skipping CQ checks because this is a reland.

Bug: skia:10727
Change-Id: I7a995ee9ad35bdac34cfcfd6b0d963c3e0bb90b8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/380460
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-03-06 18:57:11 +00:00

1069 lines
49 KiB
C++
Raw Blame History

/*
* Copyright 2019 Google Inc.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
#include "include/core/SkCanvas.h"
#include "include/core/SkSurface.h"
#include "include/core/SkSurfaceCharacterization.h"
#include "include/gpu/GrDirectContext.h"
#include "src/core/SkAutoPixmapStorage.h"
#include "src/gpu/GrDirectContextPriv.h"
#include "src/gpu/GrProxyProvider.h"
#include "src/gpu/GrSurfaceFillContext.h"
#include "src/gpu/effects/GrBlendFragmentProcessor.h"
#include "src/gpu/effects/generated/GrConstColorProcessor.h"
#include "src/image/SkImage_Base.h"
#include "tests/Test.h"
#include "tests/TestUtils.h"
#include "tools/ToolUtils.h"
#include "tools/gpu/ManagedBackendTexture.h"
#include "tools/gpu/ProxyUtils.h"
#ifdef SK_GL
#include "src/gpu/gl/GrGLCaps.h"
#include "src/gpu/gl/GrGLDefines.h"
#include "src/gpu/gl/GrGLGpu.h"
#include "src/gpu/gl/GrGLUtil.h"
#endif
#ifdef SK_METAL
#include "include/gpu/mtl/GrMtlTypes.h"
#include "src/gpu/mtl/GrMtlCppUtil.h"
#endif
using sk_gpu_test::ManagedBackendTexture;
// Test wrapping of GrBackendObjects in SkSurfaces and SkImages (non-static since used in Mtl test)
void test_wrapping(GrDirectContext* dContext,
skiatest::Reporter* reporter,
std::function<sk_sp<ManagedBackendTexture>(GrDirectContext*,
GrMipmapped,
GrRenderable)> create,
GrColorType grColorType,
GrMipmapped mipMapped,
GrRenderable renderable) {
GrResourceCache* cache = dContext->priv().getResourceCache();
const int initialCount = cache->getResourceCount();
sk_sp<ManagedBackendTexture> mbet = create(dContext, mipMapped, renderable);
if (!mbet) {
ERRORF(reporter, "Couldn't create backendTexture for grColorType %d renderable %s\n",
grColorType,
GrRenderable::kYes == renderable ? "yes" : "no");
return;
}
// Skia proper should know nothing about the new backend object
REPORTER_ASSERT(reporter, initialCount == cache->getResourceCount());
SkColorType skColorType = GrColorTypeToSkColorType(grColorType);
// Wrapping a backendTexture in an SkImage/SkSurface requires an SkColorType
if (skColorType == kUnknown_SkColorType) {
return;
}
if (GrRenderable::kYes == renderable && dContext->colorTypeSupportedAsSurface(skColorType)) {
sk_sp<SkSurface> surf = SkSurface::MakeFromBackendTexture(dContext,
mbet->texture(),
kTopLeft_GrSurfaceOrigin,
0,
skColorType,
nullptr, nullptr);
if (!surf) {
ERRORF(reporter, "Couldn't make SkSurface from backendTexture for %s\n",
ToolUtils::colortype_name(skColorType));
} else {
// As we transition to using attachments instead of GrTextures and GrRenderTargets
// individual proxy instansiations may add multiple things to the cache. There would be
// an entry for the GrTexture/GrRenderTarget and entries for one or more attachments.
int cacheEntriesPerProxy = 1;
// We currently only have attachments on the vulkan backend
if (dContext->backend() == GrBackend::kVulkan) {
// If we ever make a rt with multisamples this would have an additional
// attachment as well.
cacheEntriesPerProxy++;
}
REPORTER_ASSERT(reporter,
initialCount + cacheEntriesPerProxy == cache->getResourceCount());
}
}
{
sk_sp<SkImage> img = SkImage::MakeFromTexture(dContext,
mbet->texture(),
kTopLeft_GrSurfaceOrigin,
skColorType,
kUnpremul_SkAlphaType,
nullptr);
if (!img) {
ERRORF(reporter, "Couldn't make SkImage from backendTexture for %s\n",
ToolUtils::colortype_name(skColorType));
} else {
GrTextureProxy* proxy = sk_gpu_test::GetTextureImageProxy(img.get(), dContext);
REPORTER_ASSERT(reporter, proxy);
REPORTER_ASSERT(reporter, mipMapped == proxy->proxyMipmapped());
REPORTER_ASSERT(reporter, proxy->isInstantiated());
REPORTER_ASSERT(reporter, mipMapped == proxy->mipmapped());
REPORTER_ASSERT(reporter, initialCount+1 == cache->getResourceCount());
}
}
REPORTER_ASSERT(reporter, initialCount == cache->getResourceCount());
}
static bool isBGRA8(const GrBackendFormat& format) {
switch (format.backend()) {
case GrBackendApi::kOpenGL:
#ifdef SK_GL
return format.asGLFormat() == GrGLFormat::kBGRA8;
#else
return false;
#endif
case GrBackendApi::kVulkan: {
#ifdef SK_VULKAN
VkFormat vkFormat;
format.asVkFormat(&vkFormat);
return vkFormat == VK_FORMAT_B8G8R8A8_UNORM;
#else
return false;
#endif
}
case GrBackendApi::kMetal:
#ifdef SK_METAL
return GrMtlFormatIsBGRA8(format.asMtlFormat());
#else
return false;
#endif
case GrBackendApi::kDirect3D:
#ifdef SK_DIRECT3D
return false; // TODO
#else
return false;
#endif
case GrBackendApi::kDawn:
#ifdef SK_DAWN
wgpu::TextureFormat dawnFormat;
format.asDawnFormat(&dawnFormat);
return dawnFormat == wgpu::TextureFormat::BGRA8Unorm;
#else
return false;
#endif
case GrBackendApi::kMock: {
SkImage::CompressionType compression = format.asMockCompressionType();
if (compression != SkImage::CompressionType::kNone) {
return false; // No compressed formats are BGRA
}
return format.asMockColorType() == GrColorType::kBGRA_8888;
}
}
SkUNREACHABLE;
}
static bool isRGB(const GrBackendFormat& format) {
switch (format.backend()) {
case GrBackendApi::kOpenGL:
#ifdef SK_GL
return format.asGLFormat() == GrGLFormat::kRGB8;
#else
return false;
#endif
case GrBackendApi::kVulkan: {
#ifdef SK_VULKAN
VkFormat vkFormat;
format.asVkFormat(&vkFormat);
return vkFormat == VK_FORMAT_R8G8B8_UNORM;
#else
return false;
#endif
}
case GrBackendApi::kMetal:
return false; // Metal doesn't even pretend to support this
case GrBackendApi::kDirect3D:
return false; // Not supported in Direct3D 12
case GrBackendApi::kDawn:
return false;
case GrBackendApi::kMock:
return false; // No GrColorType::kRGB_888
}
SkUNREACHABLE;
}
static void check_solid_pixmap(skiatest::Reporter* reporter,
const SkColor4f& expected,
const SkPixmap& actual,
GrColorType ct,
const char* label1,
const char* label2) {
// we need 0.001f across the board just for noise
// we need 0.01f across the board for 1010102
const float tols[4] = { 0.01f, 0.01f, 0.01f, 0.01f };
auto error = std::function<ComparePixmapsErrorReporter>(
[reporter, ct, label1, label2](int x, int y, const float diffs[4]) {
SkASSERT(x >= 0 && y >= 0);
ERRORF(reporter, "%s %s %s - mismatch at %d, %d (%f, %f, %f %f)", GrColorTypeToStr(ct),
label1, label2, x, y, diffs[0], diffs[1], diffs[2], diffs[3]);
});
CheckSolidPixels(expected, actual, tols, error);
}
// Determine what color we expect if we store 'orig' in 'ct' converted back to SkColor4f.
static SkColor4f get_expected_color(SkColor4f orig, GrColorType ct) {
GrImageInfo ii(ct, kUnpremul_SkAlphaType, nullptr, {1, 1});
std::unique_ptr<char[]> data(new char[ii.minRowBytes()]);
GrClearImage(ii, data.get(), ii.minRowBytes(), orig);
// Read back to SkColor4f.
SkColor4f result;
GrImageInfo resultII(GrColorType::kRGBA_F32, kUnpremul_SkAlphaType, nullptr, {1, 1});
GrConvertPixels(resultII, &result.fR, sizeof(result), ii, data.get(), ii.minRowBytes());
return result;
}
static void check_mipmaps(GrDirectContext*,
const GrBackendTexture&,
GrColorType,
const SkColor4f expectedColors[6],
skiatest::Reporter*,
const char* label);
static void check_base_readbacks(GrDirectContext* dContext,
const GrBackendTexture& backendTex,
GrColorType colorType,
GrRenderable renderableTexture,
const SkColor4f& color,
skiatest::Reporter* reporter,
const char* label) {
if (isRGB(backendTex.getBackendFormat())) {
// readPixels is busted for the RGB backend format (skbug.com/8862)
// TODO: add a GrColorType::kRGB_888 to fix the situation
return;
}
SkColor4f expectedColor = get_expected_color(color, colorType);
SkAutoPixmapStorage actual;
{
SkImageInfo readBackII = SkImageInfo::Make(32, 32,
kRGBA_8888_SkColorType,
kUnpremul_SkAlphaType);
SkAssertResult(actual.tryAlloc(readBackII));
}
for (GrRenderable renderableCtx : {GrRenderable::kNo, GrRenderable::kYes}) {
if (renderableCtx == GrRenderable::kYes && renderableTexture == GrRenderable::kNo) {
continue;
}
sk_sp<GrSurfaceProxy> proxy;
if (renderableCtx == GrRenderable::kYes) {
proxy = dContext->priv().proxyProvider()->wrapRenderableBackendTexture(
backendTex, 1, kBorrow_GrWrapOwnership, GrWrapCacheable::kNo, nullptr);
} else {
proxy = dContext->priv().proxyProvider()->wrapBackendTexture(
backendTex, kBorrow_GrWrapOwnership, GrWrapCacheable::kNo, kRW_GrIOType);
}
if (!proxy) {
ERRORF(reporter, "Could not make proxy from backend texture");
return;
}
auto swizzle = dContext->priv().caps()->getReadSwizzle(backendTex.getBackendFormat(),
colorType);
GrSurfaceProxyView readView(proxy, kTopLeft_GrSurfaceOrigin, swizzle);
GrColorInfo info(colorType, kUnpremul_SkAlphaType, nullptr);
auto surfaceContext = GrSurfaceContext::Make(dContext, readView, info);
if (!surfaceContext) {
ERRORF(reporter, "Could not create surface context for colorType: %d\n", colorType);
}
if (!surfaceContext->readPixels(dContext, actual, {0, 0})) {
// TODO: we need a better way to tell a priori if readPixels will work for an
// arbitrary colorType
#if 0
ERRORF(reporter, "Couldn't readback from GrSurfaceContext for colorType: %d\n",
colorType);
#endif
} else {
auto name = SkStringPrintf("%s::readPixels",
(renderableCtx == GrRenderable::kYes ? "GrSurfaceFillContext"
: "GrSurfaceContext"));
check_solid_pixmap(reporter, expectedColor, actual, colorType, label, name.c_str());
}
}
}
// Test initialization of GrBackendObjects to a specific color (non-static since used in Mtl test)
void test_color_init(GrDirectContext* dContext,
skiatest::Reporter* reporter,
std::function<sk_sp<ManagedBackendTexture>(GrDirectContext*,
const SkColor4f&,
GrMipmapped,
GrRenderable)> create,
GrColorType colorType,
const SkColor4f& color,
GrMipmapped mipmapped,
GrRenderable renderable) {
sk_sp<ManagedBackendTexture> mbet = create(dContext, color, mipmapped, renderable);
if (!mbet) {
// errors here should be reported by the test_wrapping test
return;
}
auto checkBackendTexture = [&](const SkColor4f& testColor) {
if (mipmapped == GrMipmapped::kYes) {
SkColor4f expectedColor = get_expected_color(testColor, colorType);
SkColor4f expectedColors[6] = {expectedColor, expectedColor, expectedColor,
expectedColor, expectedColor, expectedColor};
check_mipmaps(dContext, mbet->texture(), colorType, expectedColors, reporter,
"colorinit");
}
// The last step in this test will dirty the mipmaps so do it last
check_base_readbacks(dContext, mbet->texture(), colorType, renderable, testColor, reporter,
"colorinit");
};
checkBackendTexture(color);
SkColor4f newColor = {color.fB , color.fR, color.fG, color.fA };
SkColorType skColorType = GrColorTypeToSkColorType(colorType);
// Our update method only works with SkColorTypes.
if (skColorType != kUnknown_SkColorType) {
dContext->updateBackendTexture(mbet->texture(),
skColorType,
newColor,
ManagedBackendTexture::ReleaseProc,
mbet->releaseContext());
checkBackendTexture(newColor);
}
}
// Draw the backend texture into an RGBA surface fill context, attempting to access all the mipMap
// levels.
static void check_mipmaps(GrDirectContext* dContext,
const GrBackendTexture& backendTex,
GrColorType colorType,
const SkColor4f expectedColors[6],
skiatest::Reporter* reporter,
const char* label) {
#ifdef SK_GL
// skbug.com/9141 (RGBA_F32 mipmaps appear to be broken on some Mali devices)
if (GrBackendApi::kOpenGL == dContext->backend()) {
GrGLGpu* glGPU = static_cast<GrGLGpu*>(dContext->priv().getGpu());
if (colorType == GrColorType::kRGBA_F32 &&
glGPU->ctxInfo().standard() == kGLES_GrGLStandard) {
return;
}
}
#endif
if (isRGB(backendTex.getBackendFormat())) {
// readPixels is busted for the RGB backend format (skbug.com/8862)
// TODO: add a GrColorType::kRGB_888 to fix the situation
return;
}
GrImageInfo info(GrColorType::kRGBA_8888, kUnpremul_SkAlphaType, nullptr, {32, 32});
auto dstFillContext = GrSurfaceFillContext::Make(dContext, info);
if (!dstFillContext) {
ERRORF(reporter, "Could not make dst fill context.");
return;
}
int numMipLevels = 6;
auto proxy = dContext->priv().proxyProvider()->wrapBackendTexture(backendTex,
kBorrow_GrWrapOwnership,
GrWrapCacheable::kNo,
kRW_GrIOType);
if (!proxy) {
ERRORF(reporter, "Could not make proxy from backend texture");
return;
}
auto swizzle = dContext->priv().caps()->getReadSwizzle(backendTex.getBackendFormat(),
colorType);
GrSurfaceProxyView readView(proxy, kTopLeft_GrSurfaceOrigin, swizzle);
for (int i = 0, rectSize = 32; i < numMipLevels; ++i, rectSize /= 2) {
SkASSERT(rectSize >= 1);
dstFillContext->clear(SK_PMColor4fTRANSPARENT);
SkMatrix texMatrix;
texMatrix.setScale(1 << i, 1 << i);
static constexpr GrSamplerState kNearestNearest(GrSamplerState::Filter::kNearest,
GrSamplerState::MipmapMode::kNearest);
auto fp = GrTextureEffect::Make(readView,
kUnpremul_SkAlphaType,
texMatrix,
kNearestNearest,
*dstFillContext->caps());
// Our swizzles for alpha color types currently produce (a, a, a, a) in the shader. Remove
// this once they are correctly (0, 0, 0, a).
if (GrColorTypeIsAlphaOnly(colorType)) {
auto black = GrConstColorProcessor::Make(SK_PMColor4fBLACK);
fp = GrBlendFragmentProcessor::Make(std::move(fp),
std::move(black),
SkBlendMode::kModulate);
}
dstFillContext->fillRectWithFP(SkIRect::MakeWH(rectSize, rectSize), std::move(fp));
SkImageInfo readbackII = SkImageInfo::Make(rectSize, rectSize,
kRGBA_8888_SkColorType,
kUnpremul_SkAlphaType);
SkAutoPixmapStorage actual;
SkAssertResult(actual.tryAlloc(readbackII));
actual.erase(SkColors::kTransparent);
bool result = dstFillContext->readPixels(dContext, actual, {0, 0});
REPORTER_ASSERT(reporter, result);
SkString str;
str.appendf("mip-level %d", i);
check_solid_pixmap(reporter, expectedColors[i], actual, colorType, label, str.c_str());
}
}
static int make_pixmaps(SkColorType skColorType,
GrMipmapped mipmapped,
const SkColor4f colors[6],
SkPixmap pixmaps[6],
std::unique_ptr<char[]>* mem) {
int levelSize = 32;
int numMipLevels = mipmapped == GrMipmapped::kYes ? 6 : 1;
size_t size = 0;
SkImageInfo ii[6];
size_t rowBytes[6];
for (int level = 0; level < numMipLevels; ++level) {
ii[level] = SkImageInfo::Make(levelSize, levelSize, skColorType, kUnpremul_SkAlphaType);
rowBytes[level] = ii[level].minRowBytes();
// Make sure we test row bytes that aren't tight.
if (!(level % 2)) {
rowBytes[level] += (level + 1)*SkColorTypeBytesPerPixel(ii[level].colorType());
}
size += rowBytes[level]*ii[level].height();
levelSize /= 2;
}
mem->reset(new char[size]);
char* addr = mem->get();
for (int level = 0; level < numMipLevels; ++level) {
pixmaps[level].reset(ii[level], addr, rowBytes[level]);
addr += rowBytes[level]*ii[level].height();
pixmaps[level].erase(colors[level]);
levelSize /= 2;
}
return numMipLevels;
}
// Test initialization of GrBackendObjects using SkPixmaps
static void test_pixmap_init(GrDirectContext* dContext,
skiatest::Reporter* reporter,
std::function<sk_sp<ManagedBackendTexture>(GrDirectContext*,
const SkPixmap srcData[],
int numLevels,
GrSurfaceOrigin,
GrRenderable)> create,
SkColorType skColorType,
GrSurfaceOrigin origin,
GrMipmapped mipmapped,
GrRenderable renderable) {
SkPixmap pixmaps[6];
std::unique_ptr<char[]> memForPixmaps;
SkColor4f colors[6] = {
{ 1.0f, 0.0f, 0.0f, 1.0f }, // R
{ 0.0f, 1.0f, 0.0f, 0.9f }, // G
{ 0.0f, 0.0f, 1.0f, 0.7f }, // B
{ 0.0f, 1.0f, 1.0f, 0.5f }, // C
{ 1.0f, 0.0f, 1.0f, 0.3f }, // M
{ 1.0f, 1.0f, 0.0f, 0.2f }, // Y
};
int numMipLevels = make_pixmaps(skColorType, mipmapped, colors, pixmaps, &memForPixmaps);
SkASSERT(numMipLevels);
sk_sp<ManagedBackendTexture> mbet = create(dContext, pixmaps, numMipLevels, origin, renderable);
if (!mbet) {
// errors here should be reported by the test_wrapping test
return;
}
if (skColorType == kBGRA_8888_SkColorType && !isBGRA8(mbet->texture().getBackendFormat())) {
// When kBGRA is backed by an RGBA something goes wrong in the swizzling
return;
}
auto checkBackendTexture = [&](SkColor4f colors[6]) {
GrColorType grColorType = SkColorTypeToGrColorType(skColorType);
if (mipmapped == GrMipmapped::kYes) {
SkColor4f expectedColors[6] = {
get_expected_color(colors[0], grColorType),
get_expected_color(colors[1], grColorType),
get_expected_color(colors[2], grColorType),
get_expected_color(colors[3], grColorType),
get_expected_color(colors[4], grColorType),
get_expected_color(colors[5], grColorType),
};
check_mipmaps(dContext, mbet->texture(), grColorType, expectedColors, reporter,
"pixmap");
}
// The last step in this test will dirty the mipmaps so do it last
check_base_readbacks(dContext, mbet->texture(), grColorType, renderable, colors[0],
reporter, "pixmap");
};
checkBackendTexture(colors);
SkColor4f colorsNew[6] = {
{1.0f, 1.0f, 0.0f, 0.2f}, // Y
{1.0f, 0.0f, 0.0f, 1.0f}, // R
{0.0f, 1.0f, 0.0f, 0.9f}, // G
{0.0f, 0.0f, 1.0f, 0.7f}, // B
{0.0f, 1.0f, 1.0f, 0.5f}, // C
{1.0f, 0.0f, 1.0f, 0.3f}, // M
};
make_pixmaps(skColorType, mipmapped, colorsNew, pixmaps, &memForPixmaps);
// Upload new data and make sure everything still works
dContext->updateBackendTexture(mbet->texture(),
pixmaps,
numMipLevels,
origin,
ManagedBackendTexture::ReleaseProc,
mbet->releaseContext());
checkBackendTexture(colorsNew);
}
enum class VkLayout {
kUndefined,
kReadOnlyOptimal,
};
void check_vk_layout(const GrBackendTexture& backendTex, VkLayout layout) {
#if defined(SK_VULKAN) && defined(SK_DEBUG)
VkImageLayout expected;
switch (layout) {
case VkLayout::kUndefined:
expected = VK_IMAGE_LAYOUT_UNDEFINED;
break;
case VkLayout::kReadOnlyOptimal:
expected = VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL;
break;
default:
SkUNREACHABLE;
}
GrVkImageInfo vkII;
if (backendTex.getVkImageInfo(&vkII)) {
SkASSERT(expected == vkII.fImageLayout);
SkASSERT(VK_IMAGE_TILING_OPTIMAL == vkII.fImageTiling);
}
#endif
}
///////////////////////////////////////////////////////////////////////////////
void color_type_backend_allocation_test(const sk_gpu_test::ContextInfo& ctxInfo,
skiatest::Reporter* reporter) {
auto context = ctxInfo.directContext();
const GrCaps* caps = context->priv().caps();
constexpr SkColor4f kTransCol { 0, 0.25f, 0.75f, 0.5f };
constexpr SkColor4f kGrayCol { 0.75f, 0.75f, 0.75f, 0.75f };
struct {
SkColorType fColorType;
SkColor4f fColor;
} combinations[] = {
{ kAlpha_8_SkColorType, kTransCol },
{ kRGB_565_SkColorType, SkColors::kRed },
{ kARGB_4444_SkColorType, SkColors::kGreen },
{ kRGBA_8888_SkColorType, SkColors::kBlue },
{ kRGB_888x_SkColorType, SkColors::kCyan },
// TODO: readback is busted when alpha = 0.5f (perhaps premul vs. unpremul)
{ kBGRA_8888_SkColorType, { 1, 0, 0, 1.0f } },
// TODO: readback is busted for *10A2 when alpha = 0.5f (perhaps premul vs. unpremul)
{ kRGBA_1010102_SkColorType, { 0.25f, 0.5f, 0.75f, 1.0f }},
{ kBGRA_1010102_SkColorType, { 0.25f, 0.5f, 0.75f, 1.0f }},
// RGB/BGR 101010x have no Ganesh correlate
{ kRGB_101010x_SkColorType, { 0, 0.5f, 0, 0.5f } },
{ kBGR_101010x_SkColorType, { 0, 0.5f, 0, 0.5f } },
{ kGray_8_SkColorType, kGrayCol },
{ kRGBA_F16Norm_SkColorType, SkColors::kLtGray },
{ kRGBA_F16_SkColorType, SkColors::kYellow },
{ kRGBA_F32_SkColorType, SkColors::kGray },
{ kR8G8_unorm_SkColorType, { .25f, .75f, 0, 1 } },
{ kR16G16_unorm_SkColorType, SkColors::kGreen },
{ kA16_unorm_SkColorType, kTransCol },
{ kA16_float_SkColorType, kTransCol },
{ kR16G16_float_SkColorType, { .25f, .75f, 0, 1 } },
{ kR16G16B16A16_unorm_SkColorType,{ .25f, .5f, .75f, 1 } },
};
static_assert(kLastEnum_SkColorType == SK_ARRAY_COUNT(combinations));
for (auto combo : combinations) {
SkColorType colorType = combo.fColorType;
if (GrBackendApi::kMetal == context->backend()) {
// skbug.com/9086 (Metal caps may not be handling RGBA32 correctly)
if (kRGBA_F32_SkColorType == combo.fColorType) {
continue;
}
}
for (auto mipmapped : {GrMipmapped::kNo, GrMipmapped::kYes}) {
if (GrMipmapped::kYes == mipmapped && !caps->mipmapSupport()) {
continue;
}
for (auto renderable : { GrRenderable::kNo, GrRenderable::kYes }) {
if (!caps->getDefaultBackendFormat(SkColorTypeToGrColorType(colorType),
renderable).isValid()) {
continue;
}
if (GrRenderable::kYes == renderable) {
if (kRGB_888x_SkColorType == combo.fColorType) {
// Ganesh can't perform the blends correctly when rendering this format
continue;
}
}
{
auto uninitCreateMtd = [colorType](GrDirectContext* dContext,
GrMipmapped mipmapped,
GrRenderable renderable) {
auto mbet = ManagedBackendTexture::MakeWithoutData(dContext,
32, 32,
colorType,
mipmapped,
renderable,
GrProtected::kNo);
check_vk_layout(mbet->texture(), VkLayout::kUndefined);
#ifdef SK_DEBUG
{
GrBackendFormat format = dContext->defaultBackendFormat(colorType,
renderable);
SkASSERT(format == mbet->texture().getBackendFormat());
}
#endif
return mbet;
};
test_wrapping(context, reporter, uninitCreateMtd,
SkColorTypeToGrColorType(colorType), mipmapped, renderable);
}
{
auto createWithColorMtd = [colorType](GrDirectContext* dContext,
const SkColor4f& color,
GrMipmapped mipmapped,
GrRenderable renderable) {
auto mbet = ManagedBackendTexture::MakeWithData(dContext,
32, 32,
colorType,
color,
mipmapped,
renderable,
GrProtected::kNo);
check_vk_layout(mbet->texture(), VkLayout::kReadOnlyOptimal);
#ifdef SK_DEBUG
{
GrBackendFormat format = dContext->defaultBackendFormat(colorType,
renderable);
SkASSERT(format == mbet->texture().getBackendFormat());
}
#endif
return mbet;
};
test_color_init(context, reporter, createWithColorMtd,
SkColorTypeToGrColorType(colorType), combo.fColor, mipmapped,
renderable);
}
for (auto origin : {kTopLeft_GrSurfaceOrigin, kBottomLeft_GrSurfaceOrigin}) {
auto createWithSrcDataMtd = [](GrDirectContext* dContext,
const SkPixmap srcData[],
int numLevels,
GrSurfaceOrigin origin,
GrRenderable renderable) {
SkASSERT(srcData && numLevels);
auto mbet = ManagedBackendTexture::MakeWithData(dContext,
srcData,
numLevels,
origin,
renderable,
GrProtected::kNo);
check_vk_layout(mbet->texture(), VkLayout::kReadOnlyOptimal);
#ifdef SK_DEBUG
{
auto format = dContext->defaultBackendFormat(srcData[0].colorType(),
renderable);
SkASSERT(format == mbet->texture().getBackendFormat());
}
#endif
return mbet;
};
test_pixmap_init(context,
reporter,
createWithSrcDataMtd,
colorType,
origin,
mipmapped,
renderable);
}
}
}
}
}
DEF_GPUTEST(ColorTypeBackendAllocationTest, reporter, options) {
for (int t = 0; t < sk_gpu_test::GrContextFactory::kContextTypeCnt; ++t) {
auto type = static_cast<sk_gpu_test::GrContextFactory::ContextType>(t);
if (!sk_gpu_test::GrContextFactory::IsRenderingContext(type)) {
continue;
}
sk_gpu_test::GrContextFactory factory(options);
sk_gpu_test::ContextInfo info = factory.getContextInfo(type);
if (!info.directContext()) {
continue;
}
color_type_backend_allocation_test(info, reporter);
// The GL backend must support contexts that don't allow GL_UNPACK_ROW_LENGTH. Other
// backends are not required to work with this cap disabled.
if (info.directContext()->priv().caps()->writePixelsRowBytesSupport() &&
info.directContext()->backend() == GrBackendApi::kOpenGL) {
GrContextOptions overrideOptions = options;
overrideOptions.fDisallowWritePixelRowBytes = true;
sk_gpu_test::GrContextFactory overrideFactory(overrideOptions);
info = overrideFactory.getContextInfo(type);
color_type_backend_allocation_test(info, reporter);
}
}
}
///////////////////////////////////////////////////////////////////////////////
#ifdef SK_GL
DEF_GPUTEST_FOR_ALL_GL_CONTEXTS(GLBackendAllocationTest, reporter, ctxInfo) {
sk_gpu_test::GLTestContext* glCtx = ctxInfo.glContext();
GrGLStandard standard = glCtx->gl()->fStandard;
auto context = ctxInfo.directContext();
const GrGLCaps* glCaps = static_cast<const GrGLCaps*>(context->priv().caps());
constexpr SkColor4f kTransCol { 0, 0.25f, 0.75f, 0.5f };
constexpr SkColor4f kGrayCol { 0.75f, 0.75f, 0.75f, 1.f };
constexpr SkColor4f kTransGrayCol { 0.5f, 0.5f, 0.5f, .8f };
struct {
GrColorType fColorType;
GrGLenum fFormat;
SkColor4f fColor;
} combinations[] = {
{ GrColorType::kRGBA_8888, GR_GL_RGBA8, SkColors::kRed },
{ GrColorType::kRGBA_8888_SRGB, GR_GL_SRGB8_ALPHA8, SkColors::kRed },
{ GrColorType::kRGB_888x, GR_GL_RGBA8, SkColors::kYellow },
{ GrColorType::kRGB_888x, GR_GL_RGB8, SkColors::kCyan },
{ GrColorType::kBGRA_8888, GR_GL_RGBA8, SkColors::kBlue },
{ GrColorType::kBGRA_8888, GR_GL_BGRA8, SkColors::kBlue },
// TODO: readback is busted when alpha = 0.5f (perhaps premul vs. unpremul)
{ GrColorType::kRGBA_1010102, GR_GL_RGB10_A2, { 0.25f, 0.5f, 0.75f, 1.f }},
{ GrColorType::kBGRA_1010102, GR_GL_RGB10_A2, { 0.25f, 0.5f, 0.75f, 1.f }},
{ GrColorType::kBGR_565, GR_GL_RGB565, SkColors::kRed },
{ GrColorType::kABGR_4444, GR_GL_RGBA4, SkColors::kGreen },
{ GrColorType::kAlpha_8, GR_GL_ALPHA8, kTransCol },
{ GrColorType::kAlpha_8, GR_GL_R8, kTransCol },
{ GrColorType::kGray_8, GR_GL_LUMINANCE8, kGrayCol },
{ GrColorType::kGray_8, GR_GL_R8, kGrayCol },
{ GrColorType::kGrayAlpha_88, GR_GL_LUMINANCE8_ALPHA8, kTransGrayCol },
{ GrColorType::kRGBA_F32, GR_GL_RGBA32F, SkColors::kRed },
{ GrColorType::kRGBA_F16_Clamped, GR_GL_RGBA16F, SkColors::kLtGray },
{ GrColorType::kRGBA_F16, GR_GL_RGBA16F, SkColors::kYellow },
{ GrColorType::kRG_88, GR_GL_RG8, { 1, 0.5f, 0, 1 } },
{ GrColorType::kAlpha_F16, GR_GL_R16F, { 1.0f, 0, 0, 0.5f } },
{ GrColorType::kAlpha_F16, GR_GL_LUMINANCE16F, kGrayCol },
{ GrColorType::kAlpha_16, GR_GL_R16, kTransCol },
{ GrColorType::kRG_1616, GR_GL_RG16, SkColors::kYellow },
{ GrColorType::kRGBA_16161616, GR_GL_RGBA16, SkColors::kLtGray },
{ GrColorType::kRG_F16, GR_GL_RG16F, SkColors::kYellow },
};
for (auto combo : combinations) {
for (GrGLenum target : {GR_GL_TEXTURE_2D, GR_GL_TEXTURE_RECTANGLE}) {
GrBackendFormat format = GrBackendFormat::MakeGL(combo.fFormat, target);
if (!glCaps->isFormatTexturable(format)) {
continue;
}
if (GrColorType::kBGRA_8888 == combo.fColorType ||
GrColorType::kBGRA_1010102 == combo.fColorType) {
// We allow using a GL_RGBA8 or GR_GL_RGB10_A2 texture as BGRA on desktop GL but not
// ES
if (kGL_GrGLStandard != standard &&
(GR_GL_RGBA8 == combo.fFormat || GR_GL_RGB10_A2 == combo.fFormat)) {
continue;
}
}
for (auto mipMapped : {GrMipmapped::kNo, GrMipmapped::kYes}) {
if (GrMipmapped::kYes == mipMapped &&
(!glCaps->mipmapSupport() || target == GR_GL_TEXTURE_RECTANGLE)) {
continue;
}
for (auto renderable : {GrRenderable::kNo, GrRenderable::kYes}) {
if (GrRenderable::kYes == renderable) {
if (!glCaps->isFormatAsColorTypeRenderable(combo.fColorType, format)) {
continue;
}
}
{
auto uninitCreateMtd = [format](GrDirectContext* dContext,
GrMipmapped mipMapped,
GrRenderable renderable) {
return ManagedBackendTexture::MakeWithoutData(dContext,
32, 32,
format,
mipMapped,
renderable,
GrProtected::kNo);
};
test_wrapping(context, reporter, uninitCreateMtd, combo.fColorType,
mipMapped, renderable);
}
{
// We're creating backend textures without specifying a color type "view" of
// them at the public API level. Therefore, Ganesh will not apply any
// swizzles before writing the color to the texture. However, our validation
// code does rely on interpreting the texture contents via a SkColorType and
// therefore swizzles may be applied during the read step. Ideally we'd
// update our validation code to use a "raw" read that doesn't impose a
// color type but for now we just munge the data we upload to match the
// expectation.
GrSwizzle swizzle;
switch (combo.fColorType) {
case GrColorType::kAlpha_8:
swizzle = GrSwizzle("aaaa");
break;
case GrColorType::kAlpha_16:
swizzle = GrSwizzle("aaaa");
break;
case GrColorType::kAlpha_F16:
swizzle = GrSwizzle("aaaa");
break;
default:
break;
}
auto createWithColorMtd = [format, swizzle](GrDirectContext* dContext,
const SkColor4f& color,
GrMipmapped mipmapped,
GrRenderable renderable) {
auto swizzledColor = swizzle.applyTo(color);
return ManagedBackendTexture::MakeWithData(dContext,
32, 32,
format,
swizzledColor,
mipmapped,
renderable,
GrProtected::kNo);
};
test_color_init(context, reporter, createWithColorMtd, combo.fColorType,
combo.fColor, mipMapped, renderable);
}
}
}
}
}
}
#endif
///////////////////////////////////////////////////////////////////////////////
#ifdef SK_VULKAN
#include "src/gpu/vk/GrVkCaps.h"
DEF_GPUTEST_FOR_VULKAN_CONTEXT(VkBackendAllocationTest, reporter, ctxInfo) {
auto context = ctxInfo.directContext();
const GrVkCaps* vkCaps = static_cast<const GrVkCaps*>(context->priv().caps());
constexpr SkColor4f kTransCol { 0, 0.25f, 0.75f, 0.5f };
constexpr SkColor4f kGrayCol { 0.75f, 0.75f, 0.75f, 1 };
struct {
GrColorType fColorType;
VkFormat fFormat;
SkColor4f fColor;
} combinations[] = {
{ GrColorType::kRGBA_8888, VK_FORMAT_R8G8B8A8_UNORM, SkColors::kRed },
{ GrColorType::kRGBA_8888_SRGB, VK_FORMAT_R8G8B8A8_SRGB, SkColors::kRed },
// In this configuration (i.e., an RGB_888x colortype with an RGBA8 backing format),
// there is nothing to tell Skia to make the provided color opaque. Clients will need
// to provide an opaque initialization color in this case.
{ GrColorType::kRGB_888x, VK_FORMAT_R8G8B8A8_UNORM, SkColors::kYellow },
{ GrColorType::kRGB_888x, VK_FORMAT_R8G8B8_UNORM, SkColors::kCyan },
{ GrColorType::kBGRA_8888, VK_FORMAT_B8G8R8A8_UNORM, SkColors::kBlue },
{ GrColorType::kRGBA_1010102, VK_FORMAT_A2B10G10R10_UNORM_PACK32,
{ 0.25f, 0.5f, 0.75f, 1.0f }},
{ GrColorType::kBGRA_1010102, VK_FORMAT_A2R10G10B10_UNORM_PACK32,
{ 0.25f, 0.5f, 0.75f, 1.0f }},
{ GrColorType::kBGR_565, VK_FORMAT_R5G6B5_UNORM_PACK16, SkColors::kRed },
{ GrColorType::kABGR_4444, VK_FORMAT_R4G4B4A4_UNORM_PACK16, SkColors::kCyan },
{ GrColorType::kABGR_4444, VK_FORMAT_B4G4R4A4_UNORM_PACK16, SkColors::kYellow },
{ GrColorType::kAlpha_8, VK_FORMAT_R8_UNORM, kTransCol },
// In this config (i.e., a Gray8 color type with an R8 backing format), there is nothing
// to tell Skia this isn't an Alpha8 color type (so it will initialize the texture with
// the alpha channel of the color). Clients should, in general, fill all the channels
// of the provided color with the same value in such cases.
{ GrColorType::kGray_8, VK_FORMAT_R8_UNORM, kGrayCol },
{ GrColorType::kRGBA_F16_Clamped, VK_FORMAT_R16G16B16A16_SFLOAT, SkColors::kLtGray },
{ GrColorType::kRGBA_F16, VK_FORMAT_R16G16B16A16_SFLOAT, SkColors::kYellow },
{ GrColorType::kRG_88, VK_FORMAT_R8G8_UNORM, { 1, 0.5f, 0, 1 } },
{ GrColorType::kAlpha_F16, VK_FORMAT_R16_SFLOAT, { 1.0f, 0, 0, 0.5f }},
{ GrColorType::kAlpha_16, VK_FORMAT_R16_UNORM, kTransCol },
{ GrColorType::kRG_1616, VK_FORMAT_R16G16_UNORM, SkColors::kYellow },
{ GrColorType::kRGBA_16161616, VK_FORMAT_R16G16B16A16_UNORM, SkColors::kLtGray },
{ GrColorType::kRG_F16, VK_FORMAT_R16G16_SFLOAT, SkColors::kYellow },
};
for (auto combo : combinations) {
if (!vkCaps->isVkFormatTexturable(combo.fFormat)) {
continue;
}
GrBackendFormat format = GrBackendFormat::MakeVk(combo.fFormat);
for (auto mipMapped : { GrMipmapped::kNo, GrMipmapped::kYes }) {
if (GrMipmapped::kYes == mipMapped && !vkCaps->mipmapSupport()) {
continue;
}
for (auto renderable : { GrRenderable::kNo, GrRenderable::kYes }) {
if (GrRenderable::kYes == renderable) {
// We must also check whether we allow rendering to the format using the
// color type.
if (!vkCaps->isFormatAsColorTypeRenderable(
combo.fColorType, GrBackendFormat::MakeVk(combo.fFormat), 1)) {
continue;
}
}
{
auto uninitCreateMtd = [format](GrDirectContext* dContext,
GrMipmapped mipMapped,
GrRenderable renderable) {
auto mbet = ManagedBackendTexture::MakeWithoutData(dContext,
32, 32,
format,
mipMapped,
renderable,
GrProtected::kNo);
check_vk_layout(mbet->texture(), VkLayout::kUndefined);
return mbet;
};
test_wrapping(context, reporter, uninitCreateMtd, combo.fColorType, mipMapped,
renderable);
}
{
// We're creating backend textures without specifying a color type "view" of
// them at the public API level. Therefore, Ganesh will not apply any swizzles
// before writing the color to the texture. However, our validation code does
// rely on interpreting the texture contents via a SkColorType and therefore
// swizzles may be applied during the read step.
// Ideally we'd update our validation code to use a "raw" read that doesn't
// impose a color type but for now we just munge the data we upload to match the
// expectation.
GrSwizzle swizzle;
switch (combo.fColorType) {
case GrColorType::kAlpha_8:
SkASSERT(combo.fFormat == VK_FORMAT_R8_UNORM);
swizzle = GrSwizzle("aaaa");
break;
case GrColorType::kAlpha_16:
SkASSERT(combo.fFormat == VK_FORMAT_R16_UNORM);
swizzle = GrSwizzle("aaaa");
break;
case GrColorType::kAlpha_F16:
SkASSERT(combo.fFormat == VK_FORMAT_R16_SFLOAT);
swizzle = GrSwizzle("aaaa");
break;
case GrColorType::kABGR_4444:
if (combo.fFormat == VK_FORMAT_B4G4R4A4_UNORM_PACK16) {
swizzle = GrSwizzle("bgra");
}
break;
default:
swizzle = GrSwizzle("rgba");
break;
}
auto createWithColorMtd = [format, swizzle](GrDirectContext* dContext,
const SkColor4f& color,
GrMipmapped mipMapped,
GrRenderable renderable) {
auto swizzledColor = swizzle.applyTo(color);
auto mbet = ManagedBackendTexture::MakeWithData(dContext,
32, 32,
format,
swizzledColor,
mipMapped,
renderable,
GrProtected::kNo);
check_vk_layout(mbet->texture(), VkLayout::kReadOnlyOptimal);
return mbet;
};
test_color_init(context, reporter, createWithColorMtd, combo.fColorType,
combo.fColor, mipMapped, renderable);
}
}
}
}
}
#endif
Reference in New Issue View Git Blame Copy Permalink