c75e2401a8
We need to discriminate between nodes whose bounds updates contribute to the dirty
region, and nodes whose bounds changes do not.
E.g. animated shape in a group: the animated shape node bounds should yield damage,
but the ancestor group bounds should not.
To accomplish this, we refine the invalidation state:
1) self invalidation == the node itself was invalidated, and its bounds updates
yield damage.
2) descendant invalidation == the node has some (self-)invalidated descendant,
but its own bounds are not contributing damage.
Also:
* hoist the bounding box invalidation logic into the base class (Node::revalidate)
and update to respect the states described above.
* remove (now-redundant) GeometryNode bbox logic.
* update revalidation methods to return the node bbox instead of void
TBR=
Change-Id: I8023d1793fb501c945a53f2dc2d2983e5b620ade
Reviewed-on: https://skia-review.googlesource.com/90581
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
49 lines
1021 B
C++
49 lines
1021 B
C++
/*
|
|
* Copyright 2017 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#ifndef SkSGDraw_DEFINED
|
|
#define SkSGDraw_DEFINED
|
|
|
|
#include "SkSGRenderNode.h"
|
|
|
|
namespace sksg {
|
|
|
|
class GeometryNode;
|
|
class PaintNode;
|
|
|
|
/**
|
|
* Concrete rendering node.
|
|
*
|
|
* Wraps and draws a [geometry, paint] tuple.
|
|
*
|
|
* Think Skia SkCanvas::drawFoo(foo, paint) calls.
|
|
*/
|
|
class Draw : public RenderNode {
|
|
public:
|
|
static sk_sp<Draw> Make(sk_sp<GeometryNode> geo, sk_sp<PaintNode> paint) {
|
|
return (geo && paint) ? sk_sp<Draw>(new Draw(std::move(geo), std::move(paint))) : nullptr;
|
|
}
|
|
|
|
protected:
|
|
Draw(sk_sp<GeometryNode>, sk_sp<PaintNode> paint);
|
|
~Draw() override;
|
|
|
|
void onRender(SkCanvas*) const override;
|
|
|
|
SkRect onRevalidate(InvalidationController*, const SkMatrix&) override;
|
|
|
|
private:
|
|
sk_sp<GeometryNode> fGeometry;
|
|
sk_sp<PaintNode> fPaint;
|
|
|
|
typedef RenderNode INHERITED;
|
|
};
|
|
|
|
} // namespace sksg
|
|
|
|
#endif // SkSGDraw_DEFINED
|