c75e2401a8
We need to discriminate between nodes whose bounds updates contribute to the dirty
region, and nodes whose bounds changes do not.
E.g. animated shape in a group: the animated shape node bounds should yield damage,
but the ancestor group bounds should not.
To accomplish this, we refine the invalidation state:
1) self invalidation == the node itself was invalidated, and its bounds updates
yield damage.
2) descendant invalidation == the node has some (self-)invalidated descendant,
but its own bounds are not contributing damage.
Also:
* hoist the bounding box invalidation logic into the base class (Node::revalidate)
and update to respect the states described above.
* remove (now-redundant) GeometryNode bbox logic.
* update revalidation methods to return the node bbox instead of void
TBR=
Change-Id: I8023d1793fb501c945a53f2dc2d2983e5b620ade
Reviewed-on: https://skia-review.googlesource.com/90581
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
46 lines
880 B
C++
46 lines
880 B
C++
/*
|
|
* Copyright 2017 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#ifndef SkSGGeometryNode_DEFINED
|
|
#define SkSGGeometryNode_DEFINED
|
|
|
|
#include "SkSGNode.h"
|
|
|
|
class SkCanvas;
|
|
class SkPaint;
|
|
|
|
namespace sksg {
|
|
|
|
/**
|
|
* Base class for nodes which provide 'geometry' (as opposed to paint)
|
|
* for drawing.
|
|
*
|
|
* Think SkRect, SkPath, etc.
|
|
*/
|
|
class GeometryNode : public Node {
|
|
public:
|
|
void draw(SkCanvas*, const SkPaint&) const;
|
|
|
|
// SkPath asPath() const; // unused for now
|
|
|
|
protected:
|
|
GeometryNode() = default;
|
|
|
|
virtual void onDraw(SkCanvas*, const SkPaint&) const = 0;
|
|
|
|
// virtual SkPath onAsPath() const = 0; // unused for now
|
|
|
|
private:
|
|
friend class Draw; // wants to know the cached bounds.
|
|
|
|
typedef Node INHERITED;
|
|
};
|
|
|
|
} // namespace sksg
|
|
|
|
#endif // SkSGGeometryNode_DEFINED
|