406654be7a
SkTaskGroup is like SkThreadPool except the threads stay in one global pool. Each SkTaskGroup itself is tiny (4 bytes) and its wait() method applies only to tasks add()ed to that instance, not the whole thread pool. This means we don't need to bring up new thread pools when tests themselves want to use multithreading (e.g. pathops, quilt). We just create a new SkTaskGroup and wait for that to complete. This should be more efficient, and allow us to expand where we use threads to really latency sensitive places. E.g. we can probably now use these in nanobench for CPU .skp rendering. Now that all threads are sharing the same pool, I think we can remove most of the custom mechanism pathops tests use to control threading. They'll just ride on the global pool with all other tests now. This (temporarily?) removes the GPU multithreading feature from DM, which we don't use. On my desktop, DM runs a little faster (57s -> 55s) in Debug, and a lot faster in Release (36s -> 24s). The bots show speedups of similar proportions, cutting more than a minute off the N4/Release and Win7/Debug runtimes. BUG=skia: Committed: https://skia.googlesource.com/skia/+/9c7207b5dc71dc5a96a2eb107d401133333d5b6f R=caryclark@google.com, bsalomon@google.com, bungeman@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/531653002
77 lines
1.5 KiB
C++
77 lines
1.5 KiB
C++
/*
|
|
* Copyright 2013 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "SkOnce.h"
|
|
#include "SkTaskGroup.h"
|
|
#include "Test.h"
|
|
|
|
static void add_five(int* x) {
|
|
*x += 5;
|
|
}
|
|
|
|
DEF_TEST(SkOnce_Singlethreaded, r) {
|
|
int x = 0;
|
|
|
|
SK_DECLARE_STATIC_ONCE(once);
|
|
// No matter how many times we do this, x will be 5.
|
|
SkOnce(&once, add_five, &x);
|
|
SkOnce(&once, add_five, &x);
|
|
SkOnce(&once, add_five, &x);
|
|
SkOnce(&once, add_five, &x);
|
|
SkOnce(&once, add_five, &x);
|
|
|
|
REPORTER_ASSERT(r, 5 == x);
|
|
}
|
|
|
|
static void add_six(int* x) {
|
|
*x += 6;
|
|
}
|
|
|
|
class Racer : public SkRunnable {
|
|
public:
|
|
SkOnceFlag* once;
|
|
int* ptr;
|
|
|
|
virtual void run() SK_OVERRIDE {
|
|
SkOnce(once, add_six, ptr);
|
|
}
|
|
};
|
|
|
|
DEF_TEST(SkOnce_Multithreaded, r) {
|
|
const int kTasks = 16;
|
|
|
|
// Make a bunch of tasks that will race to be the first to add six to x.
|
|
Racer racers[kTasks];
|
|
SK_DECLARE_STATIC_ONCE(once);
|
|
int x = 0;
|
|
for (int i = 0; i < kTasks; i++) {
|
|
racers[i].once = &once;
|
|
racers[i].ptr = &x;
|
|
}
|
|
|
|
// Let them race.
|
|
SkTaskGroup tg;
|
|
for (int i = 0; i < kTasks; i++) {
|
|
tg.add(&racers[i]);
|
|
}
|
|
tg.wait();
|
|
|
|
// Only one should have done the +=.
|
|
REPORTER_ASSERT(r, 6 == x);
|
|
}
|
|
|
|
static int gX = 0;
|
|
static void inc_gX() { gX++; }
|
|
|
|
DEF_TEST(SkOnce_NoArg, r) {
|
|
SK_DECLARE_STATIC_ONCE(once);
|
|
SkOnce(&once, inc_gX);
|
|
SkOnce(&once, inc_gX);
|
|
SkOnce(&once, inc_gX);
|
|
REPORTER_ASSERT(r, 1 == gX);
|
|
}
|