82065d667f
SkSafeRef() and SkSafeUnref().
This is basically a bug waiting to happen. An optimizing compiler can remove
checks for null on "this" if it chooses. However, SkRefCnt::safeRef() relies on
precisely this check...
void SkRefCnt::safeRef() {
if (this) {
this->ref();
}
}
Since a compiler might skip the if-clause, it breaks the intention of this
method, hence its removal.
static inline void SkSafeRef(SkRefCnt* obj) {
if (obj) {
obj->ref();
}
}
This form is not ignored by an optimizing compile, so we use it instead.
git-svn-id: http://skia.googlecode.com/svn/trunk@762 2bbb7eff-a529-9590-31e7-b0007b416f81
62 lines
1.4 KiB
C++
62 lines
1.4 KiB
C++
#include "SampleCode.h"
|
|
#include "SkView.h"
|
|
#include "SkCanvas.h"
|
|
#include "SkMovie.h"
|
|
#include "SkTime.h"
|
|
#include <new>
|
|
|
|
class AnimGifView : public SkView {
|
|
SkMovie* fMovie;
|
|
public:
|
|
AnimGifView() {
|
|
fMovie = SkMovie::DecodeFile("/skimages/dollarblk.gif");
|
|
}
|
|
|
|
virtual ~AnimGifView() {
|
|
SkSafeUnref(fMovie);
|
|
}
|
|
|
|
protected:
|
|
// overrides from SkEventSink
|
|
virtual bool onQuery(SkEvent* evt) {
|
|
if (SampleCode::TitleQ(*evt)) {
|
|
SampleCode::TitleR(evt, "Animated Gif");
|
|
return true;
|
|
}
|
|
return this->INHERITED::onQuery(evt);
|
|
}
|
|
|
|
void drawBG(SkCanvas* canvas) {
|
|
canvas->drawColor(0xFFDDDDDD);
|
|
}
|
|
|
|
virtual void onDraw(SkCanvas* canvas) {
|
|
this->drawBG(canvas);
|
|
|
|
if (fMovie) {
|
|
if (fMovie->duration()) {
|
|
fMovie->setTime(SkTime::GetMSecs() % fMovie->duration());
|
|
} else {
|
|
fMovie->setTime(0);
|
|
}
|
|
canvas->drawBitmap(fMovie->bitmap(), SkIntToScalar(20),
|
|
SkIntToScalar(20));
|
|
this->inval(NULL);
|
|
}
|
|
}
|
|
|
|
private:
|
|
SkRect fClip;
|
|
SkIPoint* fPoints;
|
|
SkPath fPath;
|
|
int fPtCount;
|
|
|
|
typedef SkView INHERITED;
|
|
};
|
|
|
|
//////////////////////////////////////////////////////////////////////////////
|
|
|
|
static SkView* MyFactory() { return new AnimGifView; }
|
|
static SkViewRegister reg(MyFactory);
|
|
|