39e8d93337
- Don't print status updates for skipped tasks or count them as pending tasks. - Refactor DMReporter a bit for better symmetry, be more explicit about how we read atomics (that is, approximately) in printStatus() (née finish()). - Remove mutex locking from printStatus(). BUG=skia: R=halcanary@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/309483003 git-svn-id: http://skia.googlecode.com/svn/trunk@14977 2bbb7eff-a529-9590-31e7-b0007b416f81
45 lines
1.2 KiB
C++
45 lines
1.2 KiB
C++
#include "DMReporter.h"
|
|
|
|
#include "SkDynamicAnnotations.h"
|
|
#include "SkCommandLineFlags.h"
|
|
#include "OverwriteLine.h"
|
|
|
|
DEFINE_bool2(quiet, q, false, "If true, don't print status updates.");
|
|
DEFINE_bool2(verbose, v, false, "If true, print status updates one-per-line.");
|
|
|
|
namespace DM {
|
|
|
|
void Reporter::printStatus(SkString name, SkMSec timeMs) const {
|
|
if (FLAGS_quiet) {
|
|
return;
|
|
}
|
|
|
|
// It's okay if these are a little off---they're just for show---so we can read unprotectedly.
|
|
const int32_t failed = SK_ANNOTATE_UNPROTECTED_READ(fFailed);
|
|
const int32_t pending = SK_ANNOTATE_UNPROTECTED_READ(fPending) - 1;
|
|
|
|
SkString status;
|
|
status.printf("%s%d tasks left", FLAGS_verbose ? "\n" : kSkOverwriteLine, pending);
|
|
if (failed > 0) {
|
|
status.appendf(", %d failed", failed);
|
|
}
|
|
if (FLAGS_verbose) {
|
|
status.appendf("\t%5dms %s", timeMs, name.c_str());
|
|
}
|
|
SkDebugf("%s", status.c_str());
|
|
}
|
|
|
|
void Reporter::fail(SkString msg) {
|
|
sk_atomic_inc(&fFailed);
|
|
|
|
SkAutoMutexAcquire writer(&fMutex);
|
|
fFailures.push_back(msg);
|
|
}
|
|
|
|
void Reporter::getFailures(SkTArray<SkString>* failures) const {
|
|
SkAutoMutexAcquire reader(&fMutex);
|
|
*failures = fFailures;
|
|
}
|
|
|
|
} // namespace DM
|