c0bd9f9fe5
Current strategy: everything from the top
Things to look at first are the manual changes:
- added tools/rewrite_includes.py
- removed -Idirectives from BUILD.gn
- various compile.sh simplifications
- tweak tools/embed_resources.py
- update gn/find_headers.py to write paths from the top
- update gn/gn_to_bp.py SkUserConfig.h layout
so that #include "include/config/SkUserConfig.h" always
gets the header we want.
No-Presubmit: true
Change-Id: I73a4b181654e0e38d229bc456c0d0854bae3363e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209706
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
111 lines
3.0 KiB
C++
111 lines
3.0 KiB
C++
/*
|
|
* Copyright 2014 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "tests/Test.h"
|
|
|
|
#include "include/core/SkPictureRecorder.h"
|
|
#include "include/core/SkShader.h"
|
|
#include "include/core/SkSurface.h"
|
|
#include "src/core/SkRecord.h"
|
|
#include "src/core/SkRecorder.h"
|
|
#include "src/core/SkRecords.h"
|
|
|
|
#define COUNT(T) + 1
|
|
static const int kRecordTypes = SK_RECORD_TYPES(COUNT);
|
|
#undef COUNT
|
|
|
|
// Tallies the types of commands it sees into a histogram.
|
|
class Tally {
|
|
public:
|
|
Tally() { sk_bzero(&fHistogram, sizeof(fHistogram)); }
|
|
|
|
template <typename T>
|
|
void operator()(const T&) { ++fHistogram[T::kType]; }
|
|
|
|
template <typename T>
|
|
int count() const { return fHistogram[T::kType]; }
|
|
|
|
void apply(const SkRecord& record) {
|
|
for (int i = 0; i < record.count(); i++) {
|
|
record.visit(i, *this);
|
|
}
|
|
}
|
|
|
|
private:
|
|
int fHistogram[kRecordTypes];
|
|
};
|
|
|
|
DEF_TEST(Recorder, r) {
|
|
SkRecord record;
|
|
SkRecorder recorder(&record, 1920, 1080);
|
|
|
|
recorder.drawRect(SkRect::MakeWH(10, 10), SkPaint());
|
|
|
|
Tally tally;
|
|
tally.apply(record);
|
|
REPORTER_ASSERT(r, 1 == tally.count<SkRecords::DrawRect>());
|
|
}
|
|
|
|
// Regression test for leaking refs held by optional arguments.
|
|
DEF_TEST(Recorder_RefLeaking, r) {
|
|
// We use SaveLayer to test:
|
|
// - its SkRect argument is optional and SkRect is POD. Just testing that that works.
|
|
// - its SkPaint argument is optional and SkPaint is not POD. The bug was here.
|
|
|
|
SkRect bounds = SkRect::MakeWH(320, 240);
|
|
SkPaint paint;
|
|
paint.setShader(SkShaders::Empty());
|
|
|
|
REPORTER_ASSERT(r, paint.getShader()->unique());
|
|
{
|
|
SkRecord record;
|
|
SkRecorder recorder(&record, 1920, 1080);
|
|
recorder.saveLayer(&bounds, &paint);
|
|
REPORTER_ASSERT(r, !paint.getShader()->unique());
|
|
}
|
|
REPORTER_ASSERT(r, paint.getShader()->unique());
|
|
}
|
|
|
|
DEF_TEST(Recorder_drawImage_takeReference, reporter) {
|
|
|
|
sk_sp<SkImage> image;
|
|
{
|
|
auto surface(SkSurface::MakeRasterN32Premul(100, 100));
|
|
surface->getCanvas()->clear(SK_ColorGREEN);
|
|
image = surface->makeImageSnapshot();
|
|
}
|
|
{
|
|
SkRecord record;
|
|
SkRecorder recorder(&record, 100, 100);
|
|
|
|
// DrawImage is supposed to take a reference
|
|
recorder.drawImage(image, 0, 0);
|
|
REPORTER_ASSERT(reporter, !image->unique());
|
|
|
|
Tally tally;
|
|
tally.apply(record);
|
|
|
|
REPORTER_ASSERT(reporter, 1 == tally.count<SkRecords::DrawImage>());
|
|
}
|
|
REPORTER_ASSERT(reporter, image->unique());
|
|
|
|
{
|
|
SkRecord record;
|
|
SkRecorder recorder(&record, 100, 100);
|
|
|
|
// DrawImageRect is supposed to take a reference
|
|
recorder.drawImageRect(image, SkRect::MakeWH(100, 100), nullptr);
|
|
REPORTER_ASSERT(reporter, !image->unique());
|
|
|
|
Tally tally;
|
|
tally.apply(record);
|
|
|
|
REPORTER_ASSERT(reporter, 1 == tally.count<SkRecords::DrawImageRect>());
|
|
}
|
|
REPORTER_ASSERT(reporter, image->unique());
|
|
}
|