31954bf23f
https://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-copy-initialization.html Finds local variable declarations that are initialized using the copy constructor of a non-trivially-copyable type but it would suffice to obtain a const reference. The check is only applied if it is safe to replace the copy by a const reference. This is the case when the variable is const qualified or when it is only used as a const, i.e. only const methods or operators are invoked on it, or it is used as const reference or value argument in constructors or function calls. Change-Id: I1261410deccd8ea64e85edec53fbd5360940e587 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/308759 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
108 lines
3.9 KiB
C++
108 lines
3.9 KiB
C++
/*
|
|
* Copyright 2016 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
// This is a GPU-backend specific test.
|
|
|
|
#include "tests/Test.h"
|
|
|
|
#include "include/gpu/GrDirectContext.h"
|
|
#include "src/gpu/GrContextPriv.h"
|
|
#include "src/gpu/GrProxyProvider.h"
|
|
#include "src/gpu/GrRecordingContextPriv.h"
|
|
#include "src/gpu/GrRenderTargetProxy.h"
|
|
#include "src/gpu/GrResourceProvider.h"
|
|
#include "src/gpu/GrSurfaceProxy.h"
|
|
#include "src/gpu/GrTexture.h"
|
|
#include "src/gpu/GrTextureProxy.h"
|
|
#include "tests/TestUtils.h"
|
|
|
|
static const int kWidthHeight = 128;
|
|
|
|
static sk_sp<GrTextureProxy> make_deferred(GrRecordingContext* rContext) {
|
|
GrProxyProvider* proxyProvider = rContext->priv().proxyProvider();
|
|
const GrCaps* caps = rContext->priv().caps();
|
|
|
|
const GrBackendFormat format = caps->getDefaultBackendFormat(GrColorType::kRGBA_8888,
|
|
GrRenderable::kYes);
|
|
return proxyProvider->createProxy(format, {kWidthHeight, kWidthHeight}, GrRenderable::kYes, 1,
|
|
GrMipmapped::kNo, SkBackingFit::kApprox, SkBudgeted::kYes,
|
|
GrProtected::kNo);
|
|
}
|
|
|
|
static sk_sp<GrTextureProxy> make_wrapped(GrRecordingContext* rContext) {
|
|
GrProxyProvider* proxyProvider = rContext->priv().proxyProvider();
|
|
|
|
return proxyProvider->testingOnly_createInstantiatedProxy(
|
|
{kWidthHeight, kWidthHeight}, GrColorType::kRGBA_8888, GrRenderable::kYes, 1,
|
|
SkBackingFit::kExact, SkBudgeted::kNo, GrProtected::kNo);
|
|
}
|
|
|
|
DEF_GPUTEST_FOR_RENDERING_CONTEXTS(ProxyRefTest, reporter, ctxInfo) {
|
|
auto dContext = ctxInfo.directContext();
|
|
GrResourceProvider* resourceProvider = dContext->priv().resourceProvider();
|
|
|
|
for (auto make : { make_deferred, make_wrapped }) {
|
|
// An extra ref
|
|
{
|
|
sk_sp<GrTextureProxy> proxy((*make)(dContext));
|
|
if (proxy) {
|
|
sk_sp<GrTextureProxy> extraRef(proxy); // NOLINT(performance-unnecessary-copy-initialization)
|
|
|
|
int backingRefs = proxy->isInstantiated() ? 1 : -1;
|
|
|
|
CheckSingleThreadedProxyRefs(reporter, proxy.get(), 2, backingRefs);
|
|
|
|
proxy->instantiate(resourceProvider);
|
|
|
|
CheckSingleThreadedProxyRefs(reporter, proxy.get(), 2, 1);
|
|
}
|
|
CheckSingleThreadedProxyRefs(reporter, proxy.get(), 1, 1);
|
|
}
|
|
|
|
// Multiple normal refs
|
|
{
|
|
sk_sp<GrTextureProxy> proxy((*make)(dContext));
|
|
if (proxy.get()) {
|
|
proxy->ref();
|
|
proxy->ref();
|
|
|
|
int backingRefs = proxy->isInstantiated() ? 1 : -1;
|
|
|
|
CheckSingleThreadedProxyRefs(reporter, proxy.get(), 3, backingRefs);
|
|
|
|
proxy->instantiate(resourceProvider);
|
|
|
|
CheckSingleThreadedProxyRefs(reporter, proxy.get(), 3, 1);
|
|
|
|
proxy->unref();
|
|
proxy->unref();
|
|
}
|
|
CheckSingleThreadedProxyRefs(reporter, proxy.get(), 1, 1);
|
|
}
|
|
|
|
// Continue using (reffing) proxy after instantiation
|
|
{
|
|
sk_sp<GrTextureProxy> proxy((*make)(dContext));
|
|
if (proxy) {
|
|
sk_sp<GrTextureProxy> firstExtraRef(proxy); // NOLINT(performance-unnecessary-copy-initialization)
|
|
|
|
int backingRefs = proxy->isInstantiated() ? 1 : -1;
|
|
|
|
CheckSingleThreadedProxyRefs(reporter, proxy.get(), 2, backingRefs);
|
|
|
|
proxy->instantiate(resourceProvider);
|
|
|
|
CheckSingleThreadedProxyRefs(reporter, proxy.get(), 2, 1);
|
|
|
|
sk_sp<GrTextureProxy> secondExtraRef(proxy); // NOLINT(performance-unnecessary-copy-initialization)
|
|
CheckSingleThreadedProxyRefs(reporter, proxy.get(), 3, 1);
|
|
}
|
|
CheckSingleThreadedProxyRefs(reporter, proxy.get(), 1, 1);
|
|
}
|
|
}
|
|
}
|