678c1b019a
Fold alpha of a save layer call to the subsequent draw call paint, even when the draw call paint color is already non-opaque. Comparing the difference of the unoptimized and the optimized call pattern with all (layer alpha, draw alpha) combinations, this produces off-by-one pixels ~50% of the time. Reduces layers of current desk_carsvg.skp (recorded with cross-process picture image filters allowed) from 122 to 115. BUG=skia:3119 Review URL: https://codereview.chromium.org/840483005
172 lines
5.5 KiB
C++
172 lines
5.5 KiB
C++
/*
|
|
* Copyright 2014 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "Test.h"
|
|
#include "RecordTestUtils.h"
|
|
|
|
#include "SkRecord.h"
|
|
#include "SkRecordOpts.h"
|
|
#include "SkRecorder.h"
|
|
#include "SkRecords.h"
|
|
#include "SkXfermode.h"
|
|
|
|
static const int W = 1920, H = 1080;
|
|
|
|
DEF_TEST(RecordOpts_NoopDraw, r) {
|
|
SkRecord record;
|
|
SkRecorder recorder(&record, W, H);
|
|
|
|
recorder.drawRect(SkRect::MakeWH(200, 200), SkPaint());
|
|
recorder.drawRect(SkRect::MakeWH(300, 300), SkPaint());
|
|
recorder.drawRect(SkRect::MakeWH(100, 100), SkPaint());
|
|
|
|
record.replace<SkRecords::NoOp>(1); // NoOps should be allowed.
|
|
|
|
SkRecordNoopSaveRestores(&record);
|
|
|
|
REPORTER_ASSERT(r, 2 == count_instances_of_type<SkRecords::DrawRect>(record));
|
|
}
|
|
|
|
DEF_TEST(RecordOpts_SingleNoopSaveRestore, r) {
|
|
SkRecord record;
|
|
SkRecorder recorder(&record, W, H);
|
|
|
|
recorder.save();
|
|
recorder.clipRect(SkRect::MakeWH(200, 200));
|
|
recorder.restore();
|
|
|
|
SkRecordNoopSaveRestores(&record);
|
|
for (unsigned i = 0; i < 3; i++) {
|
|
assert_type<SkRecords::NoOp>(r, record, i);
|
|
}
|
|
}
|
|
|
|
DEF_TEST(RecordOpts_NoopSaveRestores, r) {
|
|
SkRecord record;
|
|
SkRecorder recorder(&record, W, H);
|
|
|
|
// The second pass will clean up this pair after the first pass noops all the innards.
|
|
recorder.save();
|
|
// A simple pointless pair of save/restore.
|
|
recorder.save();
|
|
recorder.restore();
|
|
|
|
// As long as we don't draw in there, everything is a noop.
|
|
recorder.save();
|
|
recorder.clipRect(SkRect::MakeWH(200, 200));
|
|
recorder.clipRect(SkRect::MakeWH(100, 100));
|
|
recorder.restore();
|
|
recorder.restore();
|
|
|
|
SkRecordNoopSaveRestores(&record);
|
|
for (unsigned index = 0; index < record.count(); index++) {
|
|
assert_type<SkRecords::NoOp>(r, record, index);
|
|
}
|
|
}
|
|
|
|
DEF_TEST(RecordOpts_SaveSaveLayerRestoreRestore, r) {
|
|
SkRecord record;
|
|
SkRecorder recorder(&record, W, H);
|
|
|
|
// A previous bug NoOp'd away the first 3 commands.
|
|
recorder.save();
|
|
recorder.saveLayer(NULL, NULL);
|
|
recorder.restore();
|
|
recorder.restore();
|
|
|
|
SkRecordNoopSaveRestores(&record);
|
|
switch (record.count()) {
|
|
case 4:
|
|
assert_type<SkRecords::Save> (r, record, 0);
|
|
assert_type<SkRecords::SaveLayer>(r, record, 1);
|
|
assert_type<SkRecords::Restore> (r, record, 2);
|
|
assert_type<SkRecords::Restore> (r, record, 3);
|
|
break;
|
|
case 2:
|
|
assert_type<SkRecords::SaveLayer>(r, record, 0);
|
|
assert_type<SkRecords::Restore> (r, record, 1);
|
|
break;
|
|
case 0:
|
|
break;
|
|
default:
|
|
REPORTER_ASSERT(r, false);
|
|
}
|
|
}
|
|
|
|
static void assert_savelayer_restore(skiatest::Reporter* r,
|
|
SkRecord* record,
|
|
unsigned i,
|
|
bool shouldBeNoOped) {
|
|
SkRecordNoopSaveLayerDrawRestores(record);
|
|
if (shouldBeNoOped) {
|
|
assert_type<SkRecords::NoOp>(r, *record, i);
|
|
assert_type<SkRecords::NoOp>(r, *record, i+2);
|
|
} else {
|
|
assert_type<SkRecords::SaveLayer>(r, *record, i);
|
|
assert_type<SkRecords::Restore>(r, *record, i+2);
|
|
}
|
|
}
|
|
|
|
DEF_TEST(RecordOpts_NoopSaveLayerDrawRestore, r) {
|
|
SkRecord record;
|
|
SkRecorder recorder(&record, W, H);
|
|
|
|
SkRect bounds = SkRect::MakeWH(100, 200);
|
|
SkRect draw = SkRect::MakeWH(50, 60);
|
|
|
|
SkPaint alphaOnlyLayerPaint, translucentLayerPaint, xfermodeLayerPaint;
|
|
alphaOnlyLayerPaint.setColor(0x03000000); // Only alpha.
|
|
translucentLayerPaint.setColor(0x03040506); // Not only alpha.
|
|
xfermodeLayerPaint.setXfermodeMode(SkXfermode::kDstIn_Mode); // Any effect will do.
|
|
|
|
SkPaint opaqueDrawPaint, translucentDrawPaint;
|
|
opaqueDrawPaint.setColor(0xFF020202); // Opaque.
|
|
translucentDrawPaint.setColor(0x0F020202); // Not opaque.
|
|
|
|
// SaveLayer/Restore removed: No paint = no point.
|
|
recorder.saveLayer(NULL, NULL);
|
|
recorder.drawRect(draw, opaqueDrawPaint);
|
|
recorder.restore();
|
|
assert_savelayer_restore(r, &record, 0, true);
|
|
|
|
// Bounds don't matter.
|
|
recorder.saveLayer(&bounds, NULL);
|
|
recorder.drawRect(draw, opaqueDrawPaint);
|
|
recorder.restore();
|
|
assert_savelayer_restore(r, &record, 3, true);
|
|
|
|
// TODO(mtklein): test case with null draw paint
|
|
|
|
// No change: layer paint isn't alpha-only.
|
|
recorder.saveLayer(NULL, &translucentLayerPaint);
|
|
recorder.drawRect(draw, opaqueDrawPaint);
|
|
recorder.restore();
|
|
assert_savelayer_restore(r, &record, 6, false);
|
|
|
|
// No change: layer paint has an effect.
|
|
recorder.saveLayer(NULL, &xfermodeLayerPaint);
|
|
recorder.drawRect(draw, opaqueDrawPaint);
|
|
recorder.restore();
|
|
assert_savelayer_restore(r, &record, 9, false);
|
|
|
|
// SaveLayer/Restore removed: we can fold in the alpha!
|
|
recorder.saveLayer(NULL, &alphaOnlyLayerPaint);
|
|
recorder.drawRect(draw, translucentDrawPaint);
|
|
recorder.restore();
|
|
assert_savelayer_restore(r, &record, 12, true);
|
|
|
|
// SaveLayer/Restore removed: we can fold in the alpha!
|
|
recorder.saveLayer(NULL, &alphaOnlyLayerPaint);
|
|
recorder.drawRect(draw, opaqueDrawPaint);
|
|
recorder.restore();
|
|
assert_savelayer_restore(r, &record, 15, true);
|
|
|
|
const SkRecords::DrawRect* drawRect = assert_type<SkRecords::DrawRect>(r, record, 16);
|
|
REPORTER_ASSERT(r, drawRect != NULL);
|
|
REPORTER_ASSERT(r, drawRect->paint.getColor() == 0x03020202);
|
|
}
|