AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
a9c187e5cc
skia2/tests/sksl
History
Ethan Nicholas a9c187e5cc Revert "Refactored SPIR-V RelaxedPrecision handling" 
This reverts commit 9e476b798f.

Reason for revert: Angry Vulkan bots

Original change's description:
> Refactored SPIR-V RelaxedPrecision handling
>
> The RelaxedPrecision decoration is now handled by nextId(), to make it
> easier to see all spots where a RelaxedPrecision decoration might be
> necessary. The goal of this initial refactor is not to actually fix the
> issues with RelaxedPrecision decorations, but rather to lay the
> groundwork for doing so in followup CLs.
>
> The initial intent of this change was to not affect the SPIR-V at all,
> saving modifications for followups, but there ended up being three kinds
> of changes to the output:
>
> 1. Doing things at nextId() time rather than later means some
> decorations move to an earlier spot in the output. This results in
> diffs, but should not cause any behavioral changes.
> 2. We were incorrectly tagging bools as RelaxedPrecision in some
> situations. By funneling things through fewer code paths, the refactor
> would have caused this to happen in even more situations, and the code
> responsible for the bug was being rewritten in this CL anyway, so it
> seemed worth just fixing the issue as part of this change.
> 3. Funneling things through fewer code paths ended up adding
> (correct) RelaxedPrecision modifiers to binary operations that had
> previously been missing them. It seemed better to just let it happen
> than to try to maintain bug-for-bug compatibility with the previous
> approach.
>
> Change-Id: Ia9654d6b5754e2c797e02226660cb618c9189b36
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/384318
> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com

Change-Id: I9ada728e5fd5798bc1179640560c2e6045b7efd1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/385158
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2021-03-15 21:24:47 +00:00
..
blend Revert "Refactored SPIR-V RelaxedPrecision handling" 2021-03-15 21:24:47 +00:00
errors Force global initializers to be constant expressions 2021-03-15 16:54:05 +00:00
folding Inline functions of the form 'return (expr)' only. 2021-03-15 19:46:46 +00:00
fp Add new style key information to several core effects 2021-03-04 14:49:07 +00:00
glsl Remove specific blend mode layout qualifiers 2021-02-23 15:45:55 +00:00
inliner Inline functions of the form 'return (expr)' only. 2021-03-15 19:46:46 +00:00
intrinsics Revert "Refactored SPIR-V RelaxedPrecision handling" 2021-03-15 21:24:47 +00:00
metal Remove extraneous line-breaks in generated GLSL/Metal code. 2021-03-12 18:39:57 +00:00
runtime Inline functions of the form 'return (expr)' only. 2021-03-15 19:46:46 +00:00
runtime_errors Optimize away no-op arithmetic in ConstantFolder. 2021-03-06 01:33:35 +00:00
shared Revert "Refactored SPIR-V RelaxedPrecision handling" 2021-03-15 21:24:47 +00:00
spirv Revert "Refactored SPIR-V RelaxedPrecision handling" 2021-03-15 21:24:47 +00:00
workarounds Remove extraneous line-breaks in generated GLSL/Metal code. 2021-03-12 18:39:57 +00:00
README.txt Migrate SkSL test inputs to the resources/ directory. 2021-01-22 18:57:29 +00:00

README.txt 

This directory contains skslc-compiled output from matching source files
in the /resources/sksl/ directory.