Go to file
commit-bot@chromium.org ab1c13864d Fix compilation with SK_ENABLE_INST_COUNT=1
Add INHERITED declarations to class declarations that prevent
compilation with the flag.

Remove SK_DEFINE_INST_COUNT from all class implementations.  Instead,
use function-local static variables in the reference count helper
classes to create the global instances to store the needed info. The
accessor functions are defined inline in the helper classes, so
definitions are not needed. The initialization point of the variables
should be as well defined as previously.

Remove SK_DECLARE_INST_COUNT_TEMPLATE and use SK_DECLARE_INST_COUNT
instead. This avoids possible future compilation errors further.

For SK_ENABLE_INST_COUNT=0 compilation, add an empty static member
function to all classes that use SK_DECLARE_INST_COUNT and
SK_DECLARE_INST_COUNT_ROOT macros. The function ensures that classes
contain public INHERITED typedef. This member function seems to be
compiled away. This shouĺd ensure that part of the compilation errors
are caught earlier.

Also adds DSK_DECLARE_INST_COUNT to few SkPDFDict subclasses.

R=robertphillips@google.com, richardlin@chromium.org, bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/98703002

git-svn-id: http://skia.googlecode.com/svn/trunk@12501 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 12:08:12 +00:00
animations first cut at a checkbox 2009-10-21 19:41:10 +00:00
bench Fix compilation with SK_ENABLE_INST_COUNT=1 2013-12-05 12:08:12 +00:00
debugger Convert debugger settings controls to combo boxes. 2013-11-21 15:37:29 +00:00
dm Missed this flag. imagemagnifier asserts without it. 2013-12-02 22:22:40 +00:00
expectations More rebaselines for https://codereview.chromium.org/102683002 2013-12-05 00:28:04 +00:00
experimental Remove SkPdfNativeDoc::tokenizerOfStream. 2013-12-03 16:15:31 +00:00
forth Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
gm Fix compilation with SK_ENABLE_INST_COUNT=1 2013-12-05 12:08:12 +00:00
gyp Fix compilation with SK_ENABLE_INST_COUNT=1 2013-12-05 12:08:12 +00:00
include Fix compilation with SK_ENABLE_INST_COUNT=1 2013-12-05 12:08:12 +00:00
platform_tools Reverting r12427 2013-12-02 13:50:38 +00:00
resources Bench baseline for mostly 0 image. 2013-09-25 21:42:12 +00:00
samplecode Fix compilation with SK_ENABLE_INST_COUNT=1 2013-12-05 12:08:12 +00:00
src Fix compilation with SK_ENABLE_INST_COUNT=1 2013-12-05 12:08:12 +00:00
tests Fix compilation with SK_ENABLE_INST_COUNT=1 2013-12-05 12:08:12 +00:00
third_party Remove the comments settings for vim tab width and expansion variables. 2013-12-02 22:23:03 +00:00
tools Force linking for skhello. 2013-12-04 18:34:58 +00:00
trybots_to_run/chrome Deleting the hardcoded list of compile bots in trybots_to_run. 2013-04-09 11:59:42 +00:00
.gitignore leading slash confuses non-git tools that read .gitignore, like ag 2013-07-30 17:23:01 +00:00
codereview.settings Removing blank lines from codereview.settings. 2013-02-26 16:01:21 +00:00
DEPS Reverting r12427 2013-12-02 13:50:38 +00:00
Doxyfile Pointing to http://skia-autogen.googlecode.com/svn/docs/html/index.html in Doxyfile 2012-07-03 11:35:07 +00:00
gyp_skia Fix ninja build on Android 2013-10-01 15:31:54 +00:00
gyp_skia.py Roll gyp deps from 1765 to 1796. 2013-11-21 18:11:14 +00:00
LICENSE Manually update copyright notices in files that defied the automated process 2011-07-28 14:24:55 +00:00
make.bat Make make.bat and gyp_skia work with VS 2012. 2013-05-07 19:31:20 +00:00
make.py Use SKIA_OUT variable in make.py 2013-07-23 15:45:50 +00:00
Makefile pathops work in progress 2013-11-01 17:36:03 +00:00
Makefile.old Replace GR_*_BUILD by their SK_BUILD_FOR_* equivalents. 2013-09-25 20:57:51 +00:00
OWNERS add root files from chrome 2013-08-13 19:11:15 +00:00
PRESUBMIT.py If any change is made to the public API then make sure there is an LGTM from an owner. 2013-08-12 14:51:20 +00:00
README whitespace commit to trigger buildbot 2011-07-15 14:11:58 +00:00
README.chromium add root files from chrome 2013-08-13 19:11:15 +00:00
skia.gyp Remove the comments settings for vim tab width and expansion variables. 2013-12-02 22:23:03 +00:00
whitespace.txt Refreshed mozilla,googleplus and wikipedia SKPs. Triggering rebuilds. 2013-12-03 14:51:00 +00:00

Skia is a complete 2D graphic library for drawing Text, Geometries, and Images.

See full details, and build instructions, at http://code.google.com/p/skia/wiki/DocRoot