b3b24538e0
An RLE bmp reports how many bytes it should contain. This number may be incorrect, or it may be a very large number. Previously, we buffered all bytes in a single allocation. Instead, use a fixed size buffer and only read what fits into the buffer. We already have code to refill the buffer if there is more data, so rely on that to keep reading. Choose an arbitrary size for the buffer. It is larger than the maximum possible number of bytes we need to read at once. Add a test with a test image that reports a very large number for the number of bytes it should contain. With the old method, we would allocate 4 gigs of memory to decode this image, which is unnecessary and may result in OOM. BUG=b/33251605 Change-Id: I6d66eace626002725f62237617140cab99ce42f3 Reviewed-on: https://skia-review.googlesource.com/7028 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Matt Sarett <msarett@google.com> |
||
|---|---|---|
| .. | ||
| b33251605.bmp | ||
| b33651913.bmp | ||
| ico_fuzz0.ico | ||
| ico_fuzz1.ico | ||
| ico_leak01.ico | ||
| int_overflow.ico | ||
| many-progressive-scans.jpg | ||
| mask-bmp-ico.ico | ||
| sigabort_favicon.ico | ||
| sigsegv_favicon_2.ico | ||
| sigsegv_favicon.ico | ||
| skbug3429.webp | ||
| skbug3442.webp | ||
| skbug5887.gif | ||
| skbug6046.gif | ||
