b58792947c
This looks like a no-op, because we're just moving flags from cflags_cc to cflags_objcc, and then removing cflags_cc from the compiler command. However: GN is very specific about which flags it expects to be used by the toolchain for each file type. It ONLY emits cflags_cc into ninja files if there is at least one C++ source file in the target. If we had a target that only contained .mm source files, cflags_cc would be empty and the various flags it contains would be missing. Note that ninja silently leaves undefined variables as empty, making this not obvious. Bug: skia:13272 Change-Id: I8d729699b1bd34b677ec1b657bc34111fa8db2a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/534763 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> |
||
|---|---|---|
| .. | ||
| BUILD.gn | ||