b7a1b5189d
https://skia-review.googlesource.com/c/189866 "SkWuffsCodec: Initialize memory when incomplete" made some buffer zero'ing conditional on a frame's dirty rectangle, which required moving the this->decodeFrame call earlier in onIncrementalDecode, since we can't know the dirty rectangle until after decodeFrame is called. However, moving that earlier meant that it was now earlier than the "sk_bzero(pixels.ptr + etc, etc)" call that zero-initialized the destination buffer that decodeFrame writes to. The actual pixel indexes that decodeFrame decodes are now overwritten by zeroes. That prior commit fixed the fuzzer-discovered bug, in that it no longer swizzles from uninitialized memory. Unfortunately, it's now often swizzling from all-zeroed memory, so that the decoding is incorrect. This commit moves the zero-ing to onStartIncrementalDecode, even earlier. The "dm --match Gif" tests are happy again. Bug: skia:8235 Change-Id: Iae993b7d9f45e1b375ed99f6cc86536091a92eba Reviewed-on: https://skia-review.googlesource.com/c/190941 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com> |
||
|---|---|---|
| animations | ||
| bench | ||
| bin | ||
| dm | ||
| docker | ||
| docs | ||
| example | ||
| experimental | ||
| fuzz | ||
| gm | ||
| gn | ||
| include | ||
| infra | ||
| modules | ||
| platform_tools | ||
| resources | ||
| samplecode | ||
| site | ||
| src | ||
| tests | ||
| third_party | ||
| tools | ||
| .clang-format | ||
| .clang-tidy | ||
| .gitignore | ||
| .gn | ||
| AUTHORS | ||
| BUILD.gn | ||
| codereview.settings | ||
| CONTRIBUTING | ||
| CQ_COMMITTERS | ||
| DEPS | ||
| Doxyfile | ||
| LICENSE | ||
| OWNERS | ||
| PRESUBMIT.py | ||
| public.bzl | ||
| README | ||
| README.chromium | ||
| whitespace.txt | ||
Skia is a complete 2D graphic library for drawing Text, Geometries, and Images. See full details, and build instructions, at https://skia.org.