skia2/modules/svg/include/SkSVGUse.h
Tyler Denniston 3df6c20a05 [svg] Fix <use> bounds calculation
Previously we were using fX and fY as the top left of the returned
bounds. We need instead to offset the referenced node's bounds by fX,
fY.

While I was here I updated the attribute parsing to the new form and
changed the type of fHref from SkSVGString to SkSVGIRI.

Change-Id: I4bfb91bca62e47f5dabfbb4aad48cbb301a7ea36
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/354118
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Tyler Denniston <tdenniston@google.com>
2021-01-14 21:35:58 +00:00

43 lines
1.2 KiB
C++

/*
* Copyright 2017 Google Inc.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
#ifndef SkSVGUse_DEFINED
#define SkSVGUse_DEFINED
#include "modules/svg/include/SkSVGTransformableNode.h"
#include "modules/svg/include/SkSVGTypes.h"
/**
* Implements support for <use> (reference) elements.
* (https://www.w3.org/TR/SVG11/struct.html#UseElement)
*/
class SkSVGUse final : public SkSVGTransformableNode {
public:
static sk_sp<SkSVGUse> Make() { return sk_sp<SkSVGUse>(new SkSVGUse()); }
void appendChild(sk_sp<SkSVGNode>) override;
SVG_ATTR(X , SkSVGLength, SkSVGLength(0))
SVG_ATTR(Y , SkSVGLength, SkSVGLength(0))
SVG_ATTR(Href, SkSVGIRI , SkSVGIRI())
protected:
bool onPrepareToRender(SkSVGRenderContext*) const override;
void onRender(const SkSVGRenderContext&) const override;
SkPath onAsPath(const SkSVGRenderContext&) const override;
SkRect onObjectBoundingBox(const SkSVGRenderContext&) const override;
private:
SkSVGUse();
bool parseAndSetAttribute(const char*, const char*) override;
using INHERITED = SkSVGTransformableNode;
};
#endif // SkSVGUse_DEFINED