AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
bc13605c62
skia2/infra/bots/assets
History
Leon Scroggins 2009c20309 Revert "Fix webp bug compositing alpha frames on opaque" 
This reverts commit 42bae8faa4.

Reason for revert: Breaking GMs. A more extensive fix is needed.

Original change's description:
> Fix webp bug compositing alpha frames on opaque
> 
> select_xform_alpha is used to determine how the color transform should
> handle alpha values. In a similar way, we're using it here to determine
> whether to premultiply pixels before blending them. In this case, the
> source is unpremul, so we should be premultiplying them, but since we
> are compositing on an opaque frame, the dst must be opaque and
> select_xform_alpha returns kOpaque. As a result, we do not premultiply
> (and even hint to the transform that the pixels are opaque). Since this
> all applies to the pre-blended pixels, we should not care that the dst
> is opaque. So drop the call to select_xform_alpha and just use the alpha
> type of the source. This matches the comment on the lines above.
> 
> Add the test image that failed (https://mathiasbynens.be/demo/animated-webp)
> 
> Change-Id: Ibd13c1f067bdf369ce1c882d4f6057aadccfa313
> Reviewed-on: https://skia-review.googlesource.com/71560
> Commit-Queue: Leon Scroggins <scroggo@google.com>
> Reviewed-by: Mike Klein <mtklein@chromium.org>

TBR=mtklein@chromium.org,scroggo@google.com

Change-Id: I6f535ff9b773a93e02a0358b830291594a6e738c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/71720
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2017-11-15 13:49:27 +00:00
..
android_ndk_darwin Upgrade android build (and infrastructure) to use ndk r15. 2017-06-27 16:32:15 +00:00
android_ndk_linux Upgrade android build (and infrastructure) to use ndk r15. 2017-06-27 16:32:15 +00:00
android_ndk_windows Upgrade android build (and infrastructure) to use ndk r15. 2017-06-27 16:32:15 +00:00
android_sdk Add Android SDK asset 2016-06-30 05:20:03 -07:00
armhf_sysroot Add recipe to build for Asus Flip Chromebook 2017-04-05 11:39:04 +00:00
cast_toolchain Enable chromecast gpu perf 2017-05-24 20:30:05 +00:00
chromebook_arm_gles Add Pixelbook to tree 2017-11-02 13:36:21 +00:00
chromebook_x86_64_gles Add Pixelbook to tree 2017-11-02 13:36:21 +00:00
clang_linux Add coverage related binaries to clang_linux asset 2017-09-29 20:20:24 +00:00
clang_win Add clang_win asset 2017-07-31 19:14:53 +00:00
emscripten_sdk [WASM] Add POC compile bot for WebAssembly 2017-09-21 18:24:43 +00:00
go Update to go 1.9 2017-10-18 20:15:55 +00:00
linux_vulkan_intel_driver_debug Update mesa drivers to 17.04 2017-04-21 16:39:06 +00:00
linux_vulkan_intel_driver_release Update mesa drivers to 17.04 2017-04-21 16:39:06 +00:00
linux_vulkan_sdk Add Vulkan SDK for Linux asset 2017-01-18 14:54:10 +00:00
protoc [infra] Add protoc asset 2017-07-19 18:23:36 +00:00
scripts Add CIPD asset for Valgrind 2017-05-31 19:41:13 +00:00
skimage Revert "Fix webp bug compositing alpha frames on opaque" 2017-11-15 13:49:27 +00:00
skp Update SKP version 2017-11-12 13:24:56 +00:00
svg Create new set of SVGs 2017-08-16 15:42:55 +00:00
valgrind Upgrade Valgrind to 3.13.0. 2017-08-07 13:58:00 +00:00
win_toolchain Start including 'winrt' in Windows toolchain 2017-01-10 18:28:58 +00:00
win_vulkan_sdk Add Vulkan SDK for Linux asset 2017-01-18 14:54:10 +00:00
__init__.py Add asset management scripts 2016-06-15 12:07:42 -07:00
asset_utils_test.py Disable flaky GSStoreTest 2016-12-12 17:01:43 +00:00
asset_utils.py [WASM] Add POC compile bot for WebAssembly 2017-09-21 18:24:43 +00:00
assets.py Fix assets.py args 2016-11-09 15:23:34 +00:00
README.md Add asset management scripts 2016-06-15 12:07:42 -07:00

README.md

Assets

This directory contains tooling for managing assets used by the bots. The primary entry point is assets.py, which allows a user to add, remove, upload, and download assets.

Assets are stored in Google Storage, named for their version number.

Individual Assets

Each asset has its own subdirectory with the following contents:

  • VERSION: The current version number of the asset.
  • download.py: Convenience script for downloading the current version of the asset.
  • upload.py: Convenience script for uploading a new version of the asset.
  • [optional] create.py: Script which creates the asset, implemented by the user.
  • [optional] create_and_upload.py: Convenience script which combines create.py with upload.py.

Examples

Add a new asset and upload an initial version.

$ infra/bots/assets/assets.py add myasset
Creating asset in infra/bots/assets/myasset
Creating infra/bots/assets/myasset/download.py
Creating infra/bots/assets/myasset/upload.py
Creating infra/bots/assets/myasset/common.py
Add script to automate creation of this asset? (y/n) n
$ infra/bots/assets/myasset/upload.py -t ${MY_ASSET_LOCATION}
$ git commit

Add an asset whose creation can be automated.

$ infra/bots/assets/assets.py add myasset
Add script to automate creation of this asset? (y/n) y
$ vi infra/bots/assets/myasset/create.py
(implement the create_asset function)
$ infra/bots/assets/myasset/create_and_upload.py
$ git commit