bc537fac4b
can_truncate_to_fixed_for_decal() is correct to check that we can step fx by dx count-1 times without overflowing, but as written we actually step count times, and sometimes the final fx does overflow. Fuzzers equipped with UBSAN have noticed. There's no real bug here, as we ignore that final fx, but we can step carefully to avoid this with very little impact on code complexity or performance. Bug: chromium:951264 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Change-Id: I5446dbdffdc5fa873c843c26654894bd79202971 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/207921 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Auto-Submit: Mike Klein <mtklein@google.com> |
||
|---|---|---|
| animations | ||
| bench | ||
| bin | ||
| dm | ||
| docker | ||
| docs/examples | ||
| example | ||
| experimental | ||
| fuzz | ||
| gm | ||
| gn | ||
| include | ||
| infra | ||
| modules | ||
| platform_tools | ||
| resources | ||
| samplecode | ||
| site | ||
| src | ||
| tests | ||
| third_party | ||
| tools | ||
| .clang-format | ||
| .clang-tidy | ||
| .gitignore | ||
| .gn | ||
| AUTHORS | ||
| BUILD.gn | ||
| codereview.settings | ||
| CONTRIBUTING | ||
| CQ_COMMITTERS | ||
| DEPS | ||
| LICENSE | ||
| OWNERS | ||
| PRESUBMIT.py | ||
| public.bzl | ||
| README | ||
| README.chromium | ||
| whitespace.txt | ||
Skia is a complete 2D graphic library for drawing Text, Geometries, and Images. See full details, and build instructions, at https://skia.org.