AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
c1a249d1dc
skia2/tests/sksl/errors/golden
History
Brian Osman 8dbdf23f31 Remove two uses of setModifiersHandle 
As a prelude to going back to sharing global data (safely), we want to
eliminate as much mutation of shared state as possible. The special
cases for global variable declaration were unnecessary, so just remove
them. The editing of main's parameters immediately after they were
created is also unnecessary - just hoist the logic up so we create the
variables correctly in the first place.

There is still one use, related to invocation ID. That's more
complicated (?), so leaving it as a separate CL.

Change-Id: Ia3dad78dd5a634273b2e2239368be7adaff65f38
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325661
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
2020-10-13 14:15:18 +00:00
..
ArgumentCountMismatch.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
ArgumentMismatch.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
ArgumentModifiers.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
AssignmentTypeMismatch.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
BadCaps.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
BadFieldAccess.glsl Add unit tests for assignment and invalid field access. 2020-09-25 21:42:22 +00:00
BadIndex.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
BadModifiers.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
BinaryTypeCoercion.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
BinaryTypeMismatch.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
BitShiftFloat.glsl SkSL: Only allow bitwise ops on integral types 2020-09-17 18:12:34 +00:00
BitShiftFloatMatrix.glsl SkSL: Only allow bitwise ops on integral types 2020-09-17 18:12:34 +00:00
BitShiftFloatVector.glsl SkSL: Only allow bitwise ops on integral types 2020-09-17 18:12:34 +00:00
BreakOutsideLoop.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
CallNonFunction.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
CanExitWithoutReturningValue.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
ConstructorArgumentCount.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
ConstructorTypeMismatch.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
ContinueOutsideLoop.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
DivideByZero.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
DoTypeMismatch.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
DuplicateFunction.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
DuplicateOutput.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
DuplicateSymbol.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
EnumValueMustBeConstInt.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
ErrorsInDeadCode.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
FieldAfterRuntimeArray.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
ForTypeMismatch.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
GenericArgumentMismatch.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
GrBadIn.cpp Migrate several SkSLFP tests to golden outputs. 2020-09-17 16:46:18 +00:00
GrBadIn.h Migrate several SkSLFP tests to golden outputs. 2020-09-17 16:46:18 +00:00
GrBothExplicitReturnAndSkOutColor.cpp
GrBothExplicitReturnAndSkOutColor.h Create blank SkSL test files for Ninja's benefit. 2020-09-15 16:00:30 +00:00
GrCannotReturnWithSkOutColor.cpp Migrate several SkSLFP tests to golden outputs. 2020-09-17 16:46:18 +00:00
GrCannotReturnWithSkOutColor.h Migrate several SkSLFP tests to golden outputs. 2020-09-17 16:46:18 +00:00
GrMainParameterWrongType.cpp Remove two uses of setModifiersHandle 2020-10-13 14:15:18 +00:00
GrMainParameterWrongType.h Remove two uses of setModifiersHandle 2020-10-13 14:15:18 +00:00
GrMainTooManyParameters.cpp Remove two uses of setModifiersHandle 2020-10-13 14:15:18 +00:00
GrMainTooManyParameters.h Remove two uses of setModifiersHandle 2020-10-13 14:15:18 +00:00
GrNoFragmentProcessorConstruction.cpp Migrate several SkSLFP tests to golden outputs. 2020-09-17 16:46:18 +00:00
GrNoFragmentProcessorConstruction.h Migrate several SkSLFP tests to golden outputs. 2020-09-17 16:46:18 +00:00
GrNoFragmentProcessorExpressions.cpp Migrate several SkSLFP tests to golden outputs. 2020-09-17 16:46:18 +00:00
GrNoFragmentProcessorExpressions.h Migrate several SkSLFP tests to golden outputs. 2020-09-17 16:46:18 +00:00
GrNoFragmentProcessorLocals.cpp Migrate several SkSLFP tests to golden outputs. 2020-09-17 16:46:18 +00:00
GrNoFragmentProcessorLocals.h Migrate several SkSLFP tests to golden outputs. 2020-09-17 16:46:18 +00:00
GrNoFragmentProcessorParams.cpp Migrate several SkSLFP tests to golden outputs. 2020-09-17 16:46:18 +00:00
GrNoFragmentProcessorParams.h Migrate several SkSLFP tests to golden outputs. 2020-09-17 16:46:18 +00:00
GrNoFragmentProcessorReturn.cpp Migrate several SkSLFP tests to golden outputs. 2020-09-17 16:46:18 +00:00
GrNoFragmentProcessorReturn.h Migrate several SkSLFP tests to golden outputs. 2020-09-17 16:46:18 +00:00
IfTypeMismatch.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
InterfaceBlockScope.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
InterfaceBlockStorageModifiers.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
InvalidAssignment.glsl Disallow assignment to unfoldable ternaries in SkSL. 2020-09-25 21:26:40 +00:00
InvalidOutParams.glsl Fix crash with invalid out parameters. 2020-09-23 20:36:17 +00:00
InvalidUnary.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
ModifiersInStruct.glsl Reject struct vardecls with modifiers. 2020-10-09 22:34:23 +00:00
OpenArray.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
ReturnDifferentType.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
ReturnFromVoid.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
ReturnMissingValue.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
ReturnTypeMismatch.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
SpuriousFloat.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
StaticIfTest.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
StaticSwitchConditionalBreak.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
StaticSwitchTest.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
SwitchDuplicateCase.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
SwitchTypes.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
SwizzleConstantOutput.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
SwizzleMatrix.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
SwizzleOnlyLiterals.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
SwizzleOutOfBounds.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
SwizzleTooManyComponents.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
TernaryMismatch.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
UndefinedFunction.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
UndefinedSymbol.glsl
Unreachable.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
UnsupportedGLSLIdentifiers.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
UseWithoutInitializeArrayIndex.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
UseWithoutInitializeBinaryExpr.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
UseWithoutInitializeDeadIf.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
UseWithoutInitializeDeadSwitch.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
UseWithoutInitializeReturnValue.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
UseWithoutInitializeVarDecl.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
UsingInvalidValue.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00
WhileTypeMismatch.glsl Migrate SkSL error tests to golden outputs. 2020-09-18 13:46:17 +00:00