58b5a54707
There apparently were other tests that had similar issues and this fix is much better and is more future proof. Change-Id: I4835c7e5772b9e70249a69255aae8808be172eef Reviewed-on: https://skia-review.googlesource.com/c/skia/+/282681 Commit-Queue: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
129 lines
3.9 KiB
C++
129 lines
3.9 KiB
C++
/*
|
|
* Copyright 2017 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
// This is a GPU-backend specific test.
|
|
|
|
#include "tests/Test.h"
|
|
|
|
using namespace sk_gpu_test;
|
|
|
|
#include "tools/gpu/GrContextFactory.h"
|
|
|
|
#include "include/core/SkCanvas.h"
|
|
#include "include/core/SkSurface.h"
|
|
#include "src/core/SkImagePriv.h"
|
|
|
|
static bool surface_is_expected_color(SkSurface* surf, const SkImageInfo& ii, SkColor color) {
|
|
SkBitmap bm;
|
|
bm.allocPixels(ii);
|
|
|
|
surf->readPixels(bm, 0, 0);
|
|
|
|
for (int y = 0; y < bm.height(); ++y) {
|
|
for (int x = 0; x < bm.width(); ++x) {
|
|
if (bm.getColor(x, y) != color) {
|
|
return false;
|
|
}
|
|
}
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
static void basic_test(skiatest::Reporter* reporter, GrContext* context) {
|
|
const SkImageInfo ii = SkImageInfo::Make(64, 64, kN32_SkColorType, kPremul_SkAlphaType);
|
|
|
|
SkBitmap bm;
|
|
bm.allocPixels(ii);
|
|
|
|
SkCanvas bmCanvas(bm);
|
|
bmCanvas.clear(SK_ColorRED);
|
|
|
|
// We start off with the raster image being all red.
|
|
sk_sp<SkImage> img = SkMakeImageFromRasterBitmap(bm, kNever_SkCopyPixelsMode);
|
|
|
|
sk_sp<SkSurface> gpuSurface = SkSurface::MakeRenderTarget(context, SkBudgeted::kYes, ii);
|
|
SkCanvas* canvas = gpuSurface->getCanvas();
|
|
|
|
// w/o pinning - the gpu draw always reflects the current state of the underlying bitmap
|
|
{
|
|
canvas->drawImage(img, 0, 0);
|
|
REPORTER_ASSERT(reporter, surface_is_expected_color(gpuSurface.get(), ii, SK_ColorRED));
|
|
|
|
bmCanvas.clear(SK_ColorGREEN);
|
|
|
|
canvas->drawImage(img, 0, 0);
|
|
REPORTER_ASSERT(reporter, surface_is_expected_color(gpuSurface.get(), ii, SK_ColorGREEN));
|
|
}
|
|
|
|
// w/ pinning - the gpu draw is stuck at the pinned state
|
|
{
|
|
SkImage_pinAsTexture(img.get(), context); // pin at blue
|
|
|
|
canvas->drawImage(img, 0, 0);
|
|
REPORTER_ASSERT(reporter, surface_is_expected_color(gpuSurface.get(), ii, SK_ColorGREEN));
|
|
|
|
bmCanvas.clear(SK_ColorBLUE);
|
|
|
|
canvas->drawImage(img, 0, 0);
|
|
REPORTER_ASSERT(reporter, surface_is_expected_color(gpuSurface.get(), ii, SK_ColorGREEN));
|
|
|
|
SkImage_unpinAsTexture(img.get(), context);
|
|
}
|
|
|
|
// once unpinned local changes will be picked up
|
|
{
|
|
canvas->drawImage(img, 0, 0);
|
|
REPORTER_ASSERT(reporter, surface_is_expected_color(gpuSurface.get(), ii, SK_ColorBLUE));
|
|
}
|
|
}
|
|
|
|
// Deleting the context while there are still pinned images shouldn't result in a crash.
|
|
static void cleanup_test(skiatest::Reporter* reporter) {
|
|
|
|
const SkImageInfo ii = SkImageInfo::Make(64, 64, kN32_SkColorType, kPremul_SkAlphaType);
|
|
|
|
SkBitmap bm;
|
|
bm.allocPixels(ii);
|
|
|
|
SkCanvas bmCanvas(bm);
|
|
bmCanvas.clear(SK_ColorRED);
|
|
|
|
for (int i = 0; i < GrContextFactory::kContextTypeCnt; ++i) {
|
|
GrContextFactory::ContextType ctxType = (GrContextFactory::ContextType) i;
|
|
|
|
{
|
|
sk_sp<SkImage> img;
|
|
GrContext* context = nullptr;
|
|
|
|
{
|
|
GrContextFactory testFactory;
|
|
ContextInfo info = testFactory.getContextInfo(ctxType);
|
|
context = info.grContext();
|
|
if (!context) {
|
|
continue;
|
|
}
|
|
|
|
img = SkMakeImageFromRasterBitmap(bm, kNever_SkCopyPixelsMode);
|
|
if (!SkImage_pinAsTexture(img.get(), context)) {
|
|
continue;
|
|
}
|
|
}
|
|
|
|
// The GrContext used to pin the image is gone at this point!
|
|
// "context" isn't technically used in this call but it can't be null!
|
|
// We don't really want to support this use case but it currently happens.
|
|
SkImage_unpinAsTexture(img.get(), context);
|
|
}
|
|
}
|
|
}
|
|
|
|
DEF_GPUTEST_FOR_RENDERING_CONTEXTS(PinnedImageTest, reporter, ctxInfo) {
|
|
basic_test(reporter, ctxInfo.grContext());
|
|
cleanup_test(reporter);
|
|
}
|