AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
c1ce2f7966
skia2/tools/sk_app
History
Brian Salomon c1ce2f7966 Revert "Redefine the meaning of sample counts in GPU backend." 
This reverts commit 48825b11ad.

Reason for revert: nanobench

Original change's description:
> Redefine the meaning of sample counts in GPU backend.
> 
> Old: 0  -> nonMSAA
>      1+ -> MSAA
> 
> New:
>      0  -> error/unsupported
>      1  -> nonMSAA
>      2+ -> MSAA
> 
> We still allow 0 to mean nonMSAA in three sets of public APIs for backwards compatibility:
> 
> 1) SkSurface factories
> 2) GrBackendRenderTarget constructors
> 3) GrCaps::getSampleCnt()'s requestedCount parameter
> 
> However, we immediately clamp to 1 and treat 0 as invalid/non-renderable internally.
> 
> This also changes the behavior when using a large sample count. We now fail in that case rather than using the largest sample available sample count. GrCaps::getSampleCount() will return 0 in this case.
> 
> 
> Bug: skia:
> Change-Id: Ida22c6b22c1365e563c9046b611e88bf5eb3ff33
> Reviewed-on: https://skia-review.googlesource.com/101560
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=egdaniel@google.com,bsalomon@google.com

Change-Id: Ic257619a8a5ee9ac15419ecf10259e42daed7f82
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/102662
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-02-01 18:34:40 +00:00
..
android Revert "Redefine the meaning of sample counts in GPU backend." 2018-02-01 18:34:40 +00:00
ios Revert "Redefine the meaning of sample counts in GPU backend." 2018-02-01 18:34:40 +00:00
mac Revert "Redefine the meaning of sample counts in GPU backend." 2018-02-01 18:34:40 +00:00
unix Revert "Redefine the meaning of sample counts in GPU backend." 2018-02-01 18:34:40 +00:00
win Revert "Redefine the meaning of sample counts in GPU backend." 2018-02-01 18:34:40 +00:00
Application.h
CommandSet.cpp eliminate SK_BUILD_FOR_WIN32 2018-01-26 19:52:04 +00:00
CommandSet.h
DisplayParams.h Revert "Redefine the meaning of sample counts in GPU backend." 2018-02-01 18:34:40 +00:00
GLWindowContext.cpp Revert "Redefine the meaning of sample counts in GPU backend." 2018-02-01 18:34:40 +00:00
GLWindowContext.h
RasterWindowContext.h
VulkanWindowContext.cpp Update SkSurface MakeFromBackend* factories to take an SkColorType. 2017-12-19 18:41:36 +00:00
VulkanWindowContext.h Update SkSurface MakeFromBackend* factories to take an SkColorType. 2017-12-19 18:41:36 +00:00
Window.cpp Revert "Redefine the meaning of sample counts in GPU backend." 2018-02-01 18:34:40 +00:00
Window.h Move stats code to new layer (with configurable list of timers) 2017-12-20 16:59:04 +00:00
WindowContext.h Revert "Redefine the meaning of sample counts in GPU backend." 2018-02-01 18:34:40 +00:00