f2eb5ab780
Both shader and gradient_shader write matrices to the flatten stream. However, they were just calling write(&matrix, sizeof(SkMatrix)) and the matrix can contain lazily-computed function ptrs as part of its internal cache. Thus two matrices that are logically the same may write different bytes. This is a problem because picture relies on flattening objects and then using the flatten stream as a key into its cache. This matrix-write bug effectively kills the effectiveness of the cache for shaders. The fix is to write proper read/write functions for matrix (and region btw). These call through to the existing low-level flatten routines (which just write into a memory ptr). git-svn-id: http://skia.googlecode.com/svn/trunk@1290 2bbb7eff-a529-9590-31e7-b0007b416f81
192 lines
5.5 KiB
C++
192 lines
5.5 KiB
C++
/*
|
|
* Copyright (C) 2006 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#ifndef SkFlattenable_DEFINED
|
|
#define SkFlattenable_DEFINED
|
|
|
|
#include "SkRefCnt.h"
|
|
#include "SkBitmap.h"
|
|
#include "SkReader32.h"
|
|
#include "SkTDArray.h"
|
|
#include "SkWriter32.h"
|
|
|
|
class SkFlattenableReadBuffer;
|
|
class SkFlattenableWriteBuffer;
|
|
class SkString;
|
|
|
|
/** \class SkFlattenable
|
|
|
|
SkFlattenable is the base class for objects that need to be flattened
|
|
into a data stream for either transport or as part of the key to the
|
|
font cache.
|
|
*/
|
|
class SK_API SkFlattenable : public SkRefCnt {
|
|
public:
|
|
typedef SkFlattenable* (*Factory)(SkFlattenableReadBuffer&);
|
|
|
|
SkFlattenable() {}
|
|
|
|
/** Implement this to return a factory function pointer that can be called
|
|
to recreate your class given a buffer (previously written to by your
|
|
override of flatten().
|
|
*/
|
|
virtual Factory getFactory() = 0;
|
|
/** Override this to write data specific to your subclass into the buffer,
|
|
being sure to call your super-class' version first. This data will later
|
|
be passed to your Factory function, returned by getFactory().
|
|
*/
|
|
virtual void flatten(SkFlattenableWriteBuffer&);
|
|
|
|
/** Set the string to describe the sublass and return true. If this is not
|
|
overridden, ignore the string param and return false.
|
|
*/
|
|
virtual bool toDumpString(SkString*) const;
|
|
|
|
static Factory NameToFactory(const char name[]);
|
|
static const char* FactoryToName(Factory);
|
|
static void Register(const char name[], Factory);
|
|
|
|
class Registrar {
|
|
public:
|
|
Registrar(const char name[], Factory factory) {
|
|
SkFlattenable::Register(name, factory);
|
|
}
|
|
};
|
|
|
|
protected:
|
|
SkFlattenable(SkFlattenableReadBuffer&) {}
|
|
};
|
|
|
|
// helpers for matrix and region
|
|
|
|
class SkMatrix;
|
|
extern void SkReadMatrix(SkReader32*, SkMatrix*);
|
|
extern void SkWriteMatrix(SkWriter32*, const SkMatrix&);
|
|
|
|
class SkRegion;
|
|
extern void SkReadRegion(SkReader32*, SkRegion*);
|
|
extern void SkWriteRegion(SkWriter32*, const SkRegion&);
|
|
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
|
|
class SkTypeface;
|
|
|
|
class SkFlattenableReadBuffer : public SkReader32 {
|
|
public:
|
|
SkFlattenableReadBuffer();
|
|
explicit SkFlattenableReadBuffer(const void* data);
|
|
SkFlattenableReadBuffer(const void* data, size_t size);
|
|
|
|
void setRefCntArray(SkRefCnt* array[], int count) {
|
|
fRCArray = array;
|
|
fRCCount = count;
|
|
}
|
|
|
|
void setTypefaceArray(SkTypeface* array[], int count) {
|
|
fTFArray = array;
|
|
fTFCount = count;
|
|
}
|
|
|
|
void setFactoryPlayback(SkFlattenable::Factory array[], int count) {
|
|
fFactoryArray = array;
|
|
fFactoryCount = count;
|
|
}
|
|
|
|
SkTypeface* readTypeface();
|
|
SkRefCnt* readRefCnt();
|
|
void* readFunctionPtr();
|
|
SkFlattenable* readFlattenable();
|
|
|
|
private:
|
|
SkRefCnt** fRCArray;
|
|
int fRCCount;
|
|
|
|
SkTypeface** fTFArray;
|
|
int fTFCount;
|
|
|
|
SkFlattenable::Factory* fFactoryArray;
|
|
int fFactoryCount;
|
|
|
|
typedef SkReader32 INHERITED;
|
|
};
|
|
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
|
|
#include "SkPtrRecorder.h"
|
|
|
|
/**
|
|
* Subclass of SkTPtrSet specialed to call ref() and unref() when the
|
|
* base class's incPtr() and decPtr() are called. This makes it a valid owner
|
|
* of each ptr, which is released when the set is reset or destroyed.
|
|
*/
|
|
class SkRefCntSet : public SkTPtrSet<SkRefCnt*> {
|
|
public:
|
|
virtual ~SkRefCntSet();
|
|
|
|
protected:
|
|
// overrides
|
|
virtual void incPtr(void*);
|
|
virtual void decPtr(void*);
|
|
};
|
|
|
|
class SkFactorySet : public SkTPtrSet<SkFlattenable::Factory> {};
|
|
|
|
class SkFlattenableWriteBuffer : public SkWriter32 {
|
|
public:
|
|
SkFlattenableWriteBuffer(size_t minSize);
|
|
virtual ~SkFlattenableWriteBuffer();
|
|
|
|
void writeTypeface(SkTypeface*);
|
|
void writeRefCnt(SkRefCnt*);
|
|
void writeFunctionPtr(void*);
|
|
void writeFlattenable(SkFlattenable* flattenable);
|
|
|
|
SkRefCntSet* getTypefaceRecorder() const { return fTFSet; }
|
|
SkRefCntSet* setTypefaceRecorder(SkRefCntSet*);
|
|
|
|
SkRefCntSet* getRefCntRecorder() const { return fRCSet; }
|
|
SkRefCntSet* setRefCntRecorder(SkRefCntSet*);
|
|
|
|
SkFactorySet* getFactoryRecorder() const { return fFactorySet; }
|
|
SkFactorySet* setFactoryRecorder(SkFactorySet*);
|
|
|
|
enum Flags {
|
|
kCrossProcess_Flag = 0x01
|
|
};
|
|
Flags getFlags() const { return fFlags; }
|
|
void setFlags(Flags flags) { fFlags = flags; }
|
|
|
|
bool isCrossProcess() const { return (fFlags & kCrossProcess_Flag) != 0; }
|
|
|
|
bool persistBitmapPixels() const {
|
|
return (fFlags & kCrossProcess_Flag) != 0;
|
|
}
|
|
|
|
bool persistTypeface() const { return (fFlags & kCrossProcess_Flag) != 0; }
|
|
|
|
private:
|
|
Flags fFlags;
|
|
SkRefCntSet* fTFSet;
|
|
SkRefCntSet* fRCSet;
|
|
SkFactorySet* fFactorySet;
|
|
|
|
typedef SkWriter32 INHERITED;
|
|
};
|
|
|
|
#endif
|
|
|