skia2/tools/sk_app
John Stiles f61ee1ecac Fix assertion in ImGui::NewFrame if getBackbufferSurface returns null.
Previously, in cases where the backbuffer was null, we would call layer->onPrePaint (which starts a new frame with ImGui::NewFrame) without a matching call to layer->onPaint (which calls ImGui::Render). This causes the ImGui frame counter to go out of sync, which leads to an assertion when NewFrame is next called.

(The backbuffer can become null if unsupported settings are used, e.g. a MSAA setting above the maximum supported by your GPU.)

Change-Id: I1b8fbaa1bf78ad5e1aa41fd04eda6be206c952b4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/283196
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2020-04-13 14:16:52 +00:00
..
android Revert "Revert "Revert "Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots"""" 2020-03-20 17:11:58 +00:00
ios Revert "Revert "Revert "Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots"""" 2020-03-20 17:11:58 +00:00
mac Remove the dependency on Dawn's SwapChainUtils. 2020-04-09 20:31:30 +00:00
unix Revert "Revert "Revert "Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots"""" 2020-03-20 17:11:58 +00:00
win Remove the dependency on Dawn's SwapChainUtils. 2020-04-09 20:31:30 +00:00
Application.h
CommandSet.cpp Remove SkMaxScalar and SkMinScalar 2020-02-06 15:43:22 +00:00
CommandSet.h tools/skui: put all enums in a common namespace 2019-08-29 15:39:32 +00:00
DawnWindowContext.cpp Roll Dawn and add dependencies 2020-03-30 18:52:06 +00:00
DawnWindowContext.h Update dawn.h -> webgpu.h, dawn_cpp.h -> webgpu_cpp.h. 2019-12-04 15:24:16 +00:00
DisplayParams.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
GLWindowContext.cpp Fix GL MSAA support in Mac Viewer. 2019-07-11 22:31:43 +00:00
GLWindowContext.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
MetalWindowContext.h Use LazyProxy to set up Metal swapchain. 2019-10-18 14:04:41 +00:00
MetalWindowContext.mm Use LazyProxy to set up Metal swapchain. 2019-10-18 14:04:41 +00:00
RasterWindowContext.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
VulkanWindowContext.cpp Remove SkTMin and SkTMax 2020-02-07 18:40:09 +00:00
VulkanWindowContext.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
Window.cpp Fix assertion in ImGui::NewFrame if getBackbufferSurface returns null. 2020-04-13 14:16:52 +00:00
Window.h Stop including SkCanvas.h from GrTypesPriv.h 2020-03-30 20:43:34 +00:00
WindowContext.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00