2122f40c4b
Previously, REPORTER_ASSERT/ERRORF relied on a helper function named `reporter_string` which papered over zero-argument and one-argument messages (where one-argument messages are assumed to ignore printf formatting rules entirely, and just forward the message as-is). Replacing this helper with a direct call to `SkStringPrintf` allows the compiler to check format arguments for correctness, but sacrifices the one-argument special case. In practice the one-argument special case was very rarely used, so it's not a significant sacrifice, and this did uncover several real errors in assertion format strings (including some cases where the wrong number of arguments was passed). Change-Id: I4378c43b16fd8fdbf4c78d849a9f2f0a254f7abc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/506617 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> |
||
|---|---|---|
| .. | ||
| editor | ||
| include | ||
| samples | ||
| src | ||
| tests | ||
| BUILD.gn | ||
| sktext.gni | ||