6b87df2997
Since we just 'define' them, but not attribute anything to them, like '1' for example, cpp expands it to nothing and that breaks the "#if" clauses. To fix that, uses "#if defined(...)" which will correctly check if your macro name was defined or not. BUG=skia:2850 TEST=make most R=robertphillips@google.com Review URL: https://codereview.chromium.org/628763005 |
||
---|---|---|
.. | ||
diff_viewer.js | ||
generate_pmetric_tables.py | ||
README | ||
SkCLImageDiffer.cpp | ||
SkCLImageDiffer.h | ||
SkDiffContext.cpp | ||
SkDiffContext.h | ||
SkDifferentPixelsMetric_cpu.cpp | ||
SkDifferentPixelsMetric_opencl.cpp | ||
SkDifferentPixelsMetric.h | ||
SkImageDiffer.cpp | ||
SkImageDiffer.h | ||
skpdiff_main.cpp | ||
skpdiff_server.py | ||
skpdiff_util.cpp | ||
skpdiff_util.h | ||
SkPMetric.cpp | ||
SkPMetric.h | ||
SkPMetricUtil_generated.h | ||
viewer_style.css | ||
viewer.html |
Some example invocations: Note how the asterisks are not expanded inside the shell because of the quotes out/Debug/skpdiff -p \ "/usr/local/google/home/zachr/Downloads/gm/*_8888.png" \ "/usr/local/google/home/zachr/Downloads/gm/*_gpu.png" out/Debug/skpdiff --differs different_pixels -f \ "/usr/local/google/home/zachr/Downloads/diffs/baseline" \ "/usr/local/google/home/zachr/Downloads/diffs/test"