c1c3c6d70d
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-suspicious-string-compare.html Find suspicious usage of runtime string comparison functions. This check is valid in C and C++. Checks for calls with implicit comparator and proposed to explicitly add it: if (strcmp(...)) // Implicitly compare to zero if (!strcmp(...)) // Won't warn if (strcmp(...) != 0) // Won't warn Checks that compare function results (i,e, strcmp) are compared to valid constant. The resulting value is < 0 when lower than, > 0 when greater than, == 0 when equals. A common mistake is to compare the result to 1 or -1: if (strcmp(...) == -1) // Incorrect usage of the returned value. Additionally, the check warns if the results value is implicitly cast to a suspicious non-integer type. It’s happening when the returned value is used in a wrong context: if (strcmp(...) < 0.) // Incorrect usage of the returned value. Change-Id: I001b88d06cc4f3eb5846103885be675f9b78e126 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310761 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
168 lines
5.4 KiB
C++
168 lines
5.4 KiB
C++
/*
|
|
* Copyright 2011 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "include/core/SkBitmap.h"
|
|
#include "include/core/SkCanvas.h"
|
|
#include "include/core/SkColor.h"
|
|
#include "include/core/SkPaint.h"
|
|
#include "include/core/SkPoint.h"
|
|
#include "include/core/SkRect.h"
|
|
#include "include/core/SkScalar.h"
|
|
#include "include/core/SkTypes.h"
|
|
#include "src/core/SkEdgeClipper.h"
|
|
#include "src/core/SkLineClipper.h"
|
|
#include "tests/Test.h"
|
|
|
|
#include <cstring>
|
|
|
|
static void test_hairclipping(skiatest::Reporter* reporter) {
|
|
SkBitmap bm;
|
|
bm.allocN32Pixels(4, 4);
|
|
bm.eraseColor(SK_ColorWHITE);
|
|
|
|
SkPaint paint;
|
|
paint.setAntiAlias(true);
|
|
|
|
SkCanvas canvas(bm);
|
|
canvas.clipRect(SkRect::MakeWH(SkIntToScalar(4), SkIntToScalar(2)));
|
|
canvas.drawLine(1.5f, 1.5f,
|
|
3.5f, 3.5f, paint);
|
|
|
|
/**
|
|
* We had a bug where we misinterpreted the bottom of the clip, and
|
|
* would draw another pixel (to the right in this case) on the same
|
|
* last scanline. i.e. we would draw to [2,1], even though this hairline
|
|
* should just draw to [1,1], [2,2], [3,3] modulo the clip.
|
|
*
|
|
* The result of this entire draw should be that we only draw to [1,1]
|
|
*
|
|
* Fixed in rev. 3366
|
|
*/
|
|
for (int y = 0; y < 4; ++y) {
|
|
for (int x = 0; x < 4; ++x) {
|
|
bool nonWhite = (1 == y) && (1 == x);
|
|
SkPMColor c = *bm.getAddr32(x, y);
|
|
if (nonWhite) {
|
|
REPORTER_ASSERT(reporter, 0xFFFFFFFF != c);
|
|
} else {
|
|
REPORTER_ASSERT(reporter, 0xFFFFFFFF == c);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
static void test_edgeclipper() {
|
|
SkEdgeClipper clipper(false);
|
|
|
|
const SkPoint pts[] = {
|
|
{ 3.0995476e+010f, 42.929779f },
|
|
{ -3.0995163e+010f, 51.050385f },
|
|
{ -3.0995157e+010f, 51.050392f },
|
|
{ -3.0995134e+010f, 51.050400f },
|
|
};
|
|
|
|
const SkRect clip = { 0, 0, SkIntToScalar(300), SkIntToScalar(200) };
|
|
|
|
// this should not assert, even though our choppers do a poor numerical
|
|
// job when computing their t values.
|
|
// http://code.google.com/p/skia/issues/detail?id=444
|
|
clipper.clipCubic(pts, clip);
|
|
}
|
|
|
|
static void test_intersectline(skiatest::Reporter* reporter) {
|
|
static const SkScalar L = 0;
|
|
static const SkScalar T = 0;
|
|
static const SkScalar R = SkIntToScalar(100);
|
|
static const SkScalar B = SkIntToScalar(100);
|
|
static const SkScalar CX = SkScalarHalf(L + R);
|
|
static const SkScalar CY = SkScalarHalf(T + B);
|
|
static const SkRect gR = { L, T, R, B };
|
|
|
|
size_t i;
|
|
SkPoint dst[2];
|
|
|
|
static const SkPoint gEmpty[] = {
|
|
// sides
|
|
{ L, CY }, { L - 10, CY },
|
|
{ R, CY }, { R + 10, CY },
|
|
{ CX, T }, { CX, T - 10 },
|
|
{ CX, B }, { CX, B + 10 },
|
|
// corners
|
|
{ L, T }, { L - 10, T - 10 },
|
|
{ L, B }, { L - 10, B + 10 },
|
|
{ R, T }, { R + 10, T - 10 },
|
|
{ R, B }, { R + 10, B + 10 },
|
|
};
|
|
for (i = 0; i < SK_ARRAY_COUNT(gEmpty); i += 2) {
|
|
bool valid = SkLineClipper::IntersectLine(&gEmpty[i], gR, dst);
|
|
if (valid) {
|
|
SkDebugf("----- [%d] %g %g -> %g %g\n", i/2, dst[0].fX, dst[0].fY, dst[1].fX, dst[1].fY);
|
|
}
|
|
REPORTER_ASSERT(reporter, !valid);
|
|
}
|
|
|
|
static const SkPoint gFull[] = {
|
|
// diagonals, chords
|
|
{ L, T }, { R, B },
|
|
{ L, B }, { R, T },
|
|
{ CX, T }, { CX, B },
|
|
{ L, CY }, { R, CY },
|
|
{ CX, T }, { R, CY },
|
|
{ CX, T }, { L, CY },
|
|
{ L, CY }, { CX, B },
|
|
{ R, CY }, { CX, B },
|
|
// edges
|
|
{ L, T }, { L, B },
|
|
{ R, T }, { R, B },
|
|
{ L, T }, { R, T },
|
|
{ L, B }, { R, B },
|
|
};
|
|
for (i = 0; i < SK_ARRAY_COUNT(gFull); i += 2) {
|
|
bool valid = SkLineClipper::IntersectLine(&gFull[i], gR, dst);
|
|
if (!valid || 0 != memcmp(&gFull[i], dst, sizeof(dst))) {
|
|
SkDebugf("++++ [%d] %g %g -> %g %g\n", i/2, dst[0].fX, dst[0].fY, dst[1].fX, dst[1].fY);
|
|
}
|
|
REPORTER_ASSERT(reporter, valid && !memcmp(&gFull[i], dst, sizeof(dst)));
|
|
}
|
|
|
|
static const SkPoint gPartial[] = {
|
|
{ L - 10, CY }, { CX, CY }, { L, CY }, { CX, CY },
|
|
{ CX, T - 10 }, { CX, CY }, { CX, T }, { CX, CY },
|
|
{ R + 10, CY }, { CX, CY }, { R, CY }, { CX, CY },
|
|
{ CX, B + 10 }, { CX, CY }, { CX, B }, { CX, CY },
|
|
// extended edges
|
|
{ L, T - 10 }, { L, B + 10 }, { L, T }, { L, B },
|
|
{ R, T - 10 }, { R, B + 10 }, { R, T }, { R, B },
|
|
{ L - 10, T }, { R + 10, T }, { L, T }, { R, T },
|
|
{ L - 10, B }, { R + 10, B }, { L, B }, { R, B },
|
|
};
|
|
for (i = 0; i < SK_ARRAY_COUNT(gPartial); i += 4) {
|
|
bool valid = SkLineClipper::IntersectLine(&gPartial[i], gR, dst);
|
|
if (!valid || 0 != memcmp(&gPartial[i+2], dst, sizeof(dst))) {
|
|
SkDebugf("++++ [%d] %g %g -> %g %g\n", i/2, dst[0].fX, dst[0].fY, dst[1].fX, dst[1].fY);
|
|
}
|
|
REPORTER_ASSERT(reporter, valid &&
|
|
!memcmp(&gPartial[i+2], dst, sizeof(dst)));
|
|
}
|
|
|
|
}
|
|
|
|
DEF_TEST(Clipper, reporter) {
|
|
test_intersectline(reporter);
|
|
test_edgeclipper();
|
|
test_hairclipping(reporter);
|
|
}
|
|
|
|
DEF_TEST(LineClipper_skbug_7981, r) {
|
|
SkPoint src[] = {{ -5.77698802E+17f, -1.81758057E+23f}, {38127, 2}};
|
|
SkPoint dst[2];
|
|
SkRect clip = { -32767, -32767, 32767, 32767 };
|
|
|
|
SkLineClipper::IntersectLine(src, clip, dst);
|
|
}
|
|
|