5f0e82204e
This should fix the failing paint-command-log-nodes.html layout test. BUG=406425 R=tomhudson@chromium.org Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/501533003
112 lines
3.1 KiB
C++
112 lines
3.1 KiB
C++
/*
|
|
* Copyright 2014 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "Test.h"
|
|
|
|
#include "SkPictureRecorder.h"
|
|
#include "SkRecord.h"
|
|
#include "SkRecorder.h"
|
|
#include "SkRecords.h"
|
|
#include "SkShader.h"
|
|
|
|
#define COUNT(T) + 1
|
|
static const int kRecordTypes = SK_RECORD_TYPES(COUNT);
|
|
#undef COUNT
|
|
|
|
// Tallies the types of commands it sees into a histogram.
|
|
class Tally {
|
|
public:
|
|
Tally() { sk_bzero(&fHistogram, sizeof(fHistogram)); }
|
|
|
|
template <typename T>
|
|
void operator()(const T&) { ++fHistogram[T::kType]; }
|
|
|
|
template <typename T>
|
|
int count() const { return fHistogram[T::kType]; }
|
|
|
|
void apply(const SkRecord& record) {
|
|
for (unsigned i = 0; i < record.count(); i++) {
|
|
record.visit<void>(i, *this);
|
|
}
|
|
}
|
|
|
|
private:
|
|
int fHistogram[kRecordTypes];
|
|
};
|
|
|
|
DEF_TEST(Recorder, r) {
|
|
SkRecord record;
|
|
SkRecorder recorder(&record, 1920, 1080);
|
|
|
|
recorder.drawRect(SkRect::MakeWH(10, 10), SkPaint());
|
|
|
|
Tally tally;
|
|
tally.apply(record);
|
|
REPORTER_ASSERT(r, 1 == tally.count<SkRecords::DrawRect>());
|
|
}
|
|
|
|
// All of Skia will work fine without support for comment groups, but
|
|
// Chrome's inspector can break. This serves as a simple regression test.
|
|
DEF_TEST(Recorder_CommentGroups, r) {
|
|
SkRecord record;
|
|
SkRecorder recorder(&record, 1920, 1080);
|
|
|
|
recorder.beginCommentGroup("test");
|
|
recorder.addComment("foo", "bar");
|
|
recorder.addComment("baz", "quux");
|
|
recorder.endCommentGroup();
|
|
|
|
Tally tally;
|
|
tally.apply(record);
|
|
|
|
REPORTER_ASSERT(r, 1 == tally.count<SkRecords::BeginCommentGroup>());
|
|
REPORTER_ASSERT(r, 2 == tally.count<SkRecords::AddComment>());
|
|
REPORTER_ASSERT(r, 1 == tally.count<SkRecords::EndCommentGroup>());
|
|
}
|
|
|
|
// Regression test for leaking refs held by optional arguments.
|
|
DEF_TEST(Recorder_RefLeaking, r) {
|
|
// We use SaveLayer to test:
|
|
// - its SkRect argument is optional and SkRect is POD. Just testing that that works.
|
|
// - its SkPaint argument is optional and SkPaint is not POD. The bug was here.
|
|
|
|
SkRect bounds = SkRect::MakeWH(320, 240);
|
|
SkPaint paint;
|
|
paint.setShader(SkShader::CreateEmptyShader())->unref();
|
|
|
|
REPORTER_ASSERT(r, paint.getShader()->unique());
|
|
{
|
|
SkRecord record;
|
|
SkRecorder recorder(&record, 1920, 1080);
|
|
recorder.saveLayer(&bounds, &paint);
|
|
REPORTER_ASSERT(r, !paint.getShader()->unique());
|
|
}
|
|
REPORTER_ASSERT(r, paint.getShader()->unique());
|
|
}
|
|
|
|
DEF_TEST(Recorder_RefPictures, r) {
|
|
SkAutoTUnref<SkPicture> pic;
|
|
|
|
{
|
|
SkPictureRecorder pr;
|
|
SkCanvas* canvas = pr.beginRecording(100, 100);
|
|
canvas->drawColor(SK_ColorRED);
|
|
pic.reset(pr.endRecording());
|
|
}
|
|
REPORTER_ASSERT(r, pic->unique());
|
|
|
|
{
|
|
SkRecord record;
|
|
SkRecorder recorder(&record, 100, 100);
|
|
recorder.drawPicture(pic);
|
|
// the recorder should now also be an owner
|
|
REPORTER_ASSERT(r, !pic->unique());
|
|
}
|
|
// the recorder destructor should have released us (back to unique)
|
|
REPORTER_ASSERT(r, pic->unique());
|
|
}
|