skia2/tests/DrawTextTest.cpp
mtklein 875e13ca09 Simplify mask/clip intersection, making sure to explicitly check for an empty mask.
Previously we were only asserting the mask wasn't empty, which isn't necessarily true when we're given pathological float coordinates like +Inf or NaN.

A local run of nanobench --match text_ was not able to show this is faster or slower.

This patch fixed this first Chrome bug on my desktop, and the second is probably a dupe.
BUG=chromium:619378,chromium:613912

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2073873002

Review-Url: https://codereview.chromium.org/2073873002
2016-06-19 05:28:33 -07:00

134 lines
4.5 KiB
C++

/*
* Copyright 2011 Google Inc.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
#include "SkBitmap.h"
#include "SkCanvas.h"
#include "SkColor.h"
#include "SkPaint.h"
#include "SkPoint.h"
#include "SkRect.h"
#include "SkSurface.h"
#include "SkTypes.h"
#include "Test.h"
#include <math.h>
static const SkColor bgColor = SK_ColorWHITE;
static void create(SkBitmap* bm, SkIRect bound) {
bm->allocN32Pixels(bound.width(), bound.height());
}
static void drawBG(SkCanvas* canvas) {
canvas->drawColor(bgColor);
}
/** Assumes that the ref draw was completely inside ref canvas --
implies that everything outside is "bgColor".
Checks that all overlap is the same and that all non-overlap on the
ref is "bgColor".
*/
static bool compare(const SkBitmap& ref, const SkIRect& iref,
const SkBitmap& test, const SkIRect& itest)
{
const int xOff = itest.fLeft - iref.fLeft;
const int yOff = itest.fTop - iref.fTop;
SkAutoLockPixels alpRef(ref);
SkAutoLockPixels alpTest(test);
for (int y = 0; y < test.height(); ++y) {
for (int x = 0; x < test.width(); ++x) {
SkColor testColor = test.getColor(x, y);
int refX = x + xOff;
int refY = y + yOff;
SkColor refColor;
if (refX >= 0 && refX < ref.width() &&
refY >= 0 && refY < ref.height())
{
refColor = ref.getColor(refX, refY);
} else {
refColor = bgColor;
}
if (refColor != testColor) {
return false;
}
}
}
return true;
}
DEF_TEST(DrawText, reporter) {
SkPaint paint;
paint.setColor(SK_ColorGRAY);
paint.setTextSize(SkIntToScalar(20));
SkIRect drawTextRect = SkIRect::MakeWH(64, 64);
SkBitmap drawTextBitmap;
create(&drawTextBitmap, drawTextRect);
SkCanvas drawTextCanvas(drawTextBitmap);
SkIRect drawPosTextRect = SkIRect::MakeWH(64, 64);
SkBitmap drawPosTextBitmap;
create(&drawPosTextBitmap, drawPosTextRect);
SkCanvas drawPosTextCanvas(drawPosTextBitmap);
// Two test cases "A" for the normal path through the code, and " " to check the
// early return path.
const char* cases[] = {"A", " "};
for (auto c : cases) {
for (float offsetY = 0.0f; offsetY < 1.0f; offsetY += (1.0f / 16.0f)) {
for (float offsetX = 0.0f; offsetX < 1.0f; offsetX += (1.0f / 16.0f)) {
SkPoint point = SkPoint::Make(25.0f + offsetX,
25.0f + offsetY);
for (int align = 0; align < SkPaint::kAlignCount; ++align) {
paint.setTextAlign(static_cast<SkPaint::Align>(align));
for (unsigned int flags = 0; flags < (1 << 3); ++flags) {
static const unsigned int antiAliasFlag = 1;
static const unsigned int subpixelFlag = 1 << 1;
static const unsigned int lcdFlag = 1 << 2;
paint.setAntiAlias(SkToBool(flags & antiAliasFlag));
paint.setSubpixelText(SkToBool(flags & subpixelFlag));
paint.setLCDRenderText(SkToBool(flags & lcdFlag));
// Test: drawText and drawPosText draw the same.
drawBG(&drawTextCanvas);
drawTextCanvas.drawText(c, 1, point.fX, point.fY, paint);
drawBG(&drawPosTextCanvas);
drawPosTextCanvas.drawPosText(c, 1, &point, paint);
REPORTER_ASSERT(reporter,
compare(drawTextBitmap, drawTextRect,
drawPosTextBitmap, drawPosTextRect));
}
}
}
}
}
}
// Test drawing text at some unusual coordinates.
// We measure success by not crashing or asserting.
DEF_TEST(DrawText_weirdCoordinates, r) {
auto surface = SkSurface::MakeRasterN32Premul(10,10);
auto canvas = surface->getCanvas();
SkScalar oddballs[] = { 0.0f, (float)INFINITY, (float)NAN, 34359738368.0f };
for (auto x : oddballs) {
canvas->drawText("a", 1, +x, 0.0f, SkPaint());
canvas->drawText("a", 1, -x, 0.0f, SkPaint());
}
for (auto y : oddballs) {
canvas->drawText("a", 1, 0.0f, +y, SkPaint());
canvas->drawText("a", 1, 0.0f, -y, SkPaint());
}
}