1b35256f11
This reverts commit aaee31f18c.
Reason for revert: possible valgrind leak
Original change's description:
> Rm readPixels from GrSurface & move read/writeSurfacePixels to GrContextPriv (take 2)
>
> This is in service of: https://skia-review.googlesource.com/c/11125/ (Add parallel proxyID to StencilOps & RenderTargetOpList) where I want a better choke point for texture creation to improve discard handling.
>
> This is a reland of: https://skia-review.googlesource.com/c/11200/ (Rm readPixels from GrSurface & move read/writeSurfacePixels to GrContextPriv)
>
> Change-Id: Icd0a90d2beb483dc24ed87c3bace9c817019e148
> Reviewed-on: https://skia-review.googlesource.com/11326
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
>
TBR=bsalomon@google.com,robertphillips@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: Ia0b92bf6402cb5f9607310d356f43bff2e3e75eb
Reviewed-on: https://skia-review.googlesource.com/11361
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
102 lines
3.9 KiB
C++
102 lines
3.9 KiB
C++
/*
|
|
* Copyright 2014 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
/*
|
|
* This is a straightforward test of floating point textures, which are
|
|
* supported on some platforms. As of right now, this test only supports
|
|
* 32 bit floating point textures, and indeed floating point test values
|
|
* have been selected to require 32 bits of precision and full IEEE conformance
|
|
*/
|
|
|
|
#include <float.h>
|
|
#include "Test.h"
|
|
|
|
#if SK_SUPPORT_GPU
|
|
#include "GrContext.h"
|
|
#include "GrResourceProvider.h"
|
|
#include "GrTexture.h"
|
|
#include "SkHalf.h"
|
|
|
|
static const int DEV_W = 100, DEV_H = 100;
|
|
static const SkIRect DEV_RECT = SkIRect::MakeWH(DEV_W, DEV_H);
|
|
|
|
template <typename T>
|
|
void runFPTest(skiatest::Reporter* reporter, GrContext* context,
|
|
T min, T max, T epsilon, T maxInt, int arraySize, GrPixelConfig config) {
|
|
if (0 != arraySize % 4) {
|
|
REPORT_FAILURE(reporter, "(0 != arraySize % 4)",
|
|
SkString("arraySize must be divisible by 4."));
|
|
return;
|
|
}
|
|
|
|
SkTDArray<T> controlPixelData, readBuffer;
|
|
controlPixelData.setCount(arraySize);
|
|
readBuffer.setCount(arraySize);
|
|
|
|
for (int i = 0; i < arraySize; i += 4) {
|
|
controlPixelData[i + 0] = min;
|
|
controlPixelData[i + 1] = max;
|
|
controlPixelData[i + 2] = epsilon;
|
|
controlPixelData[i + 3] = maxInt;
|
|
}
|
|
|
|
for (int origin = 0; origin < 2; ++origin) {
|
|
GrSurfaceDesc desc;
|
|
desc.fFlags = kRenderTarget_GrSurfaceFlag;
|
|
desc.fWidth = DEV_W;
|
|
desc.fHeight = DEV_H;
|
|
desc.fConfig = config;
|
|
desc.fOrigin = 0 == origin ? kTopLeft_GrSurfaceOrigin : kBottomLeft_GrSurfaceOrigin;
|
|
sk_sp<GrTexture> fpTexture(context->resourceProvider()->createTexture(
|
|
desc, SkBudgeted::kNo, controlPixelData.begin(), 0));
|
|
// Floating point textures are NOT supported everywhere
|
|
if (nullptr == fpTexture) {
|
|
continue;
|
|
}
|
|
REPORTER_ASSERT(reporter,
|
|
fpTexture->readPixels(0, 0, DEV_W, DEV_H, desc.fConfig, readBuffer.begin(), 0));
|
|
REPORTER_ASSERT(reporter,
|
|
0 == memcmp(readBuffer.begin(), controlPixelData.begin(), readBuffer.bytes()));
|
|
}
|
|
}
|
|
|
|
static const int RGBA32F_CONTROL_ARRAY_SIZE = DEV_W * DEV_H * 4;
|
|
static const float kMaxIntegerRepresentableInSPFloatingPoint = 16777216; // 2 ^ 24
|
|
|
|
DEF_GPUTEST_FOR_RENDERING_CONTEXTS(FloatingPointTextureTest, reporter, ctxInfo) {
|
|
runFPTest<float>(reporter, ctxInfo.grContext(), FLT_MIN, FLT_MAX, FLT_EPSILON,
|
|
kMaxIntegerRepresentableInSPFloatingPoint,
|
|
RGBA32F_CONTROL_ARRAY_SIZE, kRGBA_float_GrPixelConfig);
|
|
}
|
|
|
|
static const int RG32F_CONTROL_ARRAY_SIZE = DEV_W * DEV_H * 2;
|
|
|
|
DEF_GPUTEST_FOR_RENDERING_CONTEXTS(FloatingPointTextureTest_RG, reporter, ctxInfo) {
|
|
runFPTest<float>(reporter, ctxInfo.grContext(), FLT_MIN, FLT_MAX, FLT_EPSILON,
|
|
kMaxIntegerRepresentableInSPFloatingPoint,
|
|
RG32F_CONTROL_ARRAY_SIZE, kRG_float_GrPixelConfig);
|
|
}
|
|
|
|
static const int HALF_ALPHA_CONTROL_ARRAY_SIZE = DEV_W * DEV_H * 1 /*alpha-only*/;
|
|
static const SkHalf kMaxIntegerRepresentableInHalfFloatingPoint = 0x6800; // 2 ^ 11
|
|
|
|
DEF_GPUTEST_FOR_RENDERING_CONTEXTS(HalfFloatAlphaTextureTest, reporter, ctxInfo) {
|
|
runFPTest<SkHalf>(reporter, ctxInfo.grContext(), SK_HalfMin, SK_HalfMax, SK_HalfEpsilon,
|
|
kMaxIntegerRepresentableInHalfFloatingPoint,
|
|
HALF_ALPHA_CONTROL_ARRAY_SIZE, kAlpha_half_GrPixelConfig);
|
|
}
|
|
|
|
static const int HALF_RGBA_CONTROL_ARRAY_SIZE = DEV_W * DEV_H * 4 /*RGBA*/;
|
|
|
|
DEF_GPUTEST_FOR_RENDERING_CONTEXTS(HalfFloatRGBATextureTest, reporter, ctxInfo) {
|
|
runFPTest<SkHalf>(reporter, ctxInfo.grContext(), SK_HalfMin, SK_HalfMax, SK_HalfEpsilon,
|
|
kMaxIntegerRepresentableInHalfFloatingPoint,
|
|
HALF_RGBA_CONTROL_ARRAY_SIZE, kRGBA_half_GrPixelConfig);
|
|
}
|
|
|
|
#endif
|