be1084b5d9
This reverts commit1eea1ea8c1
. Reason for revert: fixed implicit copy cons Original change's description: > Revert "Write pixels goes through GrRenderTask system." > > This reverts commit27efe6cb1e
. > > Reason for revert: wasm compile > > Original change's description: > > Write pixels goes through GrRenderTask system. > > > > The specific motivation is to remove some uses of GrResourceProvider > > making textures with data in lazy callbacks. But it's a general > > improvement that could allow use cases like writePixels in DDL > > recordings. > > > > Bug: skia:11204 > > > > Change-Id: Ic55c3f75976a1d3a7d93981e21be75a3053ef069 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/356845 > > Reviewed-by: Adlai Holler <adlai@google.com> > > Commit-Queue: Brian Salomon <bsalomon@google.com> > > TBR=bsalomon@google.com,adlai@google.com > > Change-Id: I116caf1e4dd9015270b9d4f810bd26e0e30a6497 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:11204 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/359559 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,adlai@google.com # Not skipping CQ checks because this is a reland. Bug: skia:11204 Change-Id: I7d8f92415995f03301ffb147500d972e6bd17640 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/359561 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
73 lines
2.4 KiB
C++
73 lines
2.4 KiB
C++
/*
|
|
* Copyright 2016 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
// This is a GPU-backend specific test.
|
|
|
|
#include "tests/Test.h"
|
|
|
|
#include "include/gpu/GrDirectContext.h"
|
|
#include "src/gpu/GrDirectContextPriv.h"
|
|
#include "src/gpu/GrImageInfo.h"
|
|
#include "src/gpu/GrSurfaceDrawContext.h"
|
|
#include "src/gpu/GrTextureProxy.h"
|
|
|
|
static const int kSize = 64;
|
|
|
|
static std::unique_ptr<GrSurfaceDrawContext> get_rtc(GrRecordingContext* rContext) {
|
|
return GrSurfaceDrawContext::Make(
|
|
rContext, GrColorType::kRGBA_8888, nullptr, SkBackingFit::kExact, {kSize, kSize});
|
|
}
|
|
|
|
static void check_instantiation_status(skiatest::Reporter* reporter,
|
|
GrSurfaceDrawContext* rtCtx,
|
|
bool wrappedExpectation) {
|
|
REPORTER_ASSERT(reporter, rtCtx->asRenderTargetProxy()->isInstantiated() == wrappedExpectation);
|
|
|
|
GrTextureProxy* tProxy = rtCtx->asTextureProxy();
|
|
REPORTER_ASSERT(reporter, tProxy);
|
|
|
|
REPORTER_ASSERT(reporter, tProxy->isInstantiated() == wrappedExpectation);
|
|
}
|
|
|
|
DEF_GPUTEST_FOR_RENDERING_CONTEXTS(RenderTargetContextTest, reporter, ctxInfo) {
|
|
auto dContext = ctxInfo.directContext();
|
|
|
|
// Calling instantiate on a GrSurfaceDrawContext's textureProxy also instantiates the
|
|
// GrSurfaceDrawContext
|
|
{
|
|
auto rtCtx = get_rtc(dContext);
|
|
|
|
check_instantiation_status(reporter, rtCtx.get(), false);
|
|
|
|
GrTextureProxy* tProxy = rtCtx->asTextureProxy();
|
|
REPORTER_ASSERT(reporter, tProxy);
|
|
|
|
REPORTER_ASSERT(reporter, tProxy->instantiate(dContext->priv().resourceProvider()));
|
|
|
|
check_instantiation_status(reporter, rtCtx.get(), true);
|
|
}
|
|
|
|
// readPixels switches a deferred rtCtx to wrapped
|
|
{
|
|
auto rtCtx = get_rtc(dContext);
|
|
|
|
check_instantiation_status(reporter, rtCtx.get(), false);
|
|
|
|
SkImageInfo dstInfo = SkImageInfo::MakeN32Premul(kSize, kSize);
|
|
GrPixmap dstPM = GrPixmap::Allocate(dstInfo);
|
|
|
|
bool result = rtCtx->readPixels(dContext, dstPM, {0, 0});
|
|
REPORTER_ASSERT(reporter, result);
|
|
|
|
check_instantiation_status(reporter, rtCtx.get(), true);
|
|
}
|
|
|
|
// TODO: in a future world we should be able to add a test that the majority of
|
|
// GrSurfaceDrawContext calls do not force the instantiation of a deferred
|
|
// GrSurfaceDrawContext
|
|
}
|