skia2/gn
John Stiles dc3b8f94f5 Revert "Enable _LIBCPP_DEBUG in Clang for non-Xcode-based debug builds."
This reverts commit 9eb89bac85.

Reason for revert: Repeated Android trybot failures

Encountering ASAN failures of the form:

=================================================================
==10276==ERROR: AddressSanitizer: attempting free on address which was not malloc()-ed: 0xc3d2c5c0 in thread T5
    #0 0xf0e43b58  (/system/lib/libclang_rt.asan-arm-android.so+0xbeb58)
    #1 0xb2157736  (/data/local/tmp/dm+0x2df4736)
    #2 0xb0de3b3c  (/data/local/tmp/dm+0x1a80b3c)
    #3 0xb0e0d036  (/data/local/tmp/dm+0x1aaa036)
    #4 0xb0e0983e  (/data/local/tmp/dm+0x1aa683e)
    #5 0xb0e093ba  (/data/local/tmp/dm+0x1aa63ba)
    #6 0xb0e0cf6a  (/data/local/tmp/dm+0x1aa9f6a)
    #7 0xb0e09ca8  (/data/local/tmp/dm+0x1aa6ca8)
    #8 0xb0e09420  (/data/local/tmp/dm+0x1aa6420)
    #9 0xb0e0cf6a  (/data/local/tmp/dm+0x1aa9f6a)
    #10 0xb0e0983e  (/data/local/tmp/dm+0x1aa683e)
    #11 0xb0e14416  (/data/local/tmp/dm+0x1ab1416)
    #12 0xb0e259a6  (/data/local/tmp/dm+0x1ac29a6)
    #13 0xb0dcd37e  (/data/local/tmp/dm+0x1a6a37e)
    #14 0xb0dcc004  (/data/local/tmp/dm+0x1a69004)
    #15 0xb02030ec  (/data/local/tmp/dm+0xea00ec)
    #16 0xaff381a8  (/data/local/tmp/dm+0xbd51a8)
    #17 0xaff1eade  (/data/local/tmp/dm+0xbbbade)
    #18 0xaff255f4  (/data/local/tmp/dm+0xbc25f4)
    #19 0xb0bea1e4  (/data/local/tmp/dm+0x18871e4)
    #20 0xb0a46c30  (/data/local/tmp/dm+0x16e3c30)
    #21 0xb0a45c9e  (/data/local/tmp/dm+0x16e2c9e)
    #22 0xb0a467b0  (/data/local/tmp/dm+0x16e37b0)
    #23 0xf0e2cf8c  (/system/lib/libclang_rt.asan-arm-android.so+0xa7f8c)
    #24 0xf0c6f502  (/system/lib/libc.so+0x63502)
    #25 0xf0c29f26  (/system/lib/libc.so+0x1df26)

Address 0xc3d2c5c0 is a wild pointer.
SUMMARY: AddressSanitizer: bad-free (/system/lib/libclang_rt.asan-arm-android.so+0xbeb58) 
Thread T5 created by T0 here:
    #0 0xf0e2cdc8  (/system/lib/libclang_rt.asan-arm-android.so+0xa7dc8)
    #1 0xb0a4651a  (/data/local/tmp/dm+0x16e351a)

==10276==ABORTING

Caught signal 6 [Aborted] (173MB RAM, peak 180MB), was running:
	unit test  Codec_PngRoundTrip
	unit test  AAClip
	unit test  Codec_Dimensions
	unit test  Codec_raw
	unit test  crbug_ossfuzz_21688_interfaceblock
	unit test  crbug_ossfuzz_21688_interfaceblock

Caught signal 6 [Aborted] (173MB RAM, peak 180MB), was running:
	unit test  Codec_PngRoundTrip
	unit test  AAClip
	unit test  Codec_Dimensions
	unit test  Codec_raw
	unit test  crbug_ossfuzz_21688_interfaceblock
Likely culprit:
	unit test  crbug_ossfuzz_21688_interfaceblock
+ >/data/local/tmp/rc 
+ echo 1



Original change's description:
> Enable _LIBCPP_DEBUG in Clang for non-Xcode-based debug builds.
> 
> Unlike _GLIBCXX_DEBUG, this is meant to not break the ABI.
> The libc++ bundled with Xcode does not contain debug symbols so we need
> to disable these checks on Mac/iOS.
> 
> Change-Id: Ie4f18e247db9c405b2ce45f388c41dcac8104815
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/297874
> Commit-Queue: John Stiles <johnstiles@google.com>
> Auto-Submit: John Stiles <johnstiles@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,bsalomon@google.com,johnstiles@google.com

Change-Id: I3f717de26428abf9cb26f983b1e82379924419c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/297840
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2020-06-20 14:32:09 +00:00
..
toolchain Delete .a file before writing static library. 2020-06-11 17:19:23 +00:00
__init__.py Make gn directory importable in python 2017-03-20 17:40:30 +00:00
bench.gni Reland "Add create backend texture with color upload bench." 2020-05-05 00:43:52 +00:00
BUILD.gn Revert "Enable _LIBCPP_DEBUG in Clang for non-Xcode-based debug builds." 2020-06-20 14:32:09 +00:00
BUILDCONFIG.gn decouple werror and -isystem in third_party 2020-06-19 21:59:35 +00:00
call.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
checkdir.py fix print functions for python3 gn scripts 2020-03-06 17:42:39 +00:00
checkpath.py Python3 tweaks 2019-12-17 17:12:03 +00:00
codesign_ios.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
compile_ib_files.py Reland "Add launch screen to iOS apps" 2019-09-05 14:05:08 +00:00
compile_processors.py Reland "Fetch clang-format automatically when compiling .fp files." 2020-06-12 13:21:41 +00:00
copy_git_directory.py GN tools: copy_git_directory.py better error message. 2019-11-19 17:04:18 +00:00
core.gni Remove SkReader32, and some API from SkWriter32 2020-06-10 16:45:56 +00:00
cp.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
create_sksl_enums.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
effects_imagefilters.gni Add new SkImageFilters factory API 2019-08-02 13:33:35 +00:00
effects.gni harmonize rewrite-includes and gn-format checks 2020-04-03 17:00:54 +00:00
find_headers.py Python3 tweaks 2019-12-17 17:12:03 +00:00
find_msvc.py Add Preview to list of possible MSVC versions. 2020-04-30 19:54:33 +00:00
find_xcode_sysroot.py fix print functions for python3 gn scripts 2020-03-06 17:42:39 +00:00
flutter_defines.gni ignore SK_DISABLE_READBUFFER 2020-06-09 16:16:57 +00:00
fuchsia_defines.gni remove legacy hinting-enum guards 2018-11-28 20:15:03 +00:00
gen_plist_ios.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
gm.gni Add a test for wide butt caps 2020-06-16 23:00:33 +00:00
gn_meta_sln.py fix print functions for python3 gn scripts 2020-03-06 17:42:39 +00:00
gn_to_bp_utils.py Android test to depend on icu and harfbuzz. 2020-06-02 21:26:25 +00:00
gn_to_bp.py Regularize selection of fontmgr. 2020-06-11 12:28:03 +00:00
gn_to_cmake.py [infra] Change CMake build to use a temporary directory 2020-01-14 11:41:55 +00:00
gpu.gni GrTextContext::Options -> GrSDFTOptions 2020-06-15 17:14:04 +00:00
highest_version_dir.py fix print functions for python3 gn scripts 2020-03-06 17:42:39 +00:00
ios.gni harmonize rewrite-includes and gn-format checks 2020-04-03 17:00:54 +00:00
is_clang.py fix print functions for python3 gn scripts 2020-03-06 17:42:39 +00:00
make_gm_gni.py GMs: re-sort gni, script to regenerate gni, file name convention 2019-05-02 20:08:37 +00:00
opts.gni add structure for normal SKX opts 2020-06-05 13:48:39 +00:00
pdf.gni Make skia_use_xps option work on Windows 2020-03-24 17:09:33 +00:00
push_to_android.py skia_android_serial = "auto" 2017-01-12 16:30:17 +00:00
rm.py Delete .a file before writing static library. 2020-06-11 17:19:23 +00:00
run_sksllex.py Reland "Fetch clang-format automatically when compiling .fp files." 2020-06-12 13:21:41 +00:00
samples.gni Add an interactive sample that fits cubics to circular arcs 2020-06-09 23:04:03 +00:00
shared_sources.gni add structure for normal SKX opts 2020-06-05 13:48:39 +00:00
skia.gni Use Mac font manager for both iOS and macOS 2020-06-17 21:50:10 +00:00
sksl.gni Remove PremulInput and GrPremulInputFragmentProcessor.fp from Skia. 2020-06-08 21:04:46 +00:00
tests.gni Fix SkParse::FindNamedColor OOB 2020-06-17 14:23:14 +00:00
utils.gni Split out coretext fontmgr factory. 2020-06-06 04:06:32 +00:00
xps.gni harmonize rewrite-includes and gn-format checks 2020-04-03 17:00:54 +00:00