skia2/bench/GrQuadBench.cpp
Brian Salomon 9fa47cc1c6 Make class members that are static constexpr also be inline.
This is in prep for compiling with -std=c++14 and -Wno-c++17-extensions
when building with clang. Chrome has encountered problems with
third_party headers that are included both in Skia and other Chrome
sources that produce different code based on whether preprocessor macros
indicate a C++14 or C++17 compilation.

In C++17 they are already inline implicitly. When compiling with C++14
we can get linker errors unless they're explicitly inlined or defined
outside the class. With -Wno-c++17-extensions we can explicitly inline
them in the C++14 build because the warning that would be generated
about using a C++17 language extension is suppressed.

We cannot do this in public headers because we support compiling with
C++14 without suppressing the C++17 language extension warnings.

Bug: chromium:1257145
Change-Id: Iaf5f4c62a398f98dd4ca9b7dfb86f2d5cab21d66
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457498
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-10-11 16:22:59 +00:00

75 lines
2.3 KiB
C++

/*
* Copyright 2020 Google LLC
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
#include "bench/Benchmark.h"
#include "include/utils/SkRandom.h"
#include "src/gpu/geometry/GrQuad.h"
#include "src/gpu/geometry/GrQuadUtils.h"
class GrQuadBoundsBench : public Benchmark {
public:
GrQuadBoundsBench(bool perspective)
: fPerspective(perspective) {
fName.printf("grquad_bounds_%s", perspective ? "3d" : "2d");
}
bool isSuitableFor(Backend backend) override {
return backend == kNonRendering_Backend;
}
protected:
inline static constexpr int kQuadCount = 1000;
const char* onGetName() override {
return fName.c_str();
}
void onDelayedSetup() override {
SkRandom r;
for (int i = 0; i < kQuadCount; ++i) {
for (int j = 0; j < 4; ++j) {
fQuads[i].xs()[j] = r.nextRangeF(-100.f, 100.f);
fQuads[i].ys()[j] = r.nextRangeF(-100.f, 100.f);
if (fPerspective) {
// Biased towards in front of the viewpoint, but do include some that require
// the vertices to be clipped against w = 0.
fQuads[i].ws()[j] = r.nextRangeF(-1.f, 10.f);
} else {
fQuads[i].ws()[j] = 1.f;
}
}
fQuads[i].setQuadType(fPerspective ? GrQuad::Type::kPerspective
: GrQuad::Type::kGeneral);
}
}
void onDraw(int loops, SkCanvas*) override {
SkScalar area = 0.f;
for (int i = 0; i < loops; ++i) {
for (int j = 0; j < kQuadCount; ++j) {
SkRect qb = fQuads[j].bounds();
area += qb.width() + qb.height();
}
}
// Must persist this calculation in order to prevent the compiler from optimizing the
// loops away.
fArea = area;
}
SkString fName;
bool fPerspective;
GrQuad fQuads[kQuadCount];
SkScalar fArea;
using INHERITED = Benchmark;
};
///////////////////////////////////////////////////////////////////////////////////////////////////
DEF_BENCH( return new GrQuadBoundsBench(/* persp */ false); )
DEF_BENCH( return new GrQuadBoundsBench(/* persp */ true); )