7bf799956d
This is a reland of e58831cd95
Original change's description:
> Add format-specifier warnings to SkDebugf.
>
> This CL fixes up many existing format-specifier violations in Skia.
> Note that GCC has a warning for formatting nothing, so existing calls to
> `SkDebugf("")` have been removed, or replaced with `SkDebugf("%s", "")`.
> These were apparently meant to be used as a place to set a breakpoint.
>
> Some of our clients also use SkDebug with bad format specifiers, so this
> check is currently only enabled when SKIA_IMPLEMENTATION is true.
>
> Change-Id: I8177a1298a624c6936adc24e0d8f481362a356d0
> Bug: skia:12143
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420902
> Auto-Submit: John Stiles <johnstiles@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>
Bug: skia:12143
Change-Id: Id3c0c21436ebd13899908d5ed5d44c42a0e23921
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421918
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
38 lines
1.8 KiB
C++
38 lines
1.8 KiB
C++
// Copyright 2019 Google LLC.
|
|
// Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.
|
|
#include "tools/fiddle/examples.h"
|
|
// HASH=e47b911f94fc629f756a829e523a2a89
|
|
REG_FIDDLE(ImageInfo_shiftPerPixel, 256, 256, true, 0) {
|
|
const char* color_type(SkColorType ct) {
|
|
switch (ct) {
|
|
case kUnknown_SkColorType: return "Unknown";
|
|
case kAlpha_8_SkColorType: return "Alpha_8";
|
|
case kRGB_565_SkColorType: return "RGB_565";
|
|
case kARGB_4444_SkColorType: return "ARGB_4444";
|
|
case kRGBA_8888_SkColorType: return "RGBA_8888";
|
|
case kRGB_888x_SkColorType: return "RGB_888x";
|
|
case kBGRA_8888_SkColorType: return "BGRA_8888";
|
|
case kRGBA_1010102_SkColorType: return "RGBA_1010102";
|
|
case kRGB_101010x_SkColorType: return "RGB_101010x";
|
|
case kGray_8_SkColorType: return "Gray_8";
|
|
case kRGBA_F16Norm_SkColorType: return "RGBA_F16Norm";
|
|
case kRGBA_F16_SkColorType: return "RGBA_F16";
|
|
case kRGBA_F32_SkColorType: return "RGBA_F32";
|
|
default: SkASSERT(false); return nullptr;
|
|
}
|
|
}
|
|
void draw(SkCanvas* canvas) {
|
|
for (SkColorType colorType : {
|
|
kUnknown_SkColorType, kAlpha_8_SkColorType, kRGB_565_SkColorType,
|
|
kARGB_4444_SkColorType, kRGBA_8888_SkColorType, kRGB_888x_SkColorType,
|
|
kBGRA_8888_SkColorType, kRGBA_1010102_SkColorType, kRGB_101010x_SkColorType,
|
|
kGray_8_SkColorType, kRGBA_F16_SkColorType
|
|
} ) {
|
|
SkImageInfo info = SkImageInfo::Make(1, 1, colorType, kOpaque_SkAlphaType);
|
|
SkDebugf("color: k" "%s" "_SkColorType" "%*s" "shiftPerPixel: %d\n",
|
|
color_type(colorType), (int)(14 - strlen(color_type(colorType))), " ",
|
|
info.shiftPerPixel());
|
|
}
|
|
}
|
|
} // END FIDDLE
|