AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
e47f1a7c74
skia2/include
History
mtklein e47f1a7c74 Fix UB in SkDivBits 
This used to:
  DIVBITS_ITER was shifting bits up into the sign bit, which is a no-no.
  This turns numer into a uint32_t to make those defined, and adds a few notes.

  x >= 0 is always true for unsigned x, so we needed a few small logic refactors.

Instead it now:
  Only call SkDivBits if the old behavior is required.
  Usually, just do the divide with /.

BUG=skia:3562

Committed: https://skia.googlesource.com/skia/+/988adddd48322bfa3e3cb0c017cfce71fbbf1123

Committed: https://skia.googlesource.com/skia/+/6c7b104b4c08ae2332a6ce3c8c906da4e8c51e5f

TBR=reed@google.com
No API change.

Review URL: https://codereview.chromium.org/1455163004
2015-11-20 13:58:19 -08:00
..
android Move SkBitmapRegionDecoder to include/android and src/android 2015-11-13 06:11:09 -08:00
animator Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
c Documentation: C API comments 2015-09-01 10:45:09 -07:00
codec Fix -Wunused-parameter errors in SkCodec.h in Android 2015-11-11 12:43:07 -08:00
config remove SkInstCnt 2015-06-26 11:45:03 -07:00
core Fix UB in SkDivBits 2015-11-20 13:58:19 -08:00
device/xps C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla} 2015-03-25 18:17:32 -07:00
effects change more effects to only expose factories 2015-10-12 11:10:10 -07:00
gpu Remove unsigned < signed comparison. 2015-11-19 09:53:22 -08:00
images remove SkInstCnt 2015-06-26 11:45:03 -07:00
pathops Revert of Revert of remove SK_SUPPORT_LEGACY_PATHOP_ENUMS (patchset #1 id:1 of https://codereview.chromium.org/1203983003/) 2015-06-26 10:23:07 -07:00
pipe Fixing leaky handling of SkImage in SkDeferredCanvas. 2015-06-02 11:47:45 -07:00
ports SkFontConfigInterface::createTypeface() 2015-11-20 13:47:55 -08:00
private Record concat as Concat. 2015-11-19 12:08:24 -08:00
svg Remove SK_OFFSETOF from SkTypes, clean up offsetof usage. 2015-08-25 12:05:55 -07:00
utils Move SkTemplates.h to private. 2015-08-19 11:56:48 -07:00
views Replace SkFunction with std::function 2015-11-12 10:41:05 -08:00
xml Move SkTemplates.h to private. 2015-08-19 11:56:48 -07:00