e58831cd95
This CL fixes up many existing format-specifier violations in Skia.
Note that GCC has a warning for formatting nothing, so existing calls to
`SkDebugf("")` have been removed, or replaced with `SkDebugf("%s", "")`.
These were apparently meant to be used as a place to set a breakpoint.
Some of our clients also use SkDebug with bad format specifiers, so this
check is currently only enabled when SKIA_IMPLEMENTATION is true.
Change-Id: I8177a1298a624c6936adc24e0d8f481362a356d0
Bug: skia:12143
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420902
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
15 lines
607 B
C++
15 lines
607 B
C++
// Copyright 2019 Google LLC.
|
|
// Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.
|
|
#include "tools/fiddle/examples.h"
|
|
// HASH=19ac8bb81854680bd408fec8cb797d5c
|
|
REG_FIDDLE(Pixmap_rowBytes, 256, 256, true, 0) {
|
|
void draw(SkCanvas* canvas) {
|
|
SkPixmap badPixmap = {SkImageInfo::MakeA8(4, 4), nullptr, 2};
|
|
SkPixmap okPixmap = {SkImageInfo::MakeA8(4, 4), nullptr, 8};
|
|
for (auto& pixmap : { badPixmap, okPixmap } ) {
|
|
SkDebugf("rowBytes: %zu minRowBytes: %zu\n", pixmap.rowBytes(),
|
|
pixmap.info().minRowBytes());
|
|
}
|
|
}
|
|
} // END FIDDLE
|