skia2/experimental/svg/model/SkSVGSVG.cpp
John Stiles a008b0fa8b Enable ClangTidy check readability-redundant-smartptr-get.
To my surprise, this even works with homegrown smart pointers (such as
SkTLazy).

https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-smartptr-get.html

Find and remove redundant calls to smart pointer’s .get() method.

Examples:

  ptr.get()->Foo()  ==>  ptr->Foo()
  *ptr.get()  ==>  *ptr
  *ptr->get()  ==>  **ptr
  if (ptr.get() == nullptr) ... => if (ptr == nullptr) ...

Change-Id: I8ff541e0229656b4d8e875c8053a7e6138302547
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310976
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-08-16 15:56:48 +00:00

110 lines
3.1 KiB
C++

/*
* Copyright 2016 Google Inc.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
#include "experimental/svg/model/SkSVGRenderContext.h"
#include "experimental/svg/model/SkSVGSVG.h"
#include "experimental/svg/model/SkSVGValue.h"
#include "include/core/SkCanvas.h"
SkSVGSVG::SkSVGSVG() : INHERITED(SkSVGTag::kSvg) { }
bool SkSVGSVG::onPrepareToRender(SkSVGRenderContext* ctx) const {
auto viewPortRect = ctx->lengthContext().resolveRect(fX, fY, fWidth, fHeight);
auto contentMatrix = SkMatrix::Translate(viewPortRect.x(), viewPortRect.y());
auto viewPort = SkSize::Make(viewPortRect.width(), viewPortRect.height());
if (fViewBox.isValid()) {
const SkRect& viewBox = *fViewBox;
// An empty viewbox disables rendering.
if (viewBox.isEmpty()) {
return false;
}
// A viewBox overrides the intrinsic viewport.
viewPort = SkSize::Make(viewBox.width(), viewBox.height());
contentMatrix.preConcat(
SkMatrix::MakeRectToRect(viewBox, viewPortRect, SkMatrix::kFill_ScaleToFit));
}
if (!contentMatrix.isIdentity()) {
ctx->saveOnce();
ctx->canvas()->concat(contentMatrix);
}
if (viewPort != ctx->lengthContext().viewPort()) {
ctx->writableLengthContext()->setViewPort(viewPort);
}
return this->INHERITED::onPrepareToRender(ctx);
}
void SkSVGSVG::setX(const SkSVGLength& x) {
fX = x;
}
void SkSVGSVG::setY(const SkSVGLength& y) {
fY = y;
}
void SkSVGSVG::setWidth(const SkSVGLength& w) {
fWidth = w;
}
void SkSVGSVG::setHeight(const SkSVGLength& h) {
fHeight = h;
}
void SkSVGSVG::setViewBox(const SkSVGViewBoxType& vb) {
fViewBox.set(vb);
}
void SkSVGSVG::onSetAttribute(SkSVGAttribute attr, const SkSVGValue& v) {
switch (attr) {
case SkSVGAttribute::kX:
if (const auto* x = v.as<SkSVGLengthValue>()) {
this->setX(*x);
}
break;
case SkSVGAttribute::kY:
if (const auto* y = v.as<SkSVGLengthValue>()) {
this->setY(*y);
}
break;
case SkSVGAttribute::kWidth:
if (const auto* w = v.as<SkSVGLengthValue>()) {
this->setWidth(*w);
}
break;
case SkSVGAttribute::kHeight:
if (const auto* h = v.as<SkSVGLengthValue>()) {
this->setHeight(*h);
}
break;
case SkSVGAttribute::kViewBox:
if (const auto* vb = v.as<SkSVGViewBoxValue>()) {
this->setViewBox(*vb);
}
break;
default:
this->INHERITED::onSetAttribute(attr, v);
}
}
// https://www.w3.org/TR/SVG11/coords.html#IntrinsicSizing
SkSize SkSVGSVG::intrinsicSize(const SkSVGLengthContext& lctx) const {
// Percentage values do not provide an intrinsic size.
if (fWidth.unit() == SkSVGLength::Unit::kPercentage ||
fHeight.unit() == SkSVGLength::Unit::kPercentage) {
return SkSize::Make(0, 0);
}
return SkSize::Make(lctx.resolve(fWidth, SkSVGLengthContext::LengthType::kHorizontal),
lctx.resolve(fHeight, SkSVGLengthContext::LengthType::kVertical));
}