AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
ea08a0dbd3
skia2/modules/canvaskit
History
Robert Phillips cb77eab343 Revert "Switch to using a Float32Array (bound as value array) for color." 
This reverts commit 4e79b6730d.

Reason for revert: Bad canvaskit GM images

Original change's description:
> Switch to using a Float32Array (bound as value array) for color.
> 
> Change-Id: I1bcca931954b1399c79f4074a3d57a68847ac785
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276757
> Commit-Queue: Nathaniel Nifong <nifong@google.com>
> Reviewed-by: Kevin Lubick <kjlubick@google.com>

TBR=kjlubick@google.com,nifong@google.com

Change-Id: I2f5e995ccee415a49f813b5ba61c095acbc445b5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278766
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-03-24 14:20:04 +00:00
..
canvaskit [canvaskit] Update to 0.14.0 2020-03-18 19:47:15 +00:00
fonts [canvaskit] Clean up embedded fonts 2019-10-09 14:51:39 +00:00
htmlcanvas Revert "Switch to using a Float32Array (bound as value array) for color." 2020-03-24 14:20:04 +00:00
perf [canvaskit] Roll chrome version for testing 2019-10-18 17:37:52 +00:00
tests Revert "Switch to using a Float32Array (bound as value array) for color." 2020-03-24 14:20:04 +00:00
.gitignore [canvaskit] Move from experimental to modules 2019-03-11 21:09:52 +00:00
canvaskit_bindings.cpp Revert "Switch to using a Float32Array (bound as value array) for color." 2020-03-24 14:20:04 +00:00
catchExceptionNop.js JS files to support running jasmine tests in google3 2020-03-09 14:20:27 +00:00
CHANGELOG.md Revert "Switch to using a Float32Array (bound as value array) for color." 2020-03-24 14:20:04 +00:00
compile.sh Revert "Revert "Revert "Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots"""" 2020-03-20 17:11:58 +00:00
cpu.js rm CanvasKit.HEAPU8.buffer caching (fix UAF bug). 2020-01-15 14:48:36 +00:00
debug.js Expose 4x4 matrices on canvas in a way similar to SimpleMatrix, add example. 2020-02-22 00:12:13 +00:00
externs.js Revert "Switch to using a Float32Array (bound as value array) for color." 2020-03-24 14:20:04 +00:00
font.js Clean up Enums in Canvaskit 2020-03-10 15:17:20 +00:00
gpu.js [canvaskit] Request an 8 bit stencil buffer from the WebGL 1/2 context 2019-11-15 17:21:48 +00:00
helper.js Revert "Switch to using a Float32Array (bound as value array) for color." 2020-03-24 14:20:04 +00:00
interface.js Revert "Switch to using a Float32Array (bound as value array) for color." 2020-03-24 14:20:04 +00:00
karma.bench.conf.js [canvaskit] Try some things to reduce GPU test flakiness 2019-11-21 20:56:42 +00:00
karma.conf.js [canvaskit] Try some things to reduce GPU test flakiness 2019-11-21 20:56:42 +00:00
karma.google3.conf.js JS files to support running jasmine tests in google3 2020-03-09 14:20:27 +00:00
Makefile Remove ln "-T" option from cavaskit demo 2020-03-19 11:12:05 +00:00
package.json [canvaskit] Move from experimental to modules 2019-03-11 21:09:52 +00:00
paragraph_bindings.cpp Revert "Switch to using a Float32Array (bound as value array) for color." 2020-03-24 14:20:04 +00:00
paragraph.js Revert "Switch to using a Float32Array (bound as value array) for color." 2020-03-24 14:20:04 +00:00
particles_bindings.cpp Revert "Switch to using a Float32Array (bound as value array) for color." 2020-03-24 14:20:04 +00:00
particles.js [canvaskit] Expose bindings to particles uniforms. 2020-02-21 14:43:01 +00:00
pathops.js [canvaskit] Add build flag for pathops 2020-01-06 13:10:43 +00:00
postamble.js [canvaskit] Move from experimental to modules 2019-03-11 21:09:52 +00:00
preamble.js [canvaskit] Move from experimental to modules 2019-03-11 21:09:52 +00:00
README.md [canvaskit] Update build script to support latest Emscripten 2020-01-28 15:41:58 +00:00
ready.js [canvaskit] Move from experimental to modules 2019-03-11 21:09:52 +00:00
release.js Expose 4x4 matrices on canvas in a way similar to SimpleMatrix, add example. 2020-02-22 00:12:13 +00:00
rt_shader.js [canvaskit] Support children shaders into runtime shaders 2020-02-22 12:38:52 +00:00
serve.py [canvaskit] Move from experimental to modules 2019-03-11 21:09:52 +00:00
skottie_bindings.cpp Revert "Switch to using a Float32Array (bound as value array) for color." 2020-03-24 14:20:04 +00:00
skottie.js Use ResourceProvider in particles 2019-11-27 16:45:23 +00:00
skp.js Add support for reading .skp files in CanvasKit. 2020-01-15 14:46:37 +00:00
WasmAliases.h Revert "Switch to using a Float32Array (bound as value array) for color." 2020-03-24 14:20:04 +00:00

README.md

Prerequisites

To compile CanvasKit, you will first need to install emscripten. This will set the environment EMSDK (among others) which is required for compilation.

Compile and Test Locally

make release  # make debug is much faster and has better error messages
make local-example

This will print a local endpoint for viewing the example. You can experiment with the CanvasKit API by modifying ./canvaskit/example.html and refreshing the page. For some more experimental APIs, there's also ./canvaskit/extra.html.

For other available build targets, see Makefile and compile.sh. For example, building a stripped-down version of CanvasKit with no text support or any of the "extras", one might run:

./compile.sh no_skottie no_particles no_font

Such a stripped-down version is about half the size of the default release build.

Infrastructure Playbook

When dealing with CanvasKit (or PathKit) on our bots, we use Docker. Check out $SKIA_ROOT/infra/wasm-common/docker/README.md for more on building/editing the images used for building and testing.

Updating the version of Emscripten we build/test with

This presumes you have updated emscripten locally to a newer version of the sdk and verified/fixed any build issues that have arisen.

  1. Edit $SKIA_ROOT/infra/wasm-common/docker/emsdk-base/Dockerfile to install and activate the desired version of Emscripten.
  2. Edit $SKIA_ROOT/infra/wasm-common/docker/Makefile to have EMSDK_VERSION be set to that desired version. If there is a suffix that is not _v1, reset it to be _v1. If testing the image later does not work and edits are made to the emsdk-base Dockerfile to correct that, increment to _v2,_v3, etc to force the bots to pick up the new image.
  3. In $SKIA_ROOT/infra/wasm-common/docker/, run make publish_emsdk_base
  4. Edit $SKIA_ROOT/infra/canvaskit/docker/canvaskit-emsdk/Dockerfile to be based off the new version from step 2. CanvasKit has its own docker image because it needs a few extra dependencies to build with font support.
  5. Edit $SKIA_ROOT/infra/canvaskit/docker/Makefile to have the same version from step 2. It's easiest to keep the emsdk-base and canvaskit-emsdk versions be in lock-step.
  6. In $SKIA_ROOT/infra/canvaskit/docker/, make publish_canvaskit_emsdk.
  7. In $SKIA_ROOT/infra/bots/recipe_modules/build/, update canvaskit.py and pathkit.py to have DOCKER_IMAAGE point to the desired tagged Docker containers from steps 2 and 5 (which should be the same).
  8. In $SKIA_ROOT/infra/bots/, run make train to re-train the recipes.
  9. Optional: Run something like git grep 1\\.38\\. in $SKIA_ROOT to see if there are any other references that need updating.
  10. Upload a CL with all the changes. Run all Test.+CanvasKit, Perf.+CanvasKit, Test.+PathKit, Perf.+PathKit jobs to make sure the new builds pass all tests and don't crash the perf harnesses.
  11. Send out CL for review. Feel free to point the reviewer at these steps.