395ddc3d51
This reverts commitf6e0f58b2e
. Reason for revert: benches and tests updated here: https://skia-review.googlesource.com/c/skia/+/317380 Original change's description: > Revert "Enable novel GrClipStack on bots, disable elsewhere" > > This reverts commite1ade2ac4a
. > > Reason for revert: Need to remove benchmarks that use deprecated SkClipOps first. > > Original change's description: > > Enable novel GrClipStack on bots, disable elsewhere > > > > As a result of this change, the new GrClipStack will run on all of our > > default bots. However, the SK_DISABLE_NEW_GR_CLICK_STACK define is used > > to explicitly disable the clip stack when we build for the Android > > Framework, Google3, Flutter, and Fuchsia. These projects can have staging > > controlled from within the skia repo. This CL in chromium also disables > > the new clip stack: https://chromium-review.googlesource.com/c/chromium/src/+/2412768 > > and must land before this CL does in Skia. > > > > When GrClipStack originally landed, I had it disabled by checking the > > value of the define SK_USE_NEW_GR_CLICK_STACK for 0 or 1. To be a little > > simpler, and work with the flutter and fuchsia gn defines, this CL > > switches GrClipStack control over to SK_DISABLE_NEW_GR_CLICK_STACK and > > it just checks for whether or not it's defined. > > > > Bug: skia:10205 > > Change-Id: I6b8bd18290844c02839fe99fdf629b48ffd86f27 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317209 > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > > TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com > > Change-Id: I14fddccfdea8e91ebad92e55193b0034f8bb28af > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:10205 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317377 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > Commit-Queue: Michael Ludwig <michaelludwig@google.com> TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com # Not skipping CQ checks because this is a reland. Bug: skia:10205 Change-Id: I1f26496437ed04a79e9c1058428cdc867ae3be39 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317385 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
10 lines
202 B
Plaintext
10 lines
202 B
Plaintext
# Copyright 2018 Google Inc.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
fuchsia_defines = [
|
|
# Staging
|
|
"SK_DISABLE_NEW_GR_CLIP_STACK",
|
|
]
|